• Recent
  • Tags
  • Unsolved
  • Solved
  • MagicMirror² Repository
  • Documentation
  • 3rd-Party-Modules
  • Donate
  • Discord
  • Register
  • Login
MagicMirror Forum
  • Recent
  • Tags
  • Unsolved
  • Solved
  • MagicMirror² Repository
  • Documentation
  • 3rd-Party-Modules
  • Donate
  • Discord
  • Register
  • Login
A New Chapter for MagicMirror: The Community Takes the Lead
Read the statement by Michael Teeuw here.

error loop

Scheduled Pinned Locked Moved Development
11 Posts 3 Posters 3.0k Views 3 Watching
Loading More Posts
  • Oldest to Newest
  • Newest to Oldest
  • Most Votes
Reply
  • Reply as topic
Log in to reply
This topic has been deleted. Only users with topic management privileges can see it.
  • J Offline
    jchenaud @doubleT
    last edited by Aug 17, 2018, 12:04 PM

    @doublet
    i am not sure to understand

    if i remove my module i have one error (i correct after if i can)

    but the looping are ok

    my module

    Module.register("MMM-keylogger",{
    	curentPage: -1,
    	defaults: {
    		updateInterval:  1000,
    	},
    
    	start: function(){
            console.log(this.name + " has started...!!!!!!");
    		this.sendSocketNotification("START", this.config);
    	},
    
    	socketNotificationReceived: function(notification, payload) {
    		if(notification === "KEY_P"){
    			this.dataFile = payload;
    			this.updateDom();
            }
    	},
    
    	getDom: function(){
    		var wrapper = document.createElement("div");
    		wrapper.innerHTML = this.dataFile
    			if(this.dataFile){
    				switch(wrapper.innerHTML) {
    					case "Right":
    					this.sendNotification("PAGE_INCREMENT");
    						break;
    					case "Left" :
    					this.sendNotification("PAGE_DECREMENT");
    						break;
    					default:
    					Log.log(`key : ${wrapper.innerHTML} pressed but not assigned`);
    				}
    				this.sendSocketNotification("Clear_key")
    			}
    			return wrapper;
    	},
    
    });
    
    const NodeHelper = require("node_helper");
    const fs= require("fs");
    
    module.exports = NodeHelper.create({
    //here comes the part of the nodehelper after the 3 dots as posted above
    
    	socketNotificationReceived: function(notification, payload) {
    		if(notification === "START"){
    			this.config = payload;
    			this.readData();
        			setInterval(() => {
            			this.readData();
        			}, this.config.updateInterval);
    		}
    		if(notification === "Clear_key")
    		{
    			fs.open('Key_pres.txt', 'r+', function(err, fd) {
    				if (err) {
    				   return console.error(err);
    				}
    				fs.ftruncate(fd, function(err){
    					if (err){
    					   console.log(err);
    					}
    					console.log("supose to trucate");
    				})
    			});
    	}
    	},
    
    	readData: function(){
    		fs.readFile("Key_pres.txt", "utf8", (err, data) => {
    			if (err) throw err;
    		   this.sendSocketNotification("KEY_P", data);
       })		
    	}
    });
    

    i have no warning of no declare class or something like that on VS

    sorry but i beginner with organisation of MM

    thanks for your rapidity :)

    1 Reply Last reply Reply Quote 0
    • ? Offline
      A Former User
      last edited by Aug 17, 2018, 12:55 PM

      Have you assigned proper position for that module in config.js?

      1 Reply Last reply Reply Quote 0
      • J Offline
        jchenaud
        last edited by Aug 17, 2018, 1:30 PM

        @Sean

        thanks you have suppress the first error on screen-shot
        but my modul write something on screen and i don’t want that but its can be cool for debug

        ? 1 Reply Last reply Aug 17, 2018, 1:38 PM Reply Quote 0
        • ? Offline
          A Former User @jchenaud
          last edited by A Former User Aug 17, 2018, 1:39 PM Aug 17, 2018, 1:38 PM

          @jchenaud
          If your module doesn’t need to possess area in MagicMirror (even your module would draw something on MM), you wouldn’t use .getDom(). That function should be called by MM.core when the refreshing screen is needed. but your .getDom() will not work properly because there is no position to be drawn on.
          So you should assign a position to use .getDom().
          (Of course, there is some trick without .getDom() and position to draw something on MM)

          J 1 Reply Last reply Aug 17, 2018, 2:20 PM Reply Quote 0
          • J Offline
            jchenaud @Guest
            last edited by Aug 17, 2018, 2:20 PM

            @sean
            thk for explain. i will try something different to get.getDom().

            have you an idea for appendChild error ?

            ? 1 Reply Last reply Aug 17, 2018, 2:30 PM Reply Quote 0
            • ? Offline
              A Former User @jchenaud
              last edited by A Former User Aug 17, 2018, 2:34 PM Aug 17, 2018, 2:30 PM

              @jchenaud I think that is also caused by unproper using of .getDom()
              Better practice is;

              1. use .getDom() with proper position
              2. or, not using .getDom().
              • You can start to manipulate your DOM when DOM_OBJECTS_CREATED notification from MM Core.
                like these;
              notificationReceived: function(noti, payload, sender) {
                switch(noti) {
                  case 'DOM_OBJECTS_CREATED':
                    this.initMyDOM()
                    break
                }
              },
              initMyDOM: function() {
                var wrapper = document.createElement("div")
                wrapper.id = "myDOM"
                var container = document.body
                container.appendChild(wrapper)
                
               var timer = setInterval(()=>{
                var d = document.getElementById("myDOM")
                d.innerHTML = "This is rendered without getDom and position"
                }, 1000)
              }
              
              

              This is not tested on real device, but you can catch the idea.

              1 Reply Last reply Reply Quote 0
              • J Offline
                jchenaud
                last edited by Aug 17, 2018, 2:57 PM

                thk i will try :)

                1 Reply Last reply Reply Quote 0
                • J Offline
                  jchenaud
                  last edited by Aug 20, 2018, 7:06 AM

                  @Sean you are awesome !!!
                  my module almost work

                  just one problem i need to give a position in config. i think i have miss something

                  Module.register("MMM-keylogger",{
                  	defaults: {
                  		 updateInterval:  1500,
                  	},
                  
                  	notificationReceived: function(noti, payload, sender) {
                  		Log.log(`notif : ${noti}`);
                  		switch(noti) {
                  		  case 'MODULE_DOM_CREATED':
                  			this.initMyDOM()
                  			break
                  		}
                  	  },
                  	  initMyDOM: function() {
                  		var wrapper = document.createElement("div")
                  		wrapper.id = "myDOM"
                  		var container = document.body
                  		container.appendChild(wrapper)
                  		Log.log(`init DOM `);
                  		var timer = setInterval(()=>{
                  			var d = document.getElementById("myDOM")
                  			d.innerHTML =  this.dataFile
                  		Log.log(`key : ${d.innerHTML} , ${this.dataFile} `);
                  			if(d.innerHTML){
                  				switch(d.innerHTML) {
                  					case "Right":
                  					this.sendNotification("PAGE_INCREMENT");
                  						break;
                  					case "Left" :
                  					this.sendNotification("PAGE_DECREMENT");
                  						break;
                  					default:
                  					Log.log(`key : ${d.innerHTML} pressed but not assigned`);
                  				}
                  				this.sendSocketNotification("Clear_key")
                  			}
                  			
                  			}, 1500)
                  	},
                  
                  	start: function(){
                          console.log(this.name + " has started...!!!!!!");
                  		this.sendSocketNotification("START", this.config);
                  	},
                  
                  	socketNotificationReceived: function(notification, payload) {
                  		if(notification === "KEY_P"){
                  			this.dataFile = payload;
                  			// this.updateDom();
                          }
                  	},
                  

                  if i don’t give position on config its don’t work ! if i have understand what you have say. this is suppose to work

                  other question : one of my other module have subitly stop to work and make same error but in this module in need position and update with Miror display. so my question is : this is possible this modification have impact on other module ?

                  ? 1 Reply Last reply Aug 20, 2018, 7:18 AM Reply Quote 0
                  • ? Offline
                    A Former User @jchenaud
                    last edited by A Former User Aug 20, 2018, 7:21 AM Aug 20, 2018, 7:18 AM

                    @jchenaud
                    MODULE_DOM_CREATED is not so good time. Because, It would be emitted when Your DOM was created, but All of other DOMs are not rendered yet. DOM_OBJECTS_CREATED is better.
                    If you want to using position, use .getDom(). A usual way to use position is, in .getDom() to initialize your rendering and to prepare the framework to draw.
                    And you can choose one of drawing tricks.

                    1. getDom() shall take care of all the drawing. in .getDom() put all of your rendering framework and contents. and you can refresh your render by calling .updateDom()

                    2. getDom() shall draw only framework, Contents should be drawn by your another function with HTML DOM manipulation.

                    3. or getDom() just return empty wrapper, Then, all of your rendering and refreshing will be performed by yourself.

                    Which is better? case-by-case.

                    For the last question; I cannot figure out. :)

                    1 Reply Last reply Reply Quote 0
                    • 1
                    • 2
                    • 1 / 2
                    1 / 2
                    • First post
                      7/11
                      Last post
                    Enjoying MagicMirror? Please consider a donation!
                    MagicMirror created by Michael Teeuw.
                    Forum managed by Sam, technical setup by Karsten.
                    This forum is using NodeBB as its core | Contributors
                    Contact | Privacy Policy