Has anyone got MMM-Remote-Control working on MM 2.11 ?

Stoffbeuteluwe

I have updated my MM with git pull & npm install …than I had the same problem.
Today I tried Sam‘s Upgrade Script and now everything is working perfect.

RoadRunnr1469

I had a copy of the old file socketclient.js located in MagicMirror/js folder. once I replaced the new new file with the backup it is working.
Here is the Key line that needs fixed.

replace

// Private Methods
self.socket = io("/" + self.moduleName, {
	path: window.location.pathname + "socket.io"
});

with

// Private Methods
    self.socket = io("/" + self.moduleName);

karsten13

@Stoffbeuteluwe

so your are running MM v2.11.0 with MMM-RemoteControl and all your Menu Items work?

E.g. if I open 192.168.xxx.yyy:8080/remote.html#main-menu in the browser and click on Edit config.js the popup opening only contains 3 lines with undefined.

RoadRunnr1469

@karsten13 yes mine appears to be working, but I don’t edit my config there, I edit via SSH.

I can’t seem to get the upload screenshot to work, but yes I see all my modules.

Stoffbeuteluwe

@karsten13 for me it works after upgrade with sams script

sdetweil

@RoadRunnr1469 said in Has anyone got MMM-Remote-Control working on MM 2.11 ?:

I can’t seem to get the upload screenshot to work, but yes I see all my modules.

posting images is broken

https://github.com/MichMich/MagicMirror/issues/1969

karsten13

@Stoffbeuteluwe

may you can post the content of your ./js/socketclient.js?
So please go into the magicmirror folder and execute cat ./js/socketclient.js and post the output here. Thanks.

RoadRunnr1469

@karsten13

var MMSocket = function(moduleName) {
	var self = this;

	if (typeof moduleName !== "string") {
		throw new Error("Please set the module name for the MMSocket.");
	}

	self.moduleName = moduleName;

	// Private Methods
	self.socket = io("/" + self.moduleName);
	var notificationCallback = function() {};

	var onevent = self.socket.onevent;
	self.socket.onevent = function(packet) {
		var args = packet.data || [];
		onevent.call(this, packet);    // original call
		packet.data = ["*"].concat(args);
		onevent.call(this, packet);      // additional call to catch-all
	};

	// register catch all.
	self.socket.on("*", function(notification, payload) {
		if (notification !== "*") {
			notificationCallback(notification, payload);
		}
	});

	// Public Methods
	this.setNotificationCallback = function(callback) {
		notificationCallback = callback;
	};

	this.sendNotification = function(notification, payload) {
		if (typeof payload === "undefined") {
			payload = {};
		}
		self.socket.emit(notification, payload);
	};
};

karsten13

@RoadRunnr1469

didn’t ask you, because I know your socketclient.js, you applied my patch …

RoadRunnr1469

@karsten13 actually no I didn’t. I had backed up my entire MagicMirror folder and all sub folders before upgrading. I saw another post where they said they changed the socketclient back to before upgrade. so I did the same thing. after making a backup of the new socketclient.js file.