MMM-MyStandings

alecbalec

Great module, I forked it on github and added the English Premier League.

vinp

@my_nerdy_account that looks awesome! Care to share your branch in GitHub?

vinp

@alecbalec I’m testing out the ability to add many more soccer leagues… stay tuned for an update

vinp

I’ve added NCAAM Basketball and lots of different Soccer leagues from ESPN. It should be able to handle all the soccer leagues that have standings/tables available. I looked at how MMM-MyScoreboard did the soccer leagues and used the same naming. Have a look at my code (get latest) and let me know how it goes. thanks!

Newtothis

@vinp Hi

Thanks for the module, really enjoying it and thanks for updating it. I was just wondering if it is possible to have two leagues showing at the same time?

I tried using two instances of the configuration (One for NBA and one for Premier League) in the config.js but this didn’t work. Very new at all of this, so please excuse me if it is really obvious answer

Thanks!

vinp

@Newtothis I dont think this module supports that. I think I read on this forum that if the module uses a node_helper.js it wont be possible. Otherwise you could try copying and renaming a similar folder and setup the MM config with both names. There is a issue logged on my github with your same suggestion. I just haven’t had the chance to look to see how much effort it would take to implement.

sdetweil

@vinp said in MMM-MyStandings:

that if the module uses a node_helper.js it wont be possible

it IS possible… just have to think thru the choices of the solution…

there is only ONE node_helper loaded for all instances of the module.

any sendSocketNotification from the helper to the module (instances) goes to ALL instances at once.

so, one could send the module identifier from the module.js to the node_helper, and use THAT as a key into a storage area saved by module instance (config from module _1, module_2, etc)…
config: {},
this.config[module_id].config_variable

and then on the send BACK, return the module identifier as part of the data, and the module checks to see if the response is for that instance…

another way, to avoid the storage, is for the module to send config every time, and the identifier, and
the node helper send back the identifier as part of the response… and module checks… same as before…

I created a module that does option 2 , never stores any module instance data in node_helper
https://github.com/sdetweil/NewBusTimes

cowboysdude

Excellent!

Newtothis

@sdetweil Thank you!

I managed to get it working by renaming the module and replacing all instances of the module name with something different.

I am having trouble getting ‘ENG_NATIONAL’, ‘ENG_LEAGUE_1’ AND ‘ENG_LEAGUE_2’ tables to appear, do you have any ideas on how to get them working?

Thank you

sdetweil

@Newtothis sorry. No idea how the module works