MMM-DumpsterDay

[BD0G]

Since the Red Can graphic was added to the github repository my MagicMirror update-notification module indicates an update is needed to the MMM-DumpsterDay module. This made me think that it would be good to add the update process to the github repository instructions.

I just did a
git fetch and then a
git pull

from within the MagicMirror/modules/MMM-DumpsterDay sub directory and that updated the module.

[Doughboy99]

Re: MMM-DumpsterDay

I am having problems getting the bins to show correctly. I have three different bin collections

Rubbish(basic) collected fortnightly on thursdays next collection due 21st November
Recycling(plastic) collected fortnightly on thursdays next collection due 14th November
Composting(landscape) collected fortnightly on Mondays next collection due 25th November

The icon for the plastic collection is displayed as expected but the landscaping icon is also showing today(14th) even though it is not due until the 25th. Any ideas what the issue is?

This is the config file I am using
{module:“MMM-DumpsterDay”,
position:“lower_third”,

		config: {
			refreshInterval: 18000000, // Default: 18000000 = 5 hours
			pulse: true, 			   // Default: true - Makes the module pulsating
		
		enableBasic: true, 				// Enable basic trashcan 
			basicStartDate: "24.10.2019", 	// The first dumpster day (Always use 2 digit dates (01 instead of 1))
			basicDateDiff_1: 14,			// Trashday reoccurance - Default: 14 (every 14 days)
			basicNotifyDayBefore: true,		//Default: true - If you want the notification to appear also the day before the dumpster day
			
		enablePlastic: true,			// Same values as basic but for Plastic
			plasticStartDate: "31.10.2019", 
			plasticDateDiff_1: 14,
			plasticNotifyDayBefore: true,	

		enableLandscape: true,			// Same values as basic but for Landscape
			landscapeStartDate: "14.10.2019",
			landscapeDateDiff_1: 14,		
			landscapeNotifyDayBefore: true,
		
		}
		},

[sdetweil]

@mrdenmark said in MMM-DumpsterDay:

apologies foe formatting above!

fixed…
the three tildes need to be on a separate line by themselves

[Doughboy99]

@Doughboy99
I think I have found the issue for me.
in MMM-DumpsterDay.js the if statement

	if (enableLandscape == true){
	landscapeTrashDayResult = this.isPlasticTrashDay();
	Log.info("landscapeTrashDayResult: "+landscapeTrashDayResult);
	var landscapeDiv = document.createElement("div");
	landscapeDiv.className = "landscapeDiv";
	wrapper.appendChild(landscapeDiv);
		if (landscapeTrashDayResult == 0){
		landscapeDiv.classList.add("non_today")
		}

line 83 should read

landscapeTrashDayResult = this.isLandscapeTrashDay();

This seems to fix my issue.

[BD0G]

@Doughboy99
Good catch. Seems logical that the statement should pertain to Landscape because of what precedes it.

I made the change to my MMM-DumpsterDay.js . You can report the issue via github and the author @DeanoNoire can add the changes.

Here is the link to report github MMM-DumpsterDay Issues

[Doughboy99]

@BD0G Thanks Ive posted an issue. Your link is to another reposirory for a similar module .
The correct link is here

[BD0G]

@Doughboy99 Corrected the link. Thanks!

[DeanoNoire]

@Doughboy99 Thanks a lot guys, I just corrected it on github.
Have a good one!

[BD0G]

Thanks @DeanoNoire . Any plans to implement the “Tomorrow is Trash Day” and “Today is Trash Day” text?

[DeanoNoire]

@BD0G wasn’t really planning to, but I guess I can add it as an option :) will see how much work is wating for me at job this week :D