MMM-DumpsterDay

Doughboy99

@Doughboy99
I think I have found the issue for me.
in MMM-DumpsterDay.js the if statement

	if (enableLandscape == true){
	landscapeTrashDayResult = this.isPlasticTrashDay();
	Log.info("landscapeTrashDayResult: "+landscapeTrashDayResult);
	var landscapeDiv = document.createElement("div");
	landscapeDiv.className = "landscapeDiv";
	wrapper.appendChild(landscapeDiv);
		if (landscapeTrashDayResult == 0){
		landscapeDiv.classList.add("non_today")
		}

line 83 should read

landscapeTrashDayResult = this.isLandscapeTrashDay();

This seems to fix my issue.

BD0G

@Doughboy99
Good catch. Seems logical that the statement should pertain to Landscape because of what precedes it.

I made the change to my MMM-DumpsterDay.js . You can report the issue via github and the author @DeanoNoire can add the changes.

Here is the link to report github MMM-DumpsterDay Issues

Doughboy99

@BD0G Thanks Ive posted an issue. Your link is to another reposirory for a similar module .
The correct link is here

BD0G

@Doughboy99 Corrected the link. Thanks!

DeanoNoire

@Doughboy99 Thanks a lot guys, I just corrected it on github.
Have a good one!

BD0G

Thanks @DeanoNoire . Any plans to implement the “Tomorrow is Trash Day” and “Today is Trash Day” text?

DeanoNoire

@BD0G wasn’t really planning to, but I guess I can add it as an option :) will see how much work is wating for me at job this week :D

Paddi

@DeanoNoire Had no luck to make it work. When adding in the config.js and restarting mirror it messes up things. Black background instead of usual picture. Some modules do not load…
Could you help ?

BD0G

@Paddi Try Pressing the CTRL-Shift-i keys together once the Magic Mirror has loaded to bring up the developers window. Then click on the tab labeled console and look for any errors. Usually in Red text. When there is a black screen it “typically” indicates one or more of the modules has crashed.

BD0G

I had this module working great , but for some strange reason it no longer shows the Landscape can. I set the dates to tommorrow which is trash day so the Trash Can and Landscape can should be displayed the day before (which it today) and only the Trash Can is displayed. My date is set correctly on the Magic Mirror so its not that.

Here is my config entry

	{
	module:"MMM-DumpsterDay",
	position:"bottom_bar",
	config: {
		refreshInterval: 18000000, // Default: 18000000 = 5 hours
		pulse: true, 			   // Default: true - Makes the module pulsating

		enableBasic: true, 				// Enable basic trashcan 
		basicStartDate: "27.11.2019", 	// The first dumpster day (Always use 2 digit dates (01 instead of 1))
		basicDateDiff_1: 7,			// Trashday reoccurance - Default: 14 (every 14 days)
		basicNotifyDayBefore: true,		//Default: true - If you want the notification to appear also the day before the dumpster day
		
		enablePlastic: false,			// Same values as basic but for Plastic
		plasticStartDate: "27.11.2019", 
		plasticDateDiff_1: 28,
		plasticNotifyDayBefore: true,	

		enableLandscape: true,			// Same values as basic but for Landscape
		landscapeStartDate: "27.11.2019",
		landscapeDateDiff_1: 14,		
		landscapeNotifyDayBefore: true,
		}		
		},

DeanoNoire

@BD0G Can you try updating the latest version of this module from github? :) there was an issue with Landscape part.

mrdenmark

has anyone managed to get this module to work correctly?i’ve tried allsorts of config options but it behaves quite strangely.
my collection day is monday,the red gets collected every monday and the blue and yellow get alternate and get collected biweekly.
the module did as it should the first week and never since then,it only shows 1 bin,some weeks it shows a bin to be collected on thursday,dissapears on friday and re-appears on sunday!

{
        module:"MMM-DumpsterDay",
        position:"upper_third",
        config: {
                refreshInterval: 18000000, // Default: 18000000 = 5 hours
                pulse: false,
                maxWidth: "75px",                          // Default: true - Makes the module pulsating

                enableBasic: true,                              // Enable basic trashcan
                basicStartDate: "11.11.2019",   // The first dumpster day (Always use 2 digit dates (01 instead of 1))
                basicDateDiff_1: 7,                     // Trashday reoccurance - Default: 14 (every 14 days)
                basicNotifyDayBefore: true,             //Default: true - If you want the notification to appear also t$
                enablePlastic: false,                   // Same values as basic but for Plastic
                plasticStartDate: "04.11.2019",
                plasticDateDiff_1: 14,
                plasticNotifyDayBefore: true,

                enableLandscape: true,                  // Same values as basic but for Landscape
                landscapeStartDate: "11.11.2019",
                landscapeDateDiff_1: 14,
                landscapeNotifyDayBefore: true,
                }
                },

DeanoNoire

Hey guys,
I finally found some time to review and practically remaster whole module. Now it’s finally working correctly and the console logging is improved and more readable.

Please let me know if you still encounter some issues.

Stay safe in these difficult times!

robertybob

@DeanoNoire The download link isn’t in the original post anymore?

DeanoNoire

@robertybob originaly there was a github card for the repository, but it seems the card is not supported anymore.
And as I’m not able to edit the original post, here is the link:
https://github.com/DeanoNoire/MMM-DumpsterDay

blackeaglece

Hello how can i reduce the space between the header and the image? as you can see from the screenshot Thank you very much

DeanoNoire

Hello @blackeaglece ,
I do not use the headers, but I presume it’s always on the top of the module wrapper.
So first thing I’d try is decreasing the height value of trashcan_wrapper.
This is done in MMM-DumpsterDay.css file in the module folder.

Please let me know if you managed moving it by these steps.

Deano

Bob

Hi, is there any way to add a option for a 4th icon ? We have 3 different types of recycling (glass, cardboard and plastic), as well as the usual rubbish/trash, and of course, they all come at different times ! :)

DeanoNoire

Hey @Bob ,
sure thing. Any tips for cardboard and glass bin image and color?
This brings me to an idea of making the colors and images parameterizable.

Deano

Bob

@DeanoNoire Our colours are blue (glass), grey (cardboard), green (plastic) and black (trash/rubbish), but I suspect if you compare local areas, they’ll all have different colour schemes. I’ve even seen places where the bins were all the same, they just had different logos on them for the relevant product.

As you say, either paramatize them, or even just reference the icons by name/type, and let people change the image behind them to their colour of choice ?