SimpleLogo auto change logo not working

sdetweil

can u post that part of your config.js for this module?

the doc says

refreshInterval	

Refresh/refetch image file between interval. Only use this if your image url return different image after some interval of time, even the fileUrl is not changed. See this case #2, awesome project by @ElYoM

Possible values: 1000, 2000, or 10000
Default value: 0 (disabled)

RoadRunnr1469

@sdetweil I left that as default in the MMM-SimpleLogo.js - it isn’t clear what needs to change in there.

RoadRunnr1469

Module.register("MMM-SimpleLogo", {
    // Default module config.
    defaults: {
        text: "",
        fileUrl: "modules/MMM-SimpleLogo/public/Amc.JPG",
        width: "200px",
	notification: "SIMPLE_LOGO_UPDATE",
        position: "top_center",
        refreshInterval: 1000
    },

    start: function() {
        if (this.config.refreshInterval > 0) {
            var self = this;
            var imgsrc = self.config.fileUrl;
            this.interval = setInterval(function() {
                img = document.querySelector(".simple-logo__container img[src*='" + imgsrc + "']");
                imgsrc = self.config.fileUrl;
                if(!imgsrc.includes("?"))
                        imgsrc += '?' + Date.now();
                else
                        imgsrc += '&' + Date.now();
                img.setAttribute('src', imgsrc);
            }, this.config.refreshInterval);
        }
    },

    getStyles: function () {
        return [
            this.file('css/mmm-simplelogo.css')
        ];
    },

    notificationReceived: function(notification, payload) {
        if (notification == "SIMPLE_LOGO_UPDATE") {
            // stop auto-refresh (if any)
            if (this.config.refreshInterval > 0) {
                clearInterval(this.interval);
            }
            // update with new parameters
            for (var attr in payload) this.config[attr] = payload[attr];
            // restart auto-refresh (if any)
            this.start();
            this.updateDom();
        }
    },

    // Override dom generator.
    getDom: function() {
        var wrapper = document.createElement("div");
        wrapper.className = 'simple-logo__container';
        wrapper.classList.add(this.config.position);
        wrapper.style.width = this.config.width;
        var text = document.createTextNode(this.config.text);
        wrapper.appendChild(text);
        var img = document.createElement("img");
        img.setAttribute('src', this.config.fileUrl);
        wrapper.appendChild(img);
        return wrapper;
    }
});

sdetweil

@RoadRunnr1469 u don’t edit the SimpleLogo.js file (in general u NEVER edit the module files unless u are making code fixes or enhancements)

you edit the config.js

default is NEVER update

in config.js

 {
   module: "MMM-SimpleLogo",
   position: ????,
   config: {
      refreshInterval:  5* 60 * 1000   // 5 minutes, times  60 seconds times 1000 milliseconds per second
      fileUrl: "???????"
   } 
}

everything in the config: { … }
overrides the moduleName.js defaults: { …} items of the same names

FlameShotBow

As @sdetweil stated you shouldn’t be editing the modules JavaScript file.

To ensure that the SimpleLogo module has not been damaged I would reinstall the module and the OnScreenMenu module if you edited the JavaScript of that too.

Once you have a fresh install of SimpleLogo and OnScreenMenu you need to edit the config file in magic mirror and not any of the module files.

I’m not sure what you mean about the “auto chance” aspect. If you want the logos to automatically change then I would suggest sending a notification to SimpleLogo using ModuleScheduler. On the other hand, if you want to manually change them. You can use the OnScreenMenu module like so:

{
    module: "MMM-OnScreenMenu",
    position: "top_centre",
    config: {
        menuItems: {
            notify1: {
                title: "AMC Logo",
                notification: "SIMPLE_LOGO_UPDATE",
                payload: {
                    fileUrl: "modules/MMM-SimpleLogo/public/Amc.JPG",
                    width: "750px"
                }
            },
            notify2: {
                title: "Show other logo",
                notification: "SIMPLE_LOGO_UPDATE",
                payload: {
                    fileUrl: "modules/MMM-SimpleLogo/public/......",
                    width: "1050px"
                }
            }
        }
    }
}

which should hopefully give you the option to change the logo manually.

Hope this helps.

RoadRunnr1469

I don’t understand why people have to be so confrontational and un helpful. Making changes the the DEFAULT portion of the main file ONLY affects the initial settings.

As far as what I mean by auto changing logo, that is what I understood by the documentation for the module.
Dynamic to me means it will change at a given amount of time…

****** Copy/Paste from MMM-SimpleLogo*****
The MMM-SimpleLogo module supports the notification event SIMPLE_LOGO_UPDATE which allows the configuration to be dynamically modified. As an example, the MMM-OnScreenMenu module might be used to dynamic adjust the fileURL parameter as follows

RoadRunnr1469

@sdetweil changing the simplelogo.js back and putting updates in config.js has not made any changes. the logo still stays on the same logo, never changes.

sdetweil

@RoadRunnr1469 ok, looking thru the code and doc

Refresh/refetch image file between interval. Only use this if your image url return different image after some interval of time, even the fileUrl is not changed.

the code adds a time to the end of the fileurl to force a unique value. You could do this if the URl to the file stayed the same, but the actual file was different (something overwrote the file since last time)

so, they planned on the something changing the actual logo file contents

        var imgsrc = self.config.fileUrl;
            this.interval = setInterval(function() {   // < --- start a recurring timer
                img = document.querySelector(".simple-logo__container img[src*='" + imgsrc + "']");
                imgsrc = self.config.fileUrl;
                if(!imgsrc.includes("?"))
                        imgsrc += '?' + Date.now();  // < ---
                else
                        imgsrc += '&' + Date.now();  // < -----
                img.setAttribute('src', imgsrc);
            }, this.config.refreshInterval);  // < ---  refresh time
        }

the code also allows some other module to send it a message to change the logo url

I don’t understand why people have to be so confrontational and un helpful.

we are not being ‘un helpful’, the design of the mirror app is to INTENTIONALLY keep people from having to change the module file for different options…

so, when we see someone going down that path, we want to get them back on the design
I can look at the module code from github, I can’t see what you did locally. (in general)
makes it harder to help, and changes made get wiped out if there is a module update…
(that tends to make people upset when their stuff is lost!)

but your and my initial understanding of what was supposed to happen (as I didn’t know anything about this module), is wrong… update the cycle time but keep the same exact image and nothing will change.
you can prove this with 2 logo files.

start with one, and then copy the other over the 1st while the module is working.

we are all volunteers here…

RoadRunnr1469

The ReadMe file shows this
cat README.md

Module: MMM-SimpleLogo

The MMM-SimpleLogo module is third party modules of the MagicMirror. This module simply displays logo.

Using the module

To use this module, add it to the modules array in the config/config.js file:

modules: [
    {
        module: 'MMM-SimpleLogo',
        position: 'top_left',    // This can be any of the regions.
        config: {
            // The config property is optional.
            // See 'Configuration options' for more information.
        }
    }
]

Configuration options

The following properties can be configured:

Option	Description
`fileUrl`	File url. Possible values: Logo link form internet or path to your local files relative to MagicMirror directory Default value: 'modules/MMM-SimpleLogo/public/logo.png'
`width`	Set width of your logo, height is auto. Possible values: `'300px'` or `'50%'` Default value: `'200px'`
`position`	Horizontal position on current container Possible values: `left`, `center`, or `right` Default value: `left`
`refreshInterval`	Refresh/refetch image file between interval. Only use this if your image url return different image after some interval of time, even the `fileUrl` is not changed. See this case #2, awesome project by @ElYoM Possible values: `1000`, `2000`, or `10000` Default value: `0` (disabled)
`text`	Text above the image. Possible values: Any text Default value: `Simple Logo`

Notification Events

The MMM-SimpleLogo module supports the notification event SIMPLE_LOGO_UPDATE which allows the configuration to be dynamically modified. As an example, the MMM-OnScreenMenu module might be used to dynamic adjust the fileURL parameter as follows:

{
    module: "MMM-OnScreenMenu",
    position: "top_left",
    config: {
        menuItems: {
            notify1: {
                title: "Show Cat",
                notification: "SIMPLE_LOGO_UPDATE",
                payload: {
                    fileUrl: "cat.jpg",
                    width: "750px"
                }
            },
            notify2: {
                title: "Show Dog",
                notification: "SIMPLE_LOGO_UPDATE",
                payload: {
                    fileUrl: "dog.jpg",
                    width: "1050px"
                }
            }
        }
    }
}

sdetweil

@RoadRunnr1469 right. Some external module sends a message.

I didn’t look at that code

RoadRunnr1469

@sdetweil
Based on the section “Notification Events” I added a section as called out.
this isn’t letting me paste it in here, says it is spam.

RoadRunnr1469

@sdetweil

I added this to the config.js file

            {
            module: "MMM-OnScreenMenu",
                    position: "bottom_right",
                    config: {
                            menuItems: {
                            notify1: {
                                    title: "Patch",
                                    notification: "SIMPLE_LOGO_UPDATE",
                                    payload: {
                                            fileUrl: "modules/MMM-SimpleLogo/public/Amc.JPG",
                                            width: "200px"
                                            }

RoadRunnr1469

@sdetweil

                                        },
                                notify2: {
                                        title: "Support",
                                        notification: "SIMPLE_LOGO_UPDATE",
                                        payload: {
                                                fileUrl: "modules/MMM-SimpleLogo/public/RedSupport.jpg",
                                                width: "150px"
                                                }
                                        },

sdetweil

@RoadRunnr1469 I won’t be able to look at this til tomorrow or Sunday.

Open the developers window ctrl-shift-i select the console tab and scroll up to see any messages sent from the on screen module

sdetweil

@RoadRunnr1469 I installed the module, and modified one of mine to send the notification, and it worked as expected.

sdetweil

@RoadRunnr1469 and you installed the “MMM-OnScreenMenu” module too, right?

RoadRunnr1469

@sdetweil yes, and the on screen option works fine changes the logo as expected.

sdetweil

@RoadRunnr1469 cool… can u mark this as resolved now?

RoadRunnr1469

no, the SimpleLogo auto changer part still is not working.

sdetweil

@RoadRunnr1469 ok, YOU have to actually update the fileUrl file with new contents.

it loads the SAME fileUrl over and over and over and over
it adds a fake timestamp to the URL to force the browser cache to see a different file
which loads a new instance into the cache…

so somehow you have to do

cp  whatever_source_path/new_logo_to_display.jpg  ~/MagcMirror/modules/MMM-SimpleLogo/public/Amc.JPG

I have tested this and it works

also I think
the content of the new logo image TYPE must match the file extension… it is expecting jpg
so cannot change to gif/png for next ones to load