MMM-GoogleDriveSlideShow

emrah_asl

I changed code like below to fix my problem @sdetweil in node_helper.js

getPhotos: async function() {

		// Check if need reload
		
		// Get cache if not already loaded and cache file exists (after a restart for example)
		if(!this.cache.created && this.cacheFileExists()){

			let needReload = !this.cache || (new Date().getTime() - this.cache.created) / 1000 > this.config.refreshDriveDelayInSeconds;

			// (re)create the cache if missing or expired
			if(needReload){
				this.log("No cache file, or expired, (re)creating it...");
				await this.createCache();
				this.cache.photos = await this.cache.photos.filter(photo=> !this.alreadySentPhotoIds.includes(photo.id));
			} else

			this.log("No memory cache, loading it from disk");
			await this.loadCache();

		} else this.createCache();

		return this.cache.photos;
	}

sdetweil

@emrah_asl you should submit that back to the author

github fork the repo (top right button)
download the fork
change the forked code,
git add/git commit/ git push
then github create pull request to author

then U have your saved copy on fork, and have contributed to improved module

emrah_asl

@sdetweil Sure. I will this tomorrow, I’m just testing the changes.

this time, client always sending request to google drive.

I am not sure that my tricks are correct way.

clegallic

Hi @chen31

The module is designed to adapt the display size of the image based on your maxWidth and maxHeight configuration (see there)

If it does not works, perhaps the display is cut by another module above on your MagicMirror ?

If not, can you share a screenshot to let me understand the problem.

Regards,

Charles

clegallic

@emrah_asl
Hi,

@sdetweil is right, feel free to create a pull request.

If you want to force cache reloading, you can also delete the .cache file in the module folder.

The default cache lifetime is 24 hours (refreshDriveDelayInSeconds configuration parameter).

Regards,

Charles

chen31

@clegallic said in MMM-GoogleDriveSlideShow:

Hi @chen31

The module is designed to adapt the display size of the image based on your maxWidth and maxHeight configuration (see there)

If it does not works, perhaps the display is cut by another module above on your MagicMirror ?

If not, can you share a screenshot to let me understand the problem.

Regards,

Charles

Hi Charles,
I went through this one more time and these are pictures that are portait.
I saw that it’s in your TO DO list.

Thank you.

emrah_asl

@clegallic I think there is an issue here,

I deleted one image 2 days ago, from google drive also I deleted content from cache file.

But I see, it 'is still showing.

When I add new ımage, it automatically detecting in 10 seconds to show this, but when I delete this it is not working same style.

Can we optimize it at least one hour to refresh caches ?

amanzimdwini

@clegallic - I am on a Rasp3A, but fully patched (npm 6.14.8, node 10.23.0, nodejs 10.23.0).
As su, I fail npm run token:generate - with a

Type Error: cannot read property '0' of undefined...

(there is more). Upon inspection MY credentials.json file starts like

{"web":{"client_id

while your example begins

{"installed":{"client_id

(the rest looks similar to your example) Any idea what I did wrong? If I just replace my “web” with “installed”, I still fail.
Thanks,
K

Wil

Hello,

I was trying to install this module but got an error at the npm run token:generate:

pi@raspberrypi:~/MagicMirror/modules/MMM-googleDriveSlideShow $ npm run token:generate

> mmm-googledriveslideshow@0.0.1 token:generate /home/pi/MagicMirror/modules/MMM-googleDriveSlideShow
> node generate-auth-token.js

/home/pi/MagicMirror/modules/MMM-googleDriveSlideShow/generate-auth-token.js:33
  const OAuth2Client = new google.auth.OAuth2(client_id, client_secret, redirect_uris[0]);
                                                                                     ^

TypeError: Cannot read property '0' of undefined
    at fs.readFile (/home/pi/MagicMirror/modules/MMM-googleDriveSlideShow/generate-auth-token.js:33:86)
    at FSReqWrap.readFileAfterClose [as oncomplete] (internal/fs/read_file_context.js:53:3)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! mmm-googledriveslideshow@0.0.1 token:generate: `node generate-auth-token.js`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the mmm-googledriveslideshow@0.0.1 token:generate script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/pi/.npm/_logs/2021-01-19T20_03_53_720Z-debug.log

and here is the associated log file:

0 info it worked if it ends with ok
1 verbose cli [ '/usr/bin/node', '/usr/bin/npm', 'run', 'token:generate' ]
2 info using npm@6.14.10
3 info using node@v10.23.1
4 verbose run-script [ 'pretoken:generate', 'token:generate', 'posttoken:generate' ]
5 info lifecycle mmm-googledriveslideshow@0.0.1~pretoken:generate: mmm-googledriveslideshow@0.0.1
6 info lifecycle mmm-googledriveslideshow@0.0.1~token:generate: mmm-googledriveslideshow@0.0.1
7 verbose lifecycle mmm-googledriveslideshow@0.0.1~token:generate: unsafe-perm in lifecycle true
8 verbose lifecycle mmm-googledriveslideshow@0.0.1~token:generate: PATH: /usr/lib/node_modules/npm/node_modules/npm-lifecycle/node-gyp-bin:/home/pi/MagicMirror/modules/MMM-googleDriveSlideShow/node_modules/.bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/local/games:/usr/games
9 verbose lifecycle mmm-googledriveslideshow@0.0.1~token:generate: CWD: /home/pi/MagicMirror/modules/MMM-googleDriveSlideShow
10 silly lifecycle mmm-googledriveslideshow@0.0.1~token:generate: Args: [ '-c', 'node generate-auth-token.js' ]
11 silly lifecycle mmm-googledriveslideshow@0.0.1~token:generate: Returned: code: 1  signal: null
12 info lifecycle mmm-googledriveslideshow@0.0.1~token:generate: Failed to exec token:generate script
13 verbose stack Error: mmm-googledriveslideshow@0.0.1 token:generate: `node generate-auth-token.js`
13 verbose stack Exit status 1
13 verbose stack     at EventEmitter.<anonymous> (/usr/lib/node_modules/npm/node_modules/npm-lifecycle/index.js:332:16)
13 verbose stack     at EventEmitter.emit (events.js:198:13)
13 verbose stack     at ChildProcess.<anonymous> (/usr/lib/node_modules/npm/node_modules/npm-lifecycle/lib/spawn.js:55:14)
13 verbose stack     at ChildProcess.emit (events.js:198:13)
13 verbose stack     at maybeClose (internal/child_process.js:982:16)
13 verbose stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:259:5)
14 verbose pkgid mmm-googledriveslideshow@0.0.1
15 verbose cwd /home/pi/MagicMirror/modules/MMM-googleDriveSlideShow
16 verbose Linux 5.4.83-v7+
17 verbose argv "/usr/bin/node" "/usr/bin/npm" "run" "token:generate"
18 verbose node v10.23.1
19 verbose npm  v6.14.10
20 error code ELIFECYCLE
21 error errno 1
22 error mmm-googledriveslideshow@0.0.1 token:generate: `node generate-auth-token.js`
22 error Exit status 1
23 error Failed at the mmm-googledriveslideshow@0.0.1 token:generate script.
23 error This is probably not a problem with npm. There is likely additional logging output above.
24 verbose exit [ 1, true ]

Anyone have an idea how to solve this?

Wil

Ok I find the problem, my credential file was not good.
I made a new one and the npm run token:generate worked.

I write the config as mentioned, and start MM but no pictures appear.
Is it long to load pictures?