MMM-PGA

swvalenti

@mumblebaj I am using your fork and it worked fine for 2.19 for couple weeks just stopped the other day.

mumblebaj

@swvalenti I will have a look in the morning. It is almost midnight where I am. :-(

mumblebaj

@swvalenti Seems like there was a major upgrade in the JSON return data. Loads of changes. Not going to be an easy task to work through them all. I do not have easy fixes for it. I will see if I have time to work through them.

swvalenti

@mumblebaj any easy way for me to figure this out, if I comment out that line it works.

[18.04.2023 11:31.09.632] [LOG]   MMM-PGA retrieving Tournament Data
[18.04.2023 11:31.09.633] [ERROR] Whoops! There was an uncaught exception...
[18.04.2023 11:31.09.633] [ERROR] TypeError: Cannot read properties of undefined (reading 'displayName')
    at Request._callback (C:\Users\CCU Forensic Machine\MagicMirror\modules\MMM-PGA\ESPN.js:49:99)
    at self.callback (C:\Users\CCU Forensic Machine\MagicMirror\modules\MMM-PGA\node_modules\request\request.js:185:22)
    at Request.emit (node:events:513:28)
[18.04.2023 11:38.48.117] [LOG]   MMM-PGA retrieving FedEx Cup Standings
[18.04.2023 11:38.48.185] [ERROR] Whoops! There was an uncaught exception...
[18.04.2023 11:38.48.185] [ERROR] TypeError: Cannot read properties of undefined (reading 'querySelectorAll')
    at Request._callback (C:\Users\CCU Forensic Machine\MagicMirror\modules\MMM-PGA\FEDEXCUP.js:33:38)

mumblebaj

@swvalenti Can you show me what you changed? Did you comment out displayName in ESPN.js or the line with querySelectorAll in FEDEXCUP.js?

swvalenti

@mumblebaj just the espn.js sir

mumblebaj

@swvalenti Does you line 49 look like the following? tournament.defendingChamp = event.defendingChampion ? event.defendingChampion.displayName :

swvalenti

@mumblebaj said in MMM-PGA:

tournament.defendingChamp = event.defendingChampion ? event.defendingChampion.displayName :

tournament.defendingChamp = event.defendingChampion ? event.defendingChampion.athlete.displayName : ""

mumblebaj

@swvalenti Thanks for the above. Seem the data has changed. Change it to the following:
tournament.defendingChamp = event.defendingChampion ? event.defendingChampion.displayName : ""

I will make a change and deploy but there is more data that changed. Need to check the others as well.

swvalenti

@mumblebaj said in MMM-PGA:

tournament.defendingChamp = event.defendingChampion ? event.defendingChampion.displayName : “”

changed it but still stuck on loading