Calendar Timezone Issues

sdetweil

@Jonsar yeh, that is a challenge… its broken in both the parser and the magic mirror code that handles the cal entries

I can get it ‘mostly’ right

the problem is that TZ= has stuff we can’t process…
“(UTC-05:00) Eastern Time (US & Canada)”

we can get the offset, and look up some timezone with the SAME offset to get back to UTC

except, the 1st entry America/Atikokan, doesn’t do Daylight savings,

and the date conversion library appears to have a bug, saying Daylight savings in the US is in effect on Oct 28, 2020, even tho its NOT til Nov 1, 2020

the rest of the text doesn’t match anything in the Windows timezone list.

so, it will be 1 hour off for a while.

sdetweil

@Jonsar I have found a solution and have submitted changes to the ics parser library
https://github.com/jens-maus/node-ical/issues/32
and will submit changes to MM to match.
https://github.com/MichMich/MagicMirror/issues/2171

if U are interested I could send u the test files, chat message me if u are interested.

Jonsar

@sdetweil Not sure what changed but the times are now displaying as starting 5 hours before they are supposed to.

sdetweil

@Jonsar do another git pull. Latest update accepted on friday

Jonsar

@sdetweil I’m still on the branch origin/develop and it says I’m up to date.

sdetweil

@Jonsar hm… show me a vevent entry please.

Jonsar

@sdetweil

As you can see, this event is scheduled to begin at 10:00am but is actually displaying on the calendar as starting at 5:00am.

BEGIN:VEVENT
UID:00D4F0F7-BF5A-45C4-B92F-41B8C771E111
SUMMARY:TEST
DTSTART;TZID="(UTC-05:00) Eastern Time (US & Canada)":20201123T100000
DTEND;TZID="(UTC-05:00) Eastern Time (US & Canada)":20201123T103000
CLASS:PUBLIC
PRIORITY:5
DTSTAMP:20201122T204236Z
TRANSP:OPAQUE
STATUS:CONFIRMED
SEQUENCE:0
X-MICROSOFT-CDO-APPT-SEQUENCE:0
X-MICROSOFT-CDO-BUSYSTATUS:BUSY
X-MICROSOFT-CDO-INTENDEDSTATUS:BUSY
X-MICROSOFT-CDO-ALLDAYEVENT:FALSE
X-MICROSOFT-CDO-IMPORTANCE:1
X-MICROSOFT-CDO-INSTTYPE:0
X-MICROSOFT-DONOTFORWARDMEETING:FALSE
X-MICROSOFT-DISALLOW-COUNTER:FALSE
END:VEVENT

sdetweil

@Jonsar I don’t see that

only your vevent in ics file, tz set to us eastern

Sunday, November 22, 2020
10:50:31pm
NEXT EVENT
TEST Tomorrow at 10:00 AM

if u set debug in config.js this is what I see

	logLevel: ["INFO", "LOG", "WARN", "ERROR","DEBUG"],

this is what I see

 start=Mon Nov 23 2020 10:00:00 GMT-0500 (Eastern Standard Time) end=Mon Nov 23 2020 10:30:00 GMT-0500 (Eastern Standard Time)
initial tz=(UTC-05:00) Eastern Time (US & Canada)
corrected TZ=America/New_York
corrected tz=America/New_York
start date/time=Mon Nov 23 2020 10:00:00 GMT-0500 (Eastern Standard Time)
start offset=-300
start date/time w tz =Mon Nov 23 2020 10:00:00 GMT-0500 (Eastern Standard Time)
event date=Mon Nov 23 2020 10:00:00 GMT-0500 (Eastern Standard Time)
event offset=-300 hour=10 event date=Mon Nov 23 2020 10:00:00 GMT-0500 (Eastern Standard Time)
adjustHours=0

Jonsar

@sdetweil You’re right. Was totally on my end. Didn’t realize I had a file that was preventing the upgrade. After upgrading, works like a charm. Thanks for your help as always.

sdetweil

@Jonsar cool, glad u found it, and it works as you expected!
Thanks for the fast feedback