MagicMirror Forum
    • Recent
    • Tags
    • Unsolved
    • Solved
    • MagicMirror² Repository
    • Documentation
    • 3rd-Party-Modules
    • Donate
    • Discord
    • Register
    • Login
    A New Chapter for MagicMirror: The Community Takes the Lead
    Read the statement by Michael Teeuw here.

    "absolute" does not mean absolute in default calendar module

    Scheduled Pinned Locked Moved Troubleshooting
    20 Posts 4 Posters 2.5k Views 4 Watching
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • AlvingerA Offline
      Alvinger
      last edited by

      Hi,
      As I am affected by the time offset bug in master I have tried the latest development version of MagicMirror.

      There is a bug in the display logic in calendar.js. I want to display the date/time in absolute format, i.e. never change to relative. I have getRelative=0 and urgency=0 in my config. Even so, the display is wrong.

      For Full Day Events it always shows “today”, “tomorrow” or “dayaftertomorrow” even if timeFormat=absolute. There seems to be a condition missing in calendar.js that takes timeFormat into account for full day events.

      For normal events the display changes to “Ends in xx minutes” for ongoing events. Looking at the code it looks like the condition on line 328 always is true regardless of timeFormat.

      How should I configure the module to ALWAYS use absolute as the format, i.e. under no circumstances change to relative?

      S 2 Replies Last reply Reply Quote 0
      • S Away
        sdetweil @Alvinger
        last edited by

        @Alvinger you can change the timeFormat

        Sam

        How to add modules

        learning how to use browser developers window for css changes

        1 Reply Last reply Reply Quote 0
        • S Away
          sdetweil @Alvinger
          last edited by

          @Alvinger also, as I am the one trying to fix calendar, I am interested in the offset problem.

          new fixes were released on Monday, do if u got the develop branch before then, do another git pull to update it.
          note: u need another

          npm install 
          

          to update the node-ical library

          if this doesn’t resolve your problem. I would love to see an event from your ics file. it is just text so I can copy/paste an entry here,

          begin vevent
          to
          end vevent

          Sam

          How to add modules

          learning how to use browser developers window for css changes

          AlvingerA 1 Reply Last reply Reply Quote 0
          • AlvingerA Offline
            Alvinger @sdetweil
            last edited by

            @sdetweil the latest development version solved the offset problem for me. As far as the “absolute” problem I rewrote the relevant section of calendar.js. As I have already forked MagicMirror to make it run on my IOS 9.3.5 Ipads I can’t submit a PR (at least I don’t know exactly how to do that) but would be happy to send you the calendar.js file.

            There is still a problem with full day recurring events.

            I can PM you a link to a relevant public (but inofficial) calendar with the issues.

            S 1 Reply Last reply Reply Quote 0
            • S Away
              sdetweil @Alvinger
              last edited by sdetweil

              @Alvinger ok. the latest fixes, Monday did address full day recurring

              I would be happy to see the cal

              Sam

              How to add modules

              learning how to use browser developers window for css changes

              1 Reply Last reply Reply Quote 0
              • BKeyportB Offline
                BKeyport Module Developer
                last edited by BKeyport

                Absolute isn’t absolute, without other tags…

                getRelative and urgency also need to be set.

                // Force Absolute to Absolute all the time, michmich *really* hates solid dates, apparently. 
                timeformat: "absolute",
                getRelative: 0,
                urgency: 0 ,
                

                The "E" in "Javascript" stands for "Easy"

                AlvingerA 1 Reply Last reply Reply Quote 0
                • ? Offline
                  A Former User
                  last edited by

                  This post is deleted!
                  AlvingerA 2 Replies Last reply Reply Quote 0
                  • AlvingerA Offline
                    Alvinger @Guest
                    last edited by Alvinger

                    @hango correct, that’s all I did. But I changed it in all MM files. If I just knew exactly which files are executed in the browser I could have changed just those. As the iPads require a server (which can handle the latest ES) one only needs to change the browser-executed files.

                    1 Reply Last reply Reply Quote 0
                    • AlvingerA Offline
                      Alvinger @BKeyport
                      last edited by Alvinger

                      @BKeyport well almost! I have this exact config but running events are still changed to “ends in xx min”! And all day events still shows as “today”

                      I’ve done a rewrite of the relevant section of calendar.js but can’t use my github clone repo to make a PR.

                      S BKeyportB 2 Replies Last reply Reply Quote 0
                      • S Away
                        sdetweil @Alvinger
                        last edited by

                        @Alvinger u needed to.make a fork, and then clone that. fork button is upper right

                        Sam

                        How to add modules

                        learning how to use browser developers window for css changes

                        AlvingerA 1 Reply Last reply Reply Quote 0
                        • 1
                        • 2
                        • 1 / 2
                        • First post
                          Last post
                        Enjoying MagicMirror? Please consider a donation!
                        MagicMirror created by Michael Teeuw.
                        Forum managed by Sam, technical setup by Karsten.
                        This forum is using NodeBB as its core | Contributors
                        Contact | Privacy Policy