MMM-OpenWeatherMapForecast Doesn't display imperial units

JohnGalt

My instance of this module also displays rainfall in “mm”, even though I have set units = “imperial” for the MagicMirror system as a whole and also in the module configuration.

I see that the Open Weather site has a page specifying “API response parameters with available units of measurement” (https://openweathermap.org/weather-data). There one finds a parameter table specifying Parameter and Description - as well as columns for “Standard”, “Metric” and “Imperial”.

The interesting thing is this: the table specifies temperatures correctly (“Kelvin”, “Celsius”, “Fahrenheit”) but for rain it calls out “mm”, “mm”, “mm” - or other variants for different fields, e.g.: “mm/hr” and “mm/hour”.

As such, I am inclined to just give up and accept the module’s behavior as a quirk of how Open Weather parses what it is getting from the NWS - but I thought i would see if anyone has a better idea.

kayakbabe

@JohnGalt have you tried MMM-OpenWeatherForecast instead? It seems to work better for me adn it uses the OpenWeather Map api too.

JohnGalt

@kayakbabe - Thanks for the tip. Can you tell me which one you use? A quick web search shows several modules with the same name. These two look like top contenders:

https://github.com/jclarke0000/MMM-OpenWeatherForecast
https://github.com/themaxgoldman/MMM-OpenWeatherForecast

JohnGalt

@kayakbabe PS: another issue with MMM-OpenWeatherMapForecast is that it doesn’t respect the “disabled: true” configuration. I had seen this before and ignored it since the module is active, but when I went in to disable it in preparation for trying one of the others, I am reminded that I cannot just disable it. I CAN put " /* and */ " around the whole thing of course, but that is just clunky, and more importantly may signal more serious coding issues.

JohnGalt

@kayakbabe FWIW, i installed the jclarke0000 module, and so far it looks pretty good - thanks again!

sdetweil

@JohnGalt disabled is an mm config option, not a module option. it goes not to the module line, outside the module config:{} section

here is the doc on all the mm config options for a module.

these are separate from the module config options inside the config:{} section

https://docs.magicmirror.builders/modules/configuration.html#example

JohnGalt

@sdetweil - Thanks Sam - I guess I was and am confused.

Below are two code snips showing the subject module and one other. Both are designated to be disabled with the “disabled: true” instruction outside the config section. The top one still operates, while the bottom one [and every other module I have edited this way] is disabled. So, it’s not a big deal and I will keep an eye out for how I do things. Thanks again.

{module: "MMM-OpenWeatherMapForecast", // https://github.com/MarcLandis/MMM-OpenWeatherMapForecast NOTE: See also https://github.com/sdetweil/MMM-OpenWeatherMapForecast
  disabled: true,
  header: "", // "Weather"
  position: "top_right",
  classes: "default everyone",
  disabled: false,
  config: {
    apikey: "xxxxxxxxxxxxx",
------------------------------------------------------------------------------- 
{module: "MMM-Temperature", // https://github.com/Tom-Hirschberger/MMM-Temperature
  disabled: true,
  header: "Office Temp + Humidity",
  position: "top_right", // bottom_right
  config: {
   sensors: [

sdetweil

@JohnGalt I need to see the rest in between

top one has disabled twice, true and false

JohnGalt

@sdetweil - Ah crap, having both disabled: true AND disabled: false would do it!! :) I’m sure the system would execute the last command. Thanks for putting a second set of eyes on it.

sdetweil

@JohnGalt yes, last occurrence wins