SOLVED MMM-compliment showing evening compliment anytime

selyjohns

Hi,

I’ve a problem with MMM-compliment that showing evening compliment at anytime…

The config is correct.
I’ve adding hour configuration to be sure with morningStartTime, morningEndTime, afternoonStartTime and afternoonEndTime but problem persist…my MM say good night on morning…

The date/time of my rpi3 is correct…any idea ?

Thank you

sdetweil

@selyjohns did u look at any issues in the module github , issues tab?

selyjohns

@sdetweil No, nothing…

                {
                        module: 'compliments',
                        position: 'lower_third',
                        config: {
                                morningStartTime:3,
                                morningEndTime:10,
                                afternoonStartTime:13,
                                afternoonEndTime:18,
                                remoteFile: 'compliments.json'
                                }
                },

compliments.json is stored in MagicMirror/modules/default/compliments/ This part is good.

sdetweil

@selyjohns ok, one thing

MMM-compliment means some external additional module

module: ‘compliments’,

means the one shipped with MagicMirror…

selyjohns

@sdetweil said in MMM-compliment showing evening compliment anytime:

@selyjohns ok, one thing
MMM-compliment means some external additional module
module: ‘compliments’,
means the one shipped with MagicMirror…

Oh OK, not evident.
I speak about the module ‘compliments’, integrated with MM in default folder

sdetweil

@selyjohns well, you have a gap

                                morningEndTime:10,
                                afternoonStartTime:13,

can’t have a gap

else it the same as ANY OTHER time but morning or afternoon…

so 10:01->>> 12:59 OR 18:01 ->>>> 02:59

note the defaults are

		morningStartTime: 3,
		morningEndTime: 12,
		afternoonStartTime: 12,
		afternoonEndTime: 17,

morning 3-12, afternoon 12-17, rest 17-3

selyjohns

@sdetweil Ok, but i’ve added this configuration because i had the problem with default configuration.
I can delete it. Normally we don’t need this, right ?

sdetweil

@selyjohns if u don’t need a different time set, then you would use the default…

all I was saying is that you have a gap in the time, and the code design demands no gap.

the code has
morning
afternoon
everything else

selyjohns

@sdetweil Ok thank you.
Trying with no specific configuration -> MM say “goodnight” or “good evening” but it’s only 4 PM
Trying with specifig configuration with no gap, same result

                {
                        module: 'compliments',
                        position: 'lower_third',
                        config: {
                                morningStartTime:3,
                                morningEndTime:12,
                                afternoonStartTime:12,
                                afternoonEndTime:18,
                                remoteFile: 'compliments.json'
                                }
                },

sdetweil

@selyjohns what does the remotefile look like?

I just want the things to the left of :

default is this

		compliments: {
			anytime: ["Hey there sexy!"],
			morning: ["Good morning, handsome!", "Enjoy your day!", "How was your sleep?"],
			afternoon: ["Hello, beauty!", "You look sexy!", "Looking good today!"],
			evening: ["Wow, you look hot!", "You look nice!", "Hi, sexy!"],
			"....-01-01": ["Happy new year!"]
		},