MMM-compliment showing evening compliment anytime

[selyjohns]

@sdetweil said in MMM-compliment showing evening compliment anytime:

@selyjohns ok, one thing
MMM-compliment means some external additional module
module: ‘compliments’,
means the one shipped with MagicMirror…

Oh OK, not evident.
I speak about the module ‘compliments’, integrated with MM in default folder :)

[sdetweil]

@selyjohns well, you have a gap

                                morningEndTime:10,
                                afternoonStartTime:13,

can’t have a gap

else it the same as ANY OTHER time but morning or afternoon…

so 10:01->>> 12:59 OR 18:01 ->>>> 02:59

note the defaults are

		morningStartTime: 3,
		morningEndTime: 12,
		afternoonStartTime: 12,
		afternoonEndTime: 17,

morning 3-12, afternoon 12-17, rest 17-3

[selyjohns]

@sdetweil Ok, but i’ve added this configuration because i had the problem with default configuration.
I can delete it. Normally we don’t need this, right ?

[sdetweil]

@selyjohns if u don’t need a different time set, then you would use the default…

all I was saying is that you have a gap in the time, and the code design demands no gap.

the code has
morning
afternoon
everything else

[selyjohns]

@sdetweil Ok thank you.
Trying with no specific configuration -> MM say “goodnight” or “good evening” but it’s only 4 PM
Trying with specifig configuration with no gap, same result :(

                {
                        module: 'compliments',
                        position: 'lower_third',
                        config: {
                                morningStartTime:3,
                                morningEndTime:12,
                                afternoonStartTime:12,
                                afternoonEndTime:18,
                                remoteFile: 'compliments.json'
                                }
                },

[sdetweil]

@selyjohns what does the remotefile look like?

I just want the things to the left of :

default is this

		compliments: {
			anytime: ["Hey there sexy!"],
			morning: ["Good morning, handsome!", "Enjoy your day!", "How was your sleep?"],
			afternoon: ["Hello, beauty!", "You look sexy!", "Looking good today!"],
			evening: ["Wow, you look hot!", "You look nice!", "Hi, sexy!"],
			"....-01-01": ["Happy new year!"]
		},

[selyjohns]

@sdetweil
Here’s :)

 {
	"anytime": [
			"Comment ça va ?",
			"Bonjour"
			   ],
	"morning": [
			"Un petit café ?",
			"Bien dormi ?",
			"Bonne journée !"
			],
	"evening": [
			"Bonne soirée !",
			"Bonne nuit...",
			"Agréable soirée"
			],
	"day_sunny": [
			"Le temps est ensoleillé aujourd'hui !",
			"C'est une belle journée"
			],
	"day_cloudy": [
			"C'est nuageux aujourd'hui..."
			],
	"snow": [
			"Bataille de boules de neige !!!"
			],
	"rain": [
			"N'oublie pas ton parapluie...",
			"Et si on restait au sec aujourd'hui ?"
			]
}

With " as indicated on the readme when using remote file.
But, i had the problem before using remote file, i’ve do this hoping this would resolve the problem, but it’s dont.

Is it possible to “remove/reinstall” default module like compliments ?

[sdetweil]

@selyjohns said in MMM-compliment showing evening compliment anytime:

Is it possible to “remove/reinstall” default module like compliments ?

no, but u can get the original code back (which you shouldn’t have changed)

do

cd ~/MagicMirror

check for changed files

git status

if the compliments module has anything is listed as modified

git checkout modules/default/compliments/compliments.js   (or whatever filename 

[sdetweil]

@sdetweil ok, looking at the code again, duh

it takes the time period AND the anytime, mashes them together and then randomly picks one of the list

so, if u don’t want ‘anytime’ , then remove it… or understand it will happen ‘anytime’

[selyjohns]

@sdetweil Thank you for your time :)
The problem doesn’t concern “anytime” values, but “evening”.
Anytime is anytime and it’s normal that compliment in this section can be displayed at anytime…:)

Compliments define in “evening” are displayed all the day, not only on the evening. This is my problem. The MM showing evening compliment at anytime…

With my exemple, the MM display “Bonne soirée” or “Bonne nuit…”, also the morning, or afternon. Like this compliment was positionned in “anytime”