After update MMM-Buttons breaks, made things worse trying to fix it

sdetweil

@Lusbueb said in After update MMM-Buttons breaks, made things worse trying to fix it:

Please change your Installation -Instruktion in your GIT

no… mine is a fork of the master… you should know to substitute my URL for the one in the doc (if any)

if I were to change the link AND submit it to the author, AND they took it, then their doc would point to MY repo incorrectly…

this is how the fork process works…

SO, if you git clone my url and do the npm install, does it fail?

Lusbueb

@sdetweil said in After update MMM-Buttons breaks, made things worse trying to fix it:

@Lusbueb said in After update MMM-Buttons breaks, made things worse trying to fix it:

Please change your Installation -Instruktion in your GIT

no… mine is a fork of the master… you should know to substitute my URL for the one in the doc (if any)

if I were to change the link AND submit it to the author, AND they took it, then their doc would point to MY repo incorrectly…

this is how the fork process works…

SO, if you git clone my url and do the npm install, does it fail?

yes you did it :-)

your fork works, you are my hero! :-)

but why can’t you adapt the readme file in a FORK?

pi@MM:~/MagicMirror/modules $ git clone https://github.com/sdetweil/MMM-Buttons
Klone nach 'MMM-Buttons' ...
remote: Enumerating objects: 56, done.
remote: Counting objects: 100% (4/4), done.
remote: Compressing objects: 100% (4/4), done.
remote: Total 56 (delta 0), reused 2 (delta 0), pack-reused 52
Empfange Objekte: 100% (56/56), 11.86 KiB | 146.00 KiB/s, fertig.
Löse Unterschiede auf: 100% (25/25), fertig.
pi@MM:~/MagicMirror/modules $ cd MMM-Buttons
pi@MM:~/MagicMirror/modules/MMM-Buttons $ npm install

> Magic-Mirror-Module-Buttons@1.0.0 postinstall
> ./postinstall

✔ Rebuild Complete

added 6 packages, and audited 7 packages in 32s

found 0 vulnerabilities

sdetweil

@Lusbueb cause it’s temporary… maybe.

things you just learn to deal w

Lusbueb

@sdetweil said in After update MMM-Buttons breaks, made things worse trying to fix it:

@Lusbueb or, you can get my fork of MMM-Buttons which fixes the install problem

https://github.com/sdetweil/MMM-Buttons

hello sam
Can you please adjust the command in your repo (https://github.com/sdetweil/MMM-Buttons) under Installation:

from (false): git clone https://github.com/Jopyth/MMM-Buttons.git

to (right): git clone https://github.com/sdetweil/MMM-Buttons

I’m so glad that I copied the link to this forum back then, but it took a long time before I realized that I was always installing the faulty git (Jopyth) instead of your git, just because I followed your installation instructions.

Happy New Year and thank you for your work :-)

Kind regards
Peter

sdetweil

@Lusbueb done… I never copy/paste that instruction… I push the green button to copy the code in this current repo (regardless of the name)

KristjanESPERANTO

@Lusbueb Just a side note: On the module list is the fork from MarcLandis (https://github.com/MarcLandis/MMM-Buttons), he is actively maintaining the module.

Lusbueb

@KristjanESPERANTO Thank you for the tip, but the notification does not work for the MMM-Carousel module and with the fork from sdetweil everything works as it should for me.