Default Clock wrong after update

[sdetweil]

@drstang another user had a similar problem with the calendar…
rebuilt with a different pi and the problem went away…

lets try this

pm2 stop all  (or stop MM if you didn't use pm2) 
cd ~
rm -rf .config/Electron
pm2 start all

[drstang]

@sdetweil Thanks for the reply. Unfortunately - no luck. Still displaying UTC instead of EST.

[sdetweil]

@drstang thx… and you are certain the SYSTEM timezone is set to EST

i can’t upload a pic of the config page on the pi… weird

[drstang]

@sdetweil Yep - did it several times to make sure!

And the Mirror will show EST when I access it via a web browser!

[BKeyport]

@drstang does setting the timezone config option adjust it ?

https://docs.magicmirror.builders/modules/clock.html#configuration-options

[drstang]

@BKeyport thanks but unfortunately that does not work either - it results in the clock module not even loading (unless there was something else I should have adjusted)…

EDIT: I realized I changed the modules config initially, which didn’t work. But I changed the main config (duh - reading is key) and added the config/timezone line, which worked!! thank you!

[BKeyport]

@drstang At least you can override it for now…

[Richard238]

Just updated my MM, clock is showing 18:13 when it’s 11:54…

[sdetweil]

@drstang I don’t understand this, the code does

		if (this.config.timezone) {
			now.tz(this.config.timezone);		

which means it only uses its own config values, not the global config.

when I set it like this

		{
			module: "clock",
			position: "top_left",
			config:{
				displaySeconds:false,
				timezone:"UTC"
			}
		},

it correctly changed the displayed time from 08 (us central time) to 13

if I set it like this

	timeFormat: 24,
	units: "metric",
	timezone:"UTC",
	modules: [

it did not change the displayed time (as expected)

[BKeyport]

@sdetweil Correction to your statement. timezone is set to null by default. timezone: null, - therefore, that if line would evaluate to false unless you override with timezone config item.

[sdetweil]

@BKeyport correct,

so a ‘forced’ timezone would not be set

this is the same code as before.

[BKeyport]

@sdetweil

@sdetweil said in Default Clock wrong after update:

which means it only uses its own config values, not the global config.

This is what I was correcting. ;)

[sdetweil]

@BKeyport but he said,

changing it in the module config did NOT work
but
changing it in the GENERAL config DID work…

and it was NOT set in the original config he was using prior to the upgrade

[sdetweil]

@BKeyport said in Default Clock wrong after update:

This is what I was correcting.

I don’t understand…

what I said was

this module only adjusts the timezone when

    config :{ 
        timezone: '??????',
    }

in its module definition

NOT when its set in the global configuration, (before modules defined)

timeFormat: 24,
	units: "metric",
	timezone:"UTC",  <---  added this for testing, value NOT set in module config 
	modules: [

so I don’t see what you are ‘correcting’

[drstang]

@sdetweil thats correct - when I changed timezone from ‘null’ to ‘America/New_York,’ the module did not work at all. When I went into the MM config.js and added the timezone line, it worked.

Which now I realize is also a bit frustrating because one of my modules also shows sunrise/sunset times, and thats still off (EST + 4 hrs).

[drstang]

@sdetweil and also, yes. prior to the upgrade, my general config was NOT set to a TZ prior to the upgrade. I

[sdetweil]

@drstang said in Default Clock wrong after update:

my general config was NOT set to a TZ prior to the upgrade.

correct… as there is no general timezone property

[drstang]

@sdetweil and what also confuses me is if I access the mirror via a web browser, the times are right!

[sdetweil]

@drstang I understand and agree with that…

the clock code runs in the browser… so one can only assume that the
moment code running in the browser is different between instances…

[BKeyport]

@sdetweil Curious - are we still using Moment.js in default clock? I’ve heard issues relating with Moment and newer code - I think it might be failing to the point of no return.