Failed Update

sdetweil

@DarkV bug in the script please run again

note it’s a two step process

test, make no changes
actually do changes

sdetweil

@DarkV said in Failed Update:

bash: line 117: [: !=: unary operator expected

I have fixed this in the upgrade-script.sh
(and another similar)

DarkV

@sdetweil Wil try again, I tried it a week ago and it failed to start after the update with a failed to update .json. I had to restore from a previous image. I will try again.
I will report back

sdetweil

@DarkV ok, thx… let me see the

~/MagicMirror/installers/upgrade.log

when u finish

DarkV

@sdetweil

Here is the log and a failed update again

pgrade started - Sun Oct  2 10:41:43 BST 2022
system is Linux MAGIC-MIRROR 5.15.61-v7l+ #1579 SMP Fri Aug 26 11:13:03 BST 2022 armv7l GNU/Linux
the os is Distributor ID: Raspbian Description: Raspbian GNU/Linux 11 (bullseye) Release: 11 Codename: bullseye
doing test run = true, NO updates will be applied!
[96mCheck current Node installation ...[0m
[0mNode currently installed. Checking version number.
[0mMinimum Node version: [1mv16.9.1[0m
[0mInstalled Node version: [1mv16.17.1[0m
[92mNo Node.js upgrade necessary.[0m
[96mCheck current NPM installation ...[0m
[0mNPM currently installed. Checking version number.
[0mMinimum npm version: [1mV7.11.2[0m
[0mInstalled npm version: [1mV8.15.0[0m
[92mNo npm upgrade necessary.[0m

saving custom.css
remote name = origin
upgrading from version 2.20.0 to 2.21.0
fetching latest revisions
git fetch rc=0
current branch = master
On branch master
Your branch is behind 'origin/master' by 4694 commits, and can be fast-forwarded.
  (use "git pull" to update your local branch)

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
	modified:   installers/mm.sh
	modified:   package-lock.json

Untracked files:
  (use "git add <file>..." to include in what will be committed)
	0
	core
	css/save_custom.css
	installers/mm_temp.sh
	installers/pm2_MagicMirror.json
	installers/pm2_MagicMirror_new.json
	run-start.sh

no changes added to commit (use "git add" and/or "git commit -a")
there are 2 local files that are different than the master repo

   installers/mm.sh
   package-lock.json

save/restore files selection = y
erasing lock files
Saved working directory and index state WIP on master: 30d5bfe5 Merge pull request #2873 from MichMich/develop
test merge result rc='' , if empty, no conflicts
skipping merge, only test run
Checking for modules with removed libraries
downloading dumpactivemodules script

processing dependency changes for active modules with package.json files
processing for module MMM-Tools please wait
----------------------------------
skipped processing for MMM-Tools, doing test run
processing complete for module MMM-Tools
restoring custom.css
removing git alias
test run, restoring files stashed
Removing vendor/package-lock.json
Removing package-lock.json
Removing fonts/package-lock.json
On branch master
Your branch is behind 'origin/master' by 4694 commits, and can be fast-forwarded.
  (use "git pull" to update your local branch)

Changes not staged for commit:
  (use "git add/rm <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
	deleted:    fonts/package-lock.json
	modified:   installers/mm.sh
	deleted:    package-lock.json
	deleted:    vendor/package-lock.json

Untracked files:
  (use "git add <file>..." to include in what will be committed)
	0
	core
	installers/mm_temp.sh
	installers/pm2_MagicMirror.json
	installers/pm2_MagicMirror_new.json
	run-start.sh

no changes added to commit (use "git add" and/or "git commit -a")
Dropped refs/stash@{0} (0640a953f8283b8d55b598386c17d310f8a75680)
Upgrade ended - Sun Oct  2 10:41:58 BST 2022

Upgrade started - Sun Oct  2 10:42:15 BST 2022
system is Linux MAGIC-MIRROR 5.15.61-v7l+ #1579 SMP Fri Aug 26 11:13:03 BST 2022 armv7l GNU/Linux
the os is Distributor ID: Raspbian Description: Raspbian GNU/Linux 11 (bullseye) Release: 11 Codename: bullseye
user requested to apply changes
doing test run = false
[96mCheck current Node installation ...[0m
[0mNode currently installed. Checking version number.
[0mMinimum Node version: [1mv16.9.1[0m
[0mInstalled Node version: [1mv16.17.1[0m
[92mNo Node.js upgrade necessary.[0m
[96mCheck current NPM installation ...[0m
[0mNPM currently installed. Checking version number.
[0mMinimum npm version: [1mV7.11.2[0m
[0mInstalled npm version: [1mV8.15.0[0m
[92mNo npm upgrade necessary.[0m

saving custom.css
remote name = origin
upgrading from version 2.20.0 to 2.21.0
fetching latest revisions
git fetch rc=0
current branch = master
On branch master
Your branch is behind 'origin/master' by 4694 commits, and can be fast-forwarded.
  (use "git pull" to update your local branch)

Changes not staged for commit:
  (use "git add/rm <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
	deleted:    fonts/package-lock.json
	modified:   installers/mm.sh
	deleted:    package-lock.json
	deleted:    vendor/package-lock.json

Untracked files:
  (use "git add <file>..." to include in what will be committed)
	0
	core
	css/save_custom.css
	installers/mm_temp.sh
	installers/pm2_MagicMirror.json
	installers/pm2_MagicMirror_new.json
	run-start.sh

no changes added to commit (use "git add" and/or "git commit -a")
there are 1 local files that are different than the master repo

   installers/mm.sh

save/restore files selection = y
erasing lock files
Saved working directory and index state WIP on master: 30d5bfe5 Merge pull request #2873 from MichMich/develop
test merge result rc='' , if empty, no conflicts
executing merge, apply specified
merge result rc= 0
 Updating 30d5bfe5..9e029304 Fast-forward  .github/ISSUE_TEMPLATE.md                          
    4 +-  .github/workflows/automated-tests.yaml             
    4 +-  .github/workflows/codecov-test-suites.yaml         
    2 +-  CHANGELOG.md                                       
  100 +-  LICENSE.md                                         
    2 +-  css/main.css                                       
   18 +-  fonts/package-lock.json                            
   28 +-  fonts/package.json                                 
    4 +-  js/node_helper.js                                  
   17 +-  modules/default/calendar/README.md                 
    0  modules/default/calendar/calendar.js               
   21 +-  modules/default/calendar/calendarutils.js          
   37 +-  modules/default/calendar/node_helper.js            
    8 +  modules/default/currentweather/currentweather.js   
   33 -  modules/default/defaultmodules.js                  
    2 +-  modules/default/newsfeed/newsfeedfetcher.js        
   13 +  modules/default/weather/README.md                  
    2 +-  modules/default/weather/current.njk                
    0  modules/default/weather/providers/README.md        
    0  modules/default/weather/providers/darksky.js       
    0  .../default/weather/providers/openweathermap.js    
    0  modules/default/weather/providers/smhi.js          
   61 +-  modules/default/weather/providers/ukmetoffice.js   
    0  modules/default/weather/providers/weatherbit.js    
   26 +-  modules/default/weather/providers/weathergov.js    
    0  modules/default/weather/weatherobject.js           
    0  modules/default/weatherforecast/weatherforecast.js 
   33 -  package-lock.json                                  
 3885 +++++++++++---------  package.json                                       
   38 +-  tests/configs/data/calendar_test_recurring.ics     
    2 +-  tests/e2e/env_spec.js                              
   17 +-  tests/e2e/global-setup.js                          
   57 +-  tests/e2e/modules/alert_spec.js                    
    9 +-  tests/e2e/modules/calendar_spec.js                 
  111 +-  tests/e2e/modules/clock_es_spec.js                 
   47 +-  tests/e2e/modules/clock_spec.js                    
   77 +-  tests/e2e/modules/compliments_spec.js              
   60 +-  tests/e2e/modules/helloworld_spec.js               
   18 +-  tests/e2e/modules/newsfeed_spec.js                 
   48 +-  tests/e2e/modules/weather_spec.js                  
  225 +-  tests/e2e/modules_display_spec.js                  
   10 +-  tests/e2e/modules_position_spec.js                 
    9 +-  tests/e2e/translations_spec.js                     
    6 +-  tests/e2e/without_modules.js                       
   12 +-  .../__snapshots__/updatenotification_spec.js.snap  
    6 +-  translations/en.json                               
    1 -  vendor/package-lock.json                           
   42 +-  vendor/package.json                                
    6 +-  vendor/vendor.js                                   
    0  49 files changed, 2858 insertions(+), 2243 deletions(-)  
mode change 100755 => 100644 modules/default/calendar/README.md  
mode change 100755 => 100644 modules/default/calendar/calendar.js  delete mode 100644 modules/default/currentweather/currentweather.js  
mode change 100755 => 100644 modules/default/weather/README.md  
mode change 100755 => 100644 modules/default/weather/current.njk  
mode change 100755 => 100644 modules/default/weather/providers/README.md  
mode change 100755 => 100644 modules/default/weather/providers/darksky.js  
mode change 100755 => 100644 modules/default/weather/providers/openweathermap.js  
mode change 100755 => 100644 modules/default/weather/providers/ukmetoffice.js  
mode change 100755 => 100644 modules/default/weather/providers/weathergov.js  
mode change 100755 => 100644 modules/default/weather/weatherobject.js  delete mode 100644 modules/default/weatherforecast/weatherforecast.js  
mode change 100755 => 100644 vendor/package.json  
mode change 100755 => 100644 vendor/vendor.js
processor architecture is armv7l
updating MagicMirror runtime, please wait
npm WARN invalid config omit="dev --no-audit --no-fund --no-update-notifier" set in command line options
npm WARN invalid config Must be one or more of: dev, optional, peer

> magicmirror@2.21.0 postinstall
> npm run install-vendor && npm run install-fonts && echo "MagicMirror² installation finished successfully! 
> "


> magicmirror@2.21.0 install-vendor
> echo "Installing vendor files ...
> " && cd vendor && npm install --loglevel=error --no-audit --no-fund --no-update-notifier

Installing vendor files ...


changed 3 packages in 9s

> magicmirror@2.21.0 install-fonts
> echo "Installing fonts ...
> " && cd fonts && npm install --loglevel=error --no-audit --no-fund --no-update-notifier

Installing fonts ...


changed 2 packages in 4s
MagicMirror² installation finished successfully! 


> magicmirror@2.21.0 prepare
> [ -f node_modules/.bin/husky ] && husky install || echo no husky installed.

husky - Git hooks installed

added 455 packages, removed 3 packages, changed 13 packages, and audited 754 packages in 3m

91 packages are looking for funding
  run `npm fund` for details

3 moderate severity vulnerabilities

To address all issues (including breaking changes), run:
  npm audit fix --force

Run `npm audit` for details.
npm install completed - Sun Oct  2 10:45:27 BST 2022 on base
fixing sandbox permissions
Checking for modules with removed libraries
downloading dumpactivemodules script

processing dependency changes for active modules with package.json files
processing for module MMM-Tools please wait
----------------------------------
npm WARN invalid config omit="dev --no-audit --no-fund --no-update-notifier" set in command line options
npm WARN invalid config Must be one or more of: dev, optional, peer

added 3 packages, and audited 4 packages in 3s

1 package is looking for funding
  run `npm fund` for details

found 0 vulnerabilities
processing complete for module MMM-Tools
restoring custom.css
removing git alias
we stashed a set of files that appear changed from the latest repo versions. you should review them
Upgrade ended - Sun Oct  2 10:45:33 BST 2022

Upgrade started - Tue Oct 17 12:57:21 BST 2023
system is Linux MAGIC-MIRROR 6.1.21-v8+ #1642 SMP PREEMPT Mon Apr 3 17:24:16 BST 2023 aarch64 GNU/Linux
the os is Distributor ID: Raspbian Description: Raspbian GNU/Linux 11 (bullseye) Release: 11 Codename: bullseye
doing test run = true, NO updates will be applied!
[96mCheck current Node installation ...[0m
[0mNode currently installed. Checking version number.
[0mMinimum Node version: [1mv20.8.0[0m
[0mInstalled Node version: [1mv16.20.2[0m
[96mNode should be upgraded.[0m
[91mA Node process is currently running. Can't upgrade.
Please quit all Node processes and restart the update.
junior 18317 18316 0 Oct07 0 00:00:00 node ./node_modules/.bin/electron js/electron.js

Upgrade started - Tue Oct 17 12:58:30 BST 2023
system is Linux MAGIC-MIRROR 6.1.21-v8+ #1642 SMP PREEMPT Mon Apr 3 17:24:16 BST 2023 aarch64 GNU/Linux
the os is Distributor ID: Raspbian Description: Raspbian GNU/Linux 11 (bullseye) Release: 11 Codename: bullseye
doing test run = true, NO updates will be applied!
[96mCheck current Node installation ...[0m
[0mNode currently installed. Checking version number.
[0mMinimum Node version: [1mv20.8.0[0m
[0mInstalled Node version: [1mv16.20.2[0m
[96mNode should be upgraded.[0m
[91mA Node process is currently running. Can't upgrade.
Please quit all Node processes and restart the update.
junior 8378 8377 5 12:58 0 00:00:00 node ./node_modules/.bin/electron js/electron.js

Upgrade started - Tue Oct 17 13:04:45 BST 2023
system is Linux MAGIC-MIRROR 6.1.21-v8+ #1642 SMP PREEMPT Mon Apr 3 17:24:16 BST 2023 aarch64 GNU/Linux
the os is Distributor ID: Raspbian Description: Raspbian GNU/Linux 11 (bullseye) Release: 11 Codename: bullseye
doing test run = true, NO updates will be applied!
[96mCheck current Node installation ...[0m
[0mNode currently installed. Checking version number.
[0mMinimum Node version: [1mv20.8.0[0m
[0mInstalled Node version: [1mv16.20.2[0m
[96mNode should be upgraded.[0m
[91mA Node process is currently running. Can't upgrade.
Please quit all Node processes and restart the update.
junior 8378 8377 0 12:58 ? 00:00:00 node ./node_modules/.bin/electron js/electron.js

Upgrade started - Sun Oct 22 09:24:16 BST 2023
system is Linux MAGIC-MIRROR 6.1.21-v8+ #1642 SMP PREEMPT Mon Apr 3 17:24:16 BST 2023 aarch64 GNU/Linux
the os is Distributor ID: Raspbian Description: Raspbian GNU/Linux 11 (bullseye) Release: 11 Codename: bullseye
doing test run = true, NO updates will be applied!
[96mCheck current Node installation ...[0m
[0mNode currently installed. Checking version number.
[0mMinimum Node version: [1mv20.8.0[0m
[0mInstalled Node version: [1mv16.20.2[0m
[96mNode should be upgraded.[0m
[91mA Node process is currently running. Can't upgrade.
Please quit all Node processes and restart the update.
junior 3451 3450 0 Oct17 ? 00:00:00 node ./node_modules/.bin/electron js/electron.js

Upgrade started - Tue Oct 24 11:04:00 BST 2023
system is Linux MAGIC-MIRROR 6.1.21-v8+ #1642 SMP PREEMPT Mon Apr 3 17:24:16 BST 2023 aarch64 GNU/Linux
the os is Distributor ID: Raspbian Description: Raspbian GNU/Linux 11 (bullseye) Release: 11 Codename: bullseye
n (node version manager tool) not installed, doing test run, install skipped
doing test run = true, NO updates will be applied!
[96mCheck current Node installation ...[0m
[0mNode currently installed. Checking version number.
[0mMinimum Node version: [1mv20.8.0[0m
[0mInstalled Node version: [1mv16.20.2[0m
[96mNode should be upgraded.[0m
[91mA Node process is currently running. Can't upgrade.
Please quit all Node processes and restart the update.
junior 3451 3450 0 Oct17 ? 00:00:00 node ./node_modules/.bin/electron js/electron.js

Upgrade started - Tue Oct 24 11:04:44 BST 2023
system is Linux MAGIC-MIRROR 6.1.21-v8+ #1642 SMP PREEMPT Mon Apr 3 17:24:16 BST 2023 aarch64 GNU/Linux
user requested to apply changes
the os is Distributor ID: Raspbian Description: Raspbian GNU/Linux 11 (bullseye) Release: 11 Codename: bullseye

added 1 package, and audited 2 packages in 2s

found 0 vulnerabilities
npm notice 
npm notice New major version of npm available! 8.19.4 -> 10.2.1
npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.2.1>
npm notice Run `npm install -g npm@10.2.1` to update!
npm notice 
  installing : node-v20.8.0
       mkdir : /usr/local/n/versions/node/20.8.0
       fetch : https://nodejs.org/dist/v20.8.0/node-v20.8.0-linux-arm64.tar.xz
     copying : node/20.8.0
   installed :  (with npm 10.1.0)

Note: the node command changed location and the old location may be remembered in your current shell.
         old : /usr/bin/node
         new : /usr/local/bin/node
If "node --version" shows the old version then start a new shell, or reset the location hash with:
hash -r  (for bash, zsh, ash, dash, and ksh)
rehash   (for csh and tcsh)
doing test run = false
[96mCheck current Node installation ...[0m
[0mNode currently installed. Checking version number.
forcing low Node version
[0mMinimum Node version: [1mv20.8.0[0m
[0mInstalled Node version: [1mV1.0.0[0m
[96mNode should be upgraded.[0m
[91mA Node process is currently running. Can't upgrade.
Please quit all Node processes and restart the update.
junior 3451 3450 0 Oct17 ? 00:00:00 node ./node_modules/.bin/electron js/electron.js



Node currently installed. Checking version number.
Minimum Node version: v20.8.0
Installed Node version: v16.20.2
Node should be upgraded.
A Node process is currently running. Can't upgrade.
Please quit all Node processes and restart the update.
running process(s) are
junior 3451 3450 0 Oct17 ? 00:00:00 node ./node_modules/.bin/electron js/electro                                           n.js
junior@MAGIC-MIRROR:~ $ bash -c  "$(curl -sL https://raw.githubusercontent.com/s                                           detweil/MagicMirror_scripts/master/upgrade-script.sh)" apply
npm WARN cli npm v10.1.0 does not support Node.js v16.20.2. This version of npm                                            supports the following node versions: `^18.17.0 || >=20.5.0`. You can find the l                                           atest version at https://nodejs.org/.
/usr/bin/n: line 746: /usr/local/bin/node: No such file or directory
doing test run = false
update log will be in /home/junior/MagicMirror/installers/upgrade.log
Check current Node installation ...
Node currently installed. Checking version number.
apply: line 207: /usr/local/bin/node: No such file or directory
Minimum Node version: v20.8.0
Installed Node version: V1.0.0
Node should be upgraded.
A Node process is currently running. Can't upgrade.
Please quit all Node processes and restart the update.
running process(s) are
junior 3451 3450 0 Oct17 ? 00:00:00 node ./node_modules/.bin/electron js/electro                                           n.js
junior@MAGIC-MIRROR:~ $

sdetweil

@DarkV you have to stop your running mm first

pm2 stop all

DarkV

@sdetweil said in Failed Update:

pm2 stop all

I can now update because that worked—many thanks for your assistance.

sdetweil

@DarkV were u able to update successfully?

DarkV

@sdetweil it goes through the update process successfully, but on the mirror, it still reports that it is 3 updates behind upon reboot

sdetweil

@DarkV well then it didn’t do the upgrade

this is a two step process( two links on the page)

test, alert any issues, files might be overwritten, etc
make no changes

apply, DO THE UPGRADE

except, if its the same version is already installed.
DON’T DO IT AGAIN…
but if you change the apply parm to force
then it will

show me the ~/MagicMirror/installers/upgrade.log