Calendar moves right by 5 px every update

emwtur

Doing the dirty fix :
round line 320 in calendars.js :

                            const symbols = this.symbolsForEvent(event);
                            symbols.forEach((s, index) => {

// const symbol = document.createElement(“span”);
// symbol.className = s;
// if (index > 0) {
// symbol.style.paddingLeft = “5px”;
// }
// symbolWrapper.appendChild(symbol);
});
eventWrapper.appendChild(symbolWrapper);

removes the issue for me - I assume the calculation goes wrong somehow - I tried to remove my different calendars one by one and it did not affect the “move right” so

For today - I’ll leave it at that - can’t tell if it’s parsing the calendar and thinking there are more and more symbols ?

sdetweil

@emwtur can you show the calendar configs? xxx out the urls

there was a fix in the area…

emwtur

@sdetweil
I’ll reinstall some stuff and try to remove all calendars I had and only use the one from the sample config and see how that goes.
Should point to something being wrong with my .ics files ( or how they are parsed, if it works
/P

sdetweil

@emwtur the fix was when there were multiple symbols

symbol:[x,y,z]

in the calendar specification

emwtur

@sdetweil
Yes I had multiple but tried to remove all of them - didn’t help.

Anyway having ONLY the cal from config.js.sample looks to work - having restored calendar.js to original

emwtur

@sdetweil
it has to do with multiple symbols.
looks like the bug can be reproduced using the cal setting from the sample file , just add another symbol and watch it move

{
		module: "calendar",
		header: "US Holidays",
		position: "top_left",
		config: {
			calendars: [
				{
					fetchInterval: 7 * 24 * 60 * 60 * 1000,
					symbol: ["calendar-check","google"]
					url: "https://ics.calendarlabs.com/76/mm3137/US_Holidays.ics"
				}
			]
		}
	},

sdetweil

@emwtur great!!! thsnks

emwtur

@sdetweil

Having single symbols is something I can live with - was just confused - it worked before updating…

thank YOU for great work with Magic Mirror.
regards
/Per-Eric

sdetweil

@emwtur ok, i made the change , so gotta figure out how i screwed that up

sdetweil

@emwtur want to try the fix

calendar.js , line 915

			if (p instanceof Array) {   // keep add brace, remove rest of line or // comment out
			 let temp=[]
			 p.forEach(name=>{temp.push(className +name)});
			 p = temp
			}                                                  
			else p = className + p;  // keep