Calendar moves right by 5 px every update

[sdetweil]

@emwtur is that cal entry the one with the html?

[emwtur]

@sdetweil No it was another calendar module showing a week view -

I was showing the html I get when I browse to the url of the machine showing the magic mirror - should be the same html that is shown on the mirror - I have the same problems in both anyway

I have removed the other calendar module and still have the problem

/P

[sdetweil]

@emwtur still, the symbol name is not being used

[emwtur]

@sdetweil

Doing the dirty fix :
round line 320 in calendars.js :

                            const symbols = this.symbolsForEvent(event);
                            symbols.forEach((s, index) => {

// const symbol = document.createElement(“span”);
// symbol.className = s;
// if (index > 0) {
// symbol.style.paddingLeft = “5px”;
// }
// symbolWrapper.appendChild(symbol);
});
eventWrapper.appendChild(symbolWrapper);

removes the issue for me - I assume the calculation goes wrong somehow - I tried to remove my different calendars one by one and it did not affect the “move right” so

For today - I’ll leave it at that - can’t tell if it’s parsing the calendar and thinking there are more and more symbols ?

[sdetweil]

@emwtur can you show the calendar configs? xxx out the urls

there was a fix in the area…

[emwtur]

@sdetweil
I’ll reinstall some stuff and try to remove all calendars I had and only use the one from the sample config and see how that goes.
Should point to something being wrong with my .ics files ( or how they are parsed, if it works
/P

[sdetweil]

@emwtur the fix was when there were multiple symbols

symbol:[x,y,z]

in the calendar specification

[emwtur]

@sdetweil
Yes I had multiple but tried to remove all of them - didn’t help.

Anyway having ONLY the cal from config.js.sample looks to work - having restored calendar.js to original

[emwtur]

@sdetweil
it has to do with multiple symbols.
looks like the bug can be reproduced using the cal setting from the sample file , just add another symbol and watch it move

{
		module: "calendar",
		header: "US Holidays",
		position: "top_left",
		config: {
			calendars: [
				{
					fetchInterval: 7 * 24 * 60 * 60 * 1000,
					symbol: ["calendar-check","google"]
					url: "https://ics.calendarlabs.com/76/mm3137/US_Holidays.ics"
				}
			]
		}
	},

[sdetweil]

@emwtur great!!! thsnks

[emwtur]

@sdetweil

Having single symbols is something I can live with - was just confused - it worked before updating…

thank YOU for great work with Magic Mirror.
regards
/Per-Eric

[sdetweil]

@emwtur ok, i made the change , so gotta figure out how i screwed that up

[sdetweil]

@emwtur want to try the fix

calendar.js , line 915

			if (p instanceof Array) {   // keep add brace, remove rest of line or // comment out
			 let temp=[]
			 p.forEach(name=>{temp.push(className +name)});
			 p = temp
			}                                                  
			else p = className + p;  // keep

[emwtur]

@sdetweil
Looks like it’s working with that fix - line numbers didn’t match so I had to think a little before applying - tested with multiple symbols on some cals and both symbols show and stay in place

/Per-Eric

[sdetweil]

@emwtur awesome!!!

[sdetweil]

@emwtur the fix for this has been accepted and added to the next release (develop branch)

develop includes the fix for broadcast clipping too…
if you have the develop branch, then you can git pull to update

if you don’t have develop, then see this topic
https://forum.magicmirror.builders/topic/14327/testing-new-fixes-or-solving-current-problems-with-next-release-code

[emwtur]

@sdetweil
I’m happy sitting with modded code - I’ll have to stash it when next release comes in march or start fresh again.

Thanks for your efforts once again !
/Per-Eric

[sdetweil]

@emwtur my upgrade script will handle that

it will say that the calendar.js is modified, do you want to save that,
say no…

https://github.com/sdetweil/MagicMirror_scripts

if you run the test version first, it wont change anything, but still will warn you
(how to remember if you changed files…)