Issue with Outlook recurring events

sdetweil

@WallysWellies this fix sets the rrule:until to start of day+1 day for fullday events (tested in LA, Chicago, London and Sydney timezones)

add three lines
modules/default/calendarcalendarfetcherutils.js

					event.start = rule.options.dtstart;  // old code line 294
                                        // insert these three lines
					if((rule.options.until != undefined) && CalendarFetcherUtils.isFullDayEvent(event)){
						Log.debug("fixup rrule until")
						rule.options.until = new Date(new Date(moment(rule.options.until).startOf("day").add(1,"day")).getTime())
					}

					Log.debug("fix rrule start=", rule.options.dtstart); // old code line 301

WallysWellies

@sdetweil Thank you - that has fixed my upcoming calendar event 👍

sdetweil

@WallysWellies cool, i will submit as a change for next release

sdetweil

@WallysWellies you will need to use my upgrade script and reply no to keeping the changed files
see https://github.com/sdetweil/MagicMirror_scripts

note upgrade is a two part process
test, do nothing (highlight exposed files, if any)
do upgrade

sdetweil

@WallysWellies I opened issue 3781
https://github.com/MagicMirrorOrg/MagicMirror/issues/3781
and pushed the fix and testcase for next release

WallysWellies

@sdetweil Thank you!

sdetweil

@WallysWellies this was accepted and added to the next release

WallysWellies

Hi Sam,

I’m afraid this issue has reoccurred on an event that is not full day but instead is supposed to be the last in a series. I believe it’s the same issue though where the timezone / BST is causing the problem.

Sample ICS data below:

BEGIN:VCALENDAR
METHOD:PUBLISH
PRODID:Microsoft Exchange Server 2010
VERSION:2.0
X-WR-CALNAME:Test Calendar
BEGIN:VTIMEZONE
TZID:GMT Standard Time
BEGIN:STANDARD
DTSTART:16010101T020000
TZOFFSETFROM:+0100
TZOFFSETTO:+0000
RRULE:FREQ=YEARLY;INTERVAL=1;BYDAY=-1SU;BYMONTH=10
END:STANDARD
BEGIN:DAYLIGHT
DTSTART:16010101T010000
TZOFFSETFROM:+0000
TZOFFSETTO:+0100
RRULE:FREQ=YEARLY;INTERVAL=1;BYDAY=-1SU;BYMONTH=3
END:DAYLIGHT
END:VTIMEZONE
BEGIN:VEVENT
RRULE:FREQ=WEEKLY;UNTIL=20250630T173000Z;INTERVAL=1;BYDAY=MO;WKST=MO
UID:040000008200E00074C5B7101A82E00800000000E05582F27408DB01000000000000000
 010000000E892CDFA6C0E4E4298E1C987B4791120
SUMMARY:Calendar Event
DTSTART;TZID=GMT Standard Time:20250331T183000
DTEND;TZID=GMT Standard Time:20250331T200000
CLASS:PUBLIC
PRIORITY:5
DTSTAMP:20250630T164141Z
TRANSP:OPAQUE
STATUS:CONFIRMED
SEQUENCE:0
LOCATION:
X-MICROSOFT-CDO-APPT-SEQUENCE:0
X-MICROSOFT-CDO-BUSYSTATUS:BUSY
X-MICROSOFT-CDO-INTENDEDSTATUS:BUSY
X-MICROSOFT-CDO-ALLDAYEVENT:FALSE
X-MICROSOFT-CDO-IMPORTANCE:1
X-MICROSOFT-CDO-INSTTYPE:1
X-MICROSOFT-DONOTFORWARDMEETING:FALSE
X-MICROSOFT-DISALLOW-COUNTER:FALSE
X-MICROSOFT-REQUESTEDATTENDANCEMODE:DEFAULT
X-MICROSOFT-ISRESPONSEREQUESTED:FALSE
END:VEVENT
END:VCALENDAR

I’ve stripped out most of the content other than the event in question and the timezone info.

You’ll see that the DTSTART and DTEND data shows the correct start and end time but the RRULE shows the UNTIL as an hour before the event so the event does not show on the MM calendar module.

The event in Outlook shows the series being every Monday until 1st July.

I’m not sure if this “bug” is a problem with Outlook or MagicMirror.

Happy to start a new thread, or log a bug on GitHub if either of those is preferrable.

sdetweil

@WallysWellies there is a rewrite of the calendar event handler coming in tomorrow’s release .

please check there