LICENSE: on modules.magicmirror.builders shows @noassertion instead of MIT

ASteinsdoerfer

Hello,

I added the MIT license to my github project MMM-HusqvarnaAutomower in package.json and as a LICENSE file but on modules.magicmirror.builders it is shown an @noassertion. So no screenshot will be displayed.

What am I doing wrong?

Thanks
Andreas

sdetweil

@ASteinsdoerfer @KristjanESPERANTO will need to help

BKeyport

@ASteinsdoerfer having suffered the same issue - there’s a slight formatting difference between your LICENSE file and mine (other than copyright name). Therefore, I think Kristjan is being too picky on the file.

Maybe we can get a rethink on this.

karsten13

@KristjanESPERANTO

AFAIS the wrong license is coming from the gitHubData.json file.

So looking into https://github.com/MagicMirrorOrg/MagicMirror-3rd-Party-Modules/blob/main/scripts/updateGitHubApiData.js I stumbled over the line
let maxQueryCount = 58; which is used in the shouldFetch function.

Maybe I’m wrong but this looks like we only fetch 58 repos from github and then switch to historical data?

KristjanESPERANTO

@karsten13 is right. We only query GitHub data via the API twice a day - each time we can only make about 50 queries. The infos about a module via the GitHub API are therefore queried over the thumb every 13 days.

The problem with this module was that it had no license file the first time it was called, then the API responds with NOASSERTION. This will be automatically corrected after a few days.

It works and only in rare cases has such rather cosmetic effects, so it is not high on my priority list to optimise this. With authenticating we could make 5000 requests per hour. If anyone would like to implement this, please feel free to create a PR.

karsten13

@KristjanESPERANTO

Thanks! Maybe I take a look into the authenticating stuff …

karsten13

see https://github.com/MagicMirrorOrg/MagicMirror-3rd-Party-Modules/pull/65

karsten13

@ASteinsdoerfer

the problems (license and screenshot) are fixed.

sdetweil

@karsten13 my screenshot is not displayed and dev advice page will not open
MMM-Config
license reporting is correct

seems all dev view is broken
took 45 seconds to open on my phone on wifi on 1g network.

karsten13

@sdetweil

everything working on my side …