Module to Display JSON data from a FILE

sdetweil

@mhr320 I submitted pull request
https://github.com/timdows/MMM-JsonTable/pull/98

sdetweil

@mhr320 said in Module to Display JSON data from a FILE:

It was nice to have a pleasant experience in a forum for a change, does not always go that way.

I am glad to hear that it worked out, and sad to hear the other.
as the moderator here, I am interested in feedback on how to make it better most of the time…

mhr320

@sdetweil Hard to say how to improve things from our interaction. 5/5 Stars. I am new-ish to actively using this forum and wanted to give you props for your efforts, not sure if I did through any formal process, I tried to show the answer as the solution and attempted to upvote, but not sure if I did. But if you are the mod and jumped in to help me, that is a great way to make the forum better. Take care and enjoy the grandchild!

sdetweil

@mhr320 no… you said in " a " forum for a change, does not always go that way.

I wanted to know what that was… was that HERE?

we try hard to make sure everyone gets supported in some way

sdetweil

@mhr320 said in Module to Display JSON data from a FILE:

and attempted to upvote, but not sure if I did

upvote/downvote are restricted to user that have reputation 2 or above (means someone liked/upvoted your contribution twice)
this was we know reputation is not tainted with transient (mostly down) voters…

same as having all posts reviewed before live posting, til you rep is 2 or above.

mhr320

@sdetweil Oh, in “a forum” was relative to another forum, this is the first time, in a long time, i’ve used this forum. HERE has been great every time so far, sorry for the misunderstanding.

sdetweil

@mhr320 the author accepted my change request

so you could go to the old folder (if you just renamed it) and git pull to get the update
then swap(rename) the folders and retry with his code again
and then delete mine

mhr320

Whoa, that was fast on both of your parts. I went to his github page and saw several old open “issues” i figured he’d be asleep on the project, but wow! It worked, great job sir! I really look forward to my next issue.

timdows

@sdetweil

Thanks for the PR

Just approved the it, it did fail some prittier checks that I’ll fix later
Hope you’ll find it usefull over here!

https://github.com/timdows/MMM-JsonTable

sdetweil

@timdows you should add a git pre-commit hook to run prettier for whoever…

here is mine
.pre-commit

#!/bin/sh
FILES=$(git diff --cached --name-only --diff-filter=ACMR "*.js" "*.jsx *.json" | sed 's| |\\ |g')
[ -z "$FILES" ] && exit 0

# Prettify all selected files
echo "$FILES" | xargs ./node_modules/.bin/prettier --write

# Add back the modified/prettified files to staging
echo "$FILES" | xargs git add

exit 0

and an npm postinstall script to copy to the git folder

#!/bin/bash
#echo copying git pre-commit hook 
cp .pre-commit .git/hooks

package.json

  "scripts": {
    "postinstall":"whatever you call it"