MagicMirror Forum

    • Register
    • Login
    • Search
    • Recent
    • Tags
    • Unsolved
    • Solved
    • MagicMirror² Repository
    • Documentation
    • Donate
    • Discord

    [MMM-Skolmaten] Shows school lunch menus in Sweden from skolmaten.se

    Utilities
    5
    16
    5201
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • J
      Jacco7702 last edited by

      Yes that did it. I had the same problem. I guess the dependency to rss-parser is hard coded to a specific version or that the latest works diffrent than this one

      1 Reply Last reply Reply Quote 1
      • E
        erq last edited by

        Thanks, that did it!

        1 Reply Last reply Reply Quote 1
        • R
          retroflex Project Sponsor Module Developer @erq last edited by

          @erq @Henrik Thanks for the tip! I have made a quick solution for now… changed package.json to have dependency to rss-parser v2.12.0.

          Checked the rss-parser readme and the latest version (3) has changed it’s interface (“A few minor breaking changes were made in v3…”). If I find the time, I will update my code to support the latest version.

          1 Reply Last reply Reply Quote 1
          • H
            Henrik last edited by

            Excellent, you solved the problem before I even had a chance to have a look at it! Well done!
            I guess you can revoke my github access now. 🙂

            1 Reply Last reply Reply Quote 0
            • H
              Henrik @retroflex last edited by

              @retroflex said in [MMM-Skolmaten] Shows school lunch menus in Sweden from skolmaten.se:

              Added you as a collaborator to the repo. I’m new to git so let me know if there’s anything else I must do. Follow up question: is it better to be a collaborator than to send pull requests? Or maybe just easier?

              I don’t know exactly what collaborator means, haven’t used github much other than cloning stuff from it.
              Normally you’d create a branch, do you stuff, raise a pull request, have it reviewed, (hopefully) accepted, and then merge.

              R 1 Reply Last reply Reply Quote 0
              • R
                retroflex Project Sponsor Module Developer @Henrik last edited by

                @Henrik From what I’ve read, a collaborator has write access directly to the repo. You can push code directly as if you are the owner.

                1 Reply Last reply Reply Quote 1
                • 1
                • 2
                • 2 / 2
                • First post
                  Last post
                Enjoying MagicMirror? Please consider a donation!
                MagicMirror created by Michael Teeuw.
                Forum managed by Paul-Vincent Roll and Rodrigo Ramírez Norambuena.
                This forum is using NodeBB as its core | Contributors
                Contact | Privacy Policy