Reverse Lookup MMM-FRITZ-Box-Callmonitor - help needed

barnosch

cool feature, i will definitely upgrade to that version, if it is running well
thumbsup
and now the but…
is this really necessary these days?
I don’t know any of my friends or our generation who really publicate their phonenumber in the public phonebook.
Mobile numbers especially not.
So it is only helpful for bigger companies, right?

yawns

@barnosch
Not necessarily. Even smaller companies (those without one base number and dozens of extensions) do add their phone number to public phonebooks. My phone solution does use online lookup and lots of craftspeople who called during our house building phase where identified on the phone showing “Dachdecker Hildebrandt” (for example).

AxLed

@pinsdorf
i created a fork, i am not sure if i did everything right (i checked some readme before and keeped on that), details see: https://github.com/Ax-LED/MMM-FRITZ-Box-Callmonitor/pull/1/files

There is also a working beta of the reverse lookup feature.

I know the code is still quick n dirty.

AxLED

pinsdorf

Hey @AxLed, sorry for the late reply. I’ve had a look at your code. It looks very good. Well done, man! Functionality is there. Certainly, you can do some cleanup as you say, but that is secondary. It is great that you have extended this module with such nice magic.

One suggestion I made earlier is putting the lookup at the online phone book (dasoertliche.de) & parsing into its own module. This would allow others to write phonebook lookup modules for their own country. I’m happy to do this change on your code base.

You did all the (sometimes confusing) Git stuff right: you forked from the original repository, checked out your repository, made changes, committed and pushed them back into your repository. There was just one step too much, which is the pull request. You typically make a pull request in the person’s repository that you have forked from to tell the original author ‘hey, here is cool new stuff that you may want to have in the original repository’. I would suggest that you accept or remove your own pull request.

If you want me to extract a module for the phonebook lookup & parsing, I can work on the latest version of your repository and either push directly to your repo (if you grant me write access) or I send my own pull request to you.

AxLed

Hi pinsdorf,

thanks for your reply, here are some answers to your questions:

putting the lookup in a own module.
=> Feel free, you just have to tell me, how i can grant write permissions to you (maybe via PN)
i closed my own pull request, as i didnt find any other option

Maybe you can also help in fixing this issue: https://github.com/paviro/MMM-FRITZ-Box-Callmonitor/issues/30

Regards

AxLED