MMM-iFrame-Ping

bolish

Review :

Using a list of several URL is working. Seems more “slow / laggy” than with iFrame-Ping and only one URL. Strange but OK.
URL rotation is working great. (maybe a bit slow because of reloading needs, but I guess than there is not much you can do for that?)
URL NEXT / PREV / PLAY / PAUSE is working like a charm. Which was my initial need, so perfect.

So all in all, a major and well managed update. Good job @AgP42 .

One thing :

Even by using the same size (% or px) parameter as in previous iFrame-Ping, the picture is much more smaller (tiny!!!) in this new module. Strange but nothing critical.

I’m displying youtube channels and “middle_center” parameter.

Nevertheless, when I increase the size of it, the centering is not working well. Indeed, the margin remains the same on left side, meaning the frame is off-centered on the right side of the screen.

Hope this can be fixed easily (I tried to look at it myself, .css, etc… but I’m not skilled enough). Maybe it’s something I’m doing wrong on my side…

AgP42

@bolish, thanks for your very fast review ! I just upload an update that (should) solve the lagging issue (and on the same time this issue solved the problem of several instances !)

And your display issue was coming from the fact that I send on GitHub my css file with modifs for me, I update it too, so you should be able to get back your previous params

bolish

@AgP42
Centering frame is OK now.
Lagging seems to be much better.
But it seems that new issue is happening. I get constant (uncontrolled) change between status Playing and Stopped which is stopping the video.

Strange.

bolish

I think it’s because of PIR Sensor “USER PRESENCE” notification!!!
(I don’t wnat any interaction between PIR and video), I only use PIR to turn screen ON / OFF.

And this issue is not new since your morning correction…It’s new for me because I installed PIR this morning!!!

Regards

AgP42

@bolish said in MMM-iFrame-Ping:

I think it’s because of PIR Sensor “USER PRESENCE” notification!!!
(I don’t wnat any interaction between PIR and video), I only use PIR to turn screen ON / OFF.

And this issue is not new since your morning correction…It’s new for me because I installed PIR this morning!!!

Regards

But why do you want your video to run if your screen is off ?

bolish

No you’re right I don’t.

I believe I understood the issue :

It seems the PIR sensor I’m using is very sensitive and triggering “USER PRESENCE FALSE” very easily.
I’m able to manage it in MMM-PIR sensor module thanks to the additional delay option which I put to 30 seconds which is preventing the screen to turn ON / OFF every 2 seconds.

But this is then triggering the issue I’m referring to above for MMM-SmartWebDisplay.

Does that makes sense? It’s the only explanation I found for now.

bolish

maybe you should let your module more generic that what you currently did.
If someone wants to STOP the video based on any other notification (like USER PRESENCE, false) he will always have the possibility to use MMM-NotificationTrigger to convert user presence to stop.

Up to you.

If you’re not keen to update that point (which I could understand), I believe I can maybe modify things a little bit myself to manage it.

Maybe the modification should be done directly in MMM-PIR Sensor, which should only trigger PRESENCE FALSE once the additional delay is over and not before…

AgP42

@bolish
Yes I perfectly understand the issue you are facing, in fact I also did some contribution to the module PIR sensor :smiling_face_with_open_mouth_closed_eyes:

Yes the delay on the module apply only about the screen off but the “USER_PRESENCE” is send anyway directly according to the sensor input.

Normaly on your sensor you have 2 screws, one to change the sensibility of the sensor and the other one to adjust the time delay more infos here

Did you check that ?

But you are also right that I could let the choice to the user to use this USER_PRESENCE or not, I will check what I can do for that.

bolish

The sensor I’m using doesn’t offer this option, unfortunatly.
link text

Thinking of it again :

Would it not be more “sustainable” to PR MMM-PIRSensor by putting a second notification trigger “USER_PRESENCE, Screen Off” after the timeout delay.
Then, we could play within MMM-SmartWebDisplay with that one instead of the only USER PRESENCE false, true.
By doing that + adding the option to use it or not, it would make the full thing more reliable and generic.

If I believe it’s somewhere here :

                else if (value == valueOff) {
                    self.sendSocketNotification('USER_PRESENCE', false);
                    if (!self.config.powerSaving){
                        return;
                    }

                    self.deactivateMonitorTimeout = setTimeout(function() {
                        self.deactivateMonitor();
                    }, self.config.powerSavingDelay * 1000);
                }
            });

AgP42

@bolish
On the link you sent, this sensor is exactly the same as mine and its allow to change the timer ! ;-)

The best way to make that clean will be to change the PIR-sensor module to send the notification only at the end of the timer, but I have no time to do so now…

What you can do for now to desactivate the Stop at the reception of a USER_PRESENCE = false notification is to go on the file MMM-SmartWebDisplay.js, on the function “GestionUpdateIntervalSWD”, then comment (//) the line "this.StopDisplay();

In fact I have no time to change the module PIR-Sensor now because I am about to finish an update of the module MMM-RemoteControl to be able to use "Next/Prev/Play/Pause/Stop directly on RemoteControl :