MagicMirror Forum
    • Recent
    • Tags
    • Unsolved
    • Solved
    • MagicMirror² Repository
    • Documentation
    • 3rd-Party-Modules
    • Donate
    • Discord
    • Register
    • Login
    A New Chapter for MagicMirror: The Community Takes the Lead
    Read the statement by Michael Teeuw here.

    Window size and position / Configuration with arrays in general

    Scheduled Pinned Locked Moved Feature Requests
    1 Posts 1 Posters 2.0k Views 1 Watching
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • berlincountB Offline
      berlincount
      last edited by

      Hi!

      I’m the one who filed https://github.com/MichMich/MagicMirror/pull/484, which added single configuration options like window_x, window_y, window_height, etc …

      MichMich’s recommendation was to use an array like

      window: {
      width: 1920,
      height: 1080,
      x: 0,
      y: 0
      }

      … which as such would be fine, but horrible to override.

      As the config-loading code uses Object.assign(defaults, config) to override defaults from the config, the whole Array would have to be given - even if only one option would be needed.

      As it would be awesome to just take the whole Array passed to the BrowserWindow call, a generic way of overriding individual defaults Array entries (including unsetting some) from the config would be nice. I’m currently having trouble wrapping my head around this, so I’m reaching out :)

      Ideas?

      count

      1 Reply Last reply Reply Quote 0
      • 1 / 1
      • First post
        Last post
      Enjoying MagicMirror? Please consider a donation!
      MagicMirror created by Michael Teeuw.
      Forum managed by Sam, technical setup by Karsten.
      This forum is using NodeBB as its core | Contributors
      Contact | Privacy Policy