Jacky5

Jacky5

Hello together

I have noticed that the excludedEvents function with the “until” parameter no longer works. The last time I used the function was version 18.3.24, when everything worked. While searching for the error, I came across this article https://forum.magicmirror.builders/topic/19767/2.32.0-calendar-module-limitdays-and-excludedevents-stopped-working?page=1 or this issue https://github.com/MagicMirrorOrg/MagicMirror/issues/3841.

How was the error found (Reproducible)
I want to hide a recurring event until X days before it starts.
In the test case, the event is called “DailyTask”. This repeats every 2 days. I use the configuration

excludedEvents: [{filterBy: 'DailyTask', until: '2 days'}]

The appointments are displayed unchanged on the MM. I then only used the

excludedEvents: [{filterBy: 'DailyTask''}]

command. Now no events with the name “DailyTask” are displayed. Which leads me to conclude that the “until” parameter no longer works. it does not matter whether days, weeks or months are used

Current Config for Calendar:

		{
			module: "calendar",
			header: "Kalender",
			position: "bottom_left",
			config: {
				excludedEvents: [{filterBy: 'DailyTask', until: '2 days'}],
                fade: true,
                fadePoint: 0.75, // Possible values: 0 (top of the list) - 1 (bottom of list)
                tableClass: "medium", // Possible values: xsmall, small, medium, large, xlarge. Default value: small.
                maximumEntries: 18, // default 10
                showLocation: true,
                maxTitleLength: 40, // values 10-50
                maxLocationTitleLength: 20, // values 10-50
//                hidePrivate: false,
                coloredText: true,
                coloredSymbol: true,
                coloredBackground: true,
				calendars: [
                    {
                        // Test-Kalender
                        fetchInterval: 300000, // 5 min * 12 = 1h
						symbol: "calendar-plus",
                        color: "#FFFFFF", // Dunkleres Grün #1ea30f etwas helleres Grün #43ff64d9
                        symbolClassName: "fa-regular fa-",
                        bgColor: "rgba(0, 0, 0, 0.02)",
                        name: "Test-Kalender",
						url: "https://calendar.google.com/calendar/ical/******************.ics"
                    }
				]
			}

MM was reinstalled a few days ago. A Raspberry Pi 3B+ is used
Operating System: Debian GNU/Linux13 (trixie)
Kernel: Linux 6.12.47+rpt-rpi-v8
Architecture: arm64
MM version: v2.33.0
i use pm2
All modules with the exception of the calendar module were deactivated for the test.

my solution
I think I have found the problem in the calendarfetcherutils.js file.
I have the following line 163:

let { excluded, eventFilterUntil } = this.shouldEventBeExcluded(config, title);

replaced with this code:

let { excluded, until: eventFilterUntil } = this.shouldEventBeExcluded(config, title);

Subsequent tests were positive for me, but I cannot judge whether the customisation has any further effects. Unfortunately I’m not a programmer, just a “nerd” =)
can someone verify this and possibly open a bug?

Best regards
Jacky

Jacky5

@Jacky5

Latest posts made by Jacky5