@sdetweil sorry i don’t uderstand what you mean ?
I think it works if afternoon is present but empty

@sdetweil Yes ! Problem found…
Step by step, i’ve understand

		if (hour >= this.config.morningStartTime && hour < this.config.morningEndTime && this.config.compliments.hasOwnProperty("morning")) {
			compliments = this.config.compliments.morning.slice(0);
		} else if (hour >= this.config.afternoonStartTime && hour < this.config.afternoonEndTime && this.config.compliments.hasOwnProperty("afternoon")) {
			compliments = this.config.compliments.afternoon.slice(0);
		} else if (this.config.compliments.hasOwnProperty("evening")) {
			compliments = this.config.compliments.evening.slice(0);
		}

The JS need to have a “morning” and “afternoon” compliments define, else it choosing “evening” by default if define.

My problem was i don’t had afternoon compliment define…but i’ve evening one.

Thank you very much for your time and your time :) It was very helpful.

@sdetweil Hi,
Ok great.
I be able to see the value of hour variable.
It seem to be correct because it’s 17.

Condition of morning not verified.
Condition of afternoon verified, so the line is executed (because 17 is between 12 and 18)

compliments = this.config.compliments.afternoon.slice(0);

I don’t know why evening compliments are displayed…it’s very strange

@sdetweil
Ok, thank you for your test.
So maybe a problem on my system time. However it seem to be correct. Another solution to verify that ? (Other than timedatectl ?)

Is it possible to have verbose log to see the how the module decide to display compliment ?

@sdetweil Thank you for your time :)
The problem doesn’t concern “anytime” values, but “evening”.
Anytime is anytime and it’s normal that compliment in this section can be displayed at anytime…:)

Compliments define in “evening” are displayed all the day, not only on the evening. This is my problem. The MM showing evening compliment at anytime…

With my exemple, the MM display “Bonne soirée” or “Bonne nuit…”, also the morning, or afternon. Like this compliment was positionned in “anytime”

@sdetweil
Here’s :)

 {
	"anytime": [
			"Comment ça va ?",
			"Bonjour"
			   ],
	"morning": [
			"Un petit café ?",
			"Bien dormi ?",
			"Bonne journée !"
			],
	"evening": [
			"Bonne soirée !",
			"Bonne nuit...",
			"Agréable soirée"
			],
	"day_sunny": [
			"Le temps est ensoleillé aujourd'hui !",
			"C'est une belle journée"
			],
	"day_cloudy": [
			"C'est nuageux aujourd'hui..."
			],
	"snow": [
			"Bataille de boules de neige !!!"
			],
	"rain": [
			"N'oublie pas ton parapluie...",
			"Et si on restait au sec aujourd'hui ?"
			]
}

With " as indicated on the readme when using remote file.
But, i had the problem before using remote file, i’ve do this hoping this would resolve the problem, but it’s dont.

Is it possible to “remove/reinstall” default module like compliments ?

@sdetweil Ok thank you.
Trying with no specific configuration -> MM say “goodnight” or “good evening” but it’s only 4 PM
Trying with specifig configuration with no gap, same result :(

                {
                        module: 'compliments',
                        position: 'lower_third',
                        config: {
                                morningStartTime:3,
                                morningEndTime:12,
                                afternoonStartTime:12,
                                afternoonEndTime:18,
                                remoteFile: 'compliments.json'
                                }
                },

@sdetweil Ok, but i’ve added this configuration because i had the problem with default configuration.
I can delete it. Normally we don’t need this, right ?

@sdetweil said in MMM-compliment showing evening compliment anytime:

@selyjohns ok, one thing
MMM-compliment means some external additional module
module: ‘compliments’,
means the one shipped with MagicMirror…

Oh OK, not evident.
I speak about the module ‘compliments’, integrated with MM in default folder :)

@sdetweil No, nothing…

                {
                        module: 'compliments',
                        position: 'lower_third',
                        config: {
                                morningStartTime:3,
                                morningEndTime:10,
                                afternoonStartTime:13,
                                afternoonEndTime:18,
                                remoteFile: 'compliments.json'
                                }
                },

compliments.json is stored in MagicMirror/modules/default/compliments/ :) This part is good.

Hi,

I’ve a problem with MMM-compliment that showing evening compliment at anytime…

The config is correct.
I’ve adding hour configuration to be sure with morningStartTime, morningEndTime, afternoonStartTime and afternoonEndTime but problem persist…my MM say good night on morning…

The date/time of my rpi3 is correct…any idea ?

Thank you

Hi,

I’ve posted an issue on github, because duration is very different of google maps…(and google maps is more accuracy than mapbox api…)

https://github.com/SamLewis0602/MMM-Traffic/issues/103

Could you tell me if i’m only person with this problem ?

Lat/long are reversed as indicated on the readme, this is not the problem.

Thank you.

Hi,

I want to display two boolean valued with symbolon and symboloff on the same line. Do you know if is it possible ?

The goal is to display on the same line if me of my gf are present, with the good symbol depend of boolean value.

Actually, it’s display on two different line, because first occurence of sameLine can only contain idx and title.

Edit : maybe, another solution is to display information only if the value of boolean is true ?

Thank you.

Hi,
Issue posted on github :)
https://github.com/MichMich/MagicMirror/issues/2717

I’ll keep you informed.
Nice day.

@sdetweil
Hi sam,

Thank you for this quickly response.
I confirm, move this module to disabled and i don’t have UnhandledPromiseRejectionWarning anymore…

But i think this is not a good solution ?

Hi,
I’m actually configure my first MM.
Since yesterday, and i don’t know why, i’ve a message on launch the MM

pi@MagicMirror:~/MagicMirror $ npm run start

> magicmirror@2.17.1 start
> DISPLAY="${DISPLAY:=:0}" ./node_modules/.bin/electron js/electron.js

[29.11.2021 13:35.32.237] [LOG]   Starting MagicMirror: v2.17.1
[29.11.2021 13:35.32.250] [LOG]   Loading config ...
[29.11.2021 13:35.32.263] [LOG]   Loading module helpers ...
[29.11.2021 13:35.32.267] [LOG]   No helper found for module: alert.
[29.11.2021 13:35.32.301] [LOG]   Initializing new module helper ...
[29.11.2021 13:35.32.303] [LOG]   Module helper loaded: updatenotification
[29.11.2021 13:35.32.306] [LOG]   No helper found for module: clock.
[29.11.2021 13:35.32.622] [LOG]   Initializing new module helper ...
[29.11.2021 13:35.32.624] [LOG]   Module helper loaded: calendar
[29.11.2021 13:35.32.626] [LOG]   No helper found for module: weather.
[29.11.2021 13:35.32.629] [LOG]   No helper found for module: compliments.
[29.11.2021 13:35.32.631] [LOG]   No helper found for module: MMM-Traffic.
[29.11.2021 13:35.32.673] [LOG]   Initializing new module helper ...
[29.11.2021 13:35.32.675] [LOG]   Module helper loaded: newsfeed
[29.11.2021 13:35.32.679] [LOG]   Initializing new module helper ...
[29.11.2021 13:35.32.681] [LOG]   Module helper loaded: MMM-Jeedom
[29.11.2021 13:35.32.683] [LOG]   All module helpers loaded.
[29.11.2021 13:35.32.846] [LOG]   Starting server on port 8080 ...
[29.11.2021 13:35.32.872] [LOG]   Server started ...
[29.11.2021 13:35.32.875] [LOG]   Connecting socket for: updatenotification
[29.11.2021 13:35.32.878] [LOG]   Connecting socket for: calendar
[29.11.2021 13:35.32.880] [LOG]   Starting node helper for: calendar
[29.11.2021 13:35.32.881] [LOG]   Connecting socket for: newsfeed
[29.11.2021 13:35.32.883] [LOG]   Starting node helper for: newsfeed
[29.11.2021 13:35.32.885] [LOG]   Connecting socket for: MMM-Jeedom
[29.11.2021 13:35.32.886] [LOG]   Sockets connected & modules started ...
[29.11.2021 13:35.33.271] [LOG]   Launching application.
[29.11.2021 13:35.37.108] [LOG]   Create new calendarfetcher for url: http://p28-caldav.icloud.com/published/2/XXX - Interval: 300000
[29.11.2021 13:35.37.170] [LOG]   Create new calendarfetcher for url: http://p28-caldav.icloud.com/published/2/XXX - Interval: 300000
[29.11.2021 13:35.37.420] [LOG]   Create new newsfetcher for url: https://www.ladepeche.fr/rss.xml - Interval: 300000
[29.11.2021 13:35.37.438] [INFO]  Checking git for module: default
[29.11.2021 13:35.37.481] [INFO]  Checking git for module: MMM-Traffic
[29.11.2021 13:35.37.504] [INFO]  Checking git for module: MMM-Jeedom
[29.11.2021 13:35.38.791] [INFO]  Calendar-Fetcher: Broadcasting 10 events.
[29.11.2021 13:35.38.845] [INFO]  Newsfeed-Fetcher: Broadcasting 100 items.
[29.11.2021 13:35.43.285] [INFO]  Calendar-Fetcher: Broadcasting 10 events.
[29.11.2021 13:35.44.412] [ERROR] (node:3953) UnhandledPromiseRejectionWarning: Error: Command failed: cd /home/pi/MagicMirror/ && git fetch --dry-run
error: droits insuffisants pour ajouter un objet à la base de données .git/objects du dépôt
fatal: failed to write object
fatal: échec de unpack-objects

    at ChildProcess.exithandler (child_process.js:317:12)
    at ChildProcess.emit (events.js:315:20)
    at maybeClose (internal/child_process.js:1048:16)
    at Socket.<anonymous> (internal/child_process.js:439:11)
    at Socket.emit (events.js:315:20)
    at Pipe.<anonymous> (net.js:673:12)
(Use `electron --trace-warnings ...` to show where the warning was created)
[29.11.2021 13:35.44.416] [ERROR] (node:3953) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
[29.11.2021 13:35.44.418] [ERROR] (node:3953) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
^C/home/pi/MagicMirror/node_modules/electron/dist/electron exited with signal SIGINT

The MM works perfectly, but i don’t know why i’ve this message.
Could you help me ?

Thank you :) !