Posts made by TheSij

@sdetweil - understood. Thanks!

@sdetweil - too late. Sorry, I went ahead before getting this advice. I’ll remember for next time.

@sdetweil - thanks. I think I’ve got it working. The module is finally showing in the MM dashboard. Thanks very much for the guidance, and @Mykle1.

@sdetweil - as in, the files for that module is in the MM modules folder. Sorry if I’m using the wrong terminology.

So, after running the ‘npm install async’, it found three low vulnerabilities, which I’ve asked for them to be fixed.

@sdetweil said in How to add modules. For absolute beginners.:

I am 110% sure I installed the module in the right directory. I always check before I execute it. I’ve just checked the directory, and the module repository is in the right place. I’m executing the ‘npm install async’ command now. Fingers crossed!

@sdetweil - apologies, I was in the wrong directory. This is the terminal response…

> magicmirror@2.12.0 start /home/pi/MagicMirror
> DISPLAY="${DISPLAY:=:0}" ./node_modules/.bin/electron js/electron.js

[2020-07-27 22:56:11.226] [LOG]    Starting MagicMirror: v2.12.0
[2020-07-27 22:56:11.233] [LOG]    Loading config ...
[2020-07-27 22:56:11.238] [LOG]    Loading module helpers ...
[2020-07-27 22:56:11.240] [LOG]    No helper found for module: alert.
[2020-07-27 22:56:11.290] [LOG]    Initializing new module helper ...
[2020-07-27 22:56:11.291] [LOG]    Module helper loaded: updatenotification
[2020-07-27 22:56:11.291] [LOG]    No helper found for module: clock.
[2020-07-27 22:56:11.643] [LOG]    Initializing new module helper ...
[2020-07-27 22:56:11.644] [LOG]    Module helper loaded: calendar
[2020-07-27 22:56:11.645] [LOG]    No helper found for module: currentweather.
[2020-07-27 22:56:11.646] [LOG]    No helper found for module: weatherforecast.
[2020-07-27 22:56:11.678] [LOG]    Initializing new module helper ...
[2020-07-27 22:56:11.678] [LOG]    Module helper loaded: newsfeed
[2020-07-27 22:56:11.679] [LOG]    No helper found for module: MMM-TFL.
[2020-07-27 22:56:11.681] [ERROR]  WARNING! Could not load config file. Starting with default configuration. Error found: Error: Cannot find module 'async'
Require stack:
- /home/pi/MagicMirror/modules/MMM-PrayerTime/node_helper.js
- /home/pi/MagicMirror/js/app.js
- /home/pi/MagicMirror/js/electron.js
- /home/pi/MagicMirror/node_modules/electron/dist/resources/default_app.asar/main.js
- 
[2020-07-27 22:56:11.682] [LOG]    Loading module helpers ...
[2020-07-27 22:56:11.683] [LOG]    No helper found for module: alert.
[2020-07-27 22:56:11.683] [LOG]    Initializing new module helper ...
[2020-07-27 22:56:11.684] [LOG]    Module helper loaded: updatenotification
[2020-07-27 22:56:11.684] [LOG]    No helper found for module: clock.
[2020-07-27 22:56:11.685] [LOG]    Initializing new module helper ...
[2020-07-27 22:56:11.685] [LOG]    Module helper loaded: calendar
[2020-07-27 22:56:11.685] [LOG]    No helper found for module: currentweather.
[2020-07-27 22:56:11.686] [LOG]    No helper found for module: weatherforecast.
[2020-07-27 22:56:11.686] [LOG]    Initializing new module helper ...
[2020-07-27 22:56:11.686] [LOG]    Module helper loaded: newsfeed
[2020-07-27 22:56:11.687] [LOG]    No helper found for module: MMM-TFL.
[2020-07-27 22:56:11.688] [ERROR]  App threw an error during load
[2020-07-27 22:56:11.689] [ERROR]  Error: Cannot find module 'async'
Require stack:
- /home/pi/MagicMirror/modules/MMM-PrayerTime/node_helper.js
- /home/pi/MagicMirror/js/app.js
- /home/pi/MagicMirror/js/electron.js
- /home/pi/MagicMirror/node_modules/electron/dist/resources/default_app.asar/main.js
- 
    at Module._resolveFilename (internal/modules/cjs/loader.js:627:15)
    at Function.Module._resolveFilename (/home/pi/MagicMirror/node_modules/electron/dist/resources/electron.asar/common/reset-search-paths.js:41:16)
    at Function.Module._resolveFilename (/home/pi/MagicMirror/node_modules/module-alias/index.js:49:29)
    at Function.Module._load (internal/modules/cjs/loader.js:531:27)
    at Module.require (internal/modules/cjs/loader.js:685:19)
    at require (internal/modules/cjs/helpers.js:16:16)
    at Object.<anonymous> (/home/pi/MagicMirror/modules/MMM-PrayerTime/node_helper.js:9:13)
    at Module._compile (internal/modules/cjs/loader.js:786:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:798:10)
    at Module.load (internal/modules/cjs/loader.js:645:32)
[2020-07-27 22:56:11.690] [ERROR]  Whoops! There was an uncaught exception...
[2020-07-27 22:56:11.690] [ERROR]  Error: Cannot find module 'async'
Require stack:
- /home/pi/MagicMirror/modules/MMM-PrayerTime/node_helper.js
- /home/pi/MagicMirror/js/app.js
- /home/pi/MagicMirror/js/electron.js
- /home/pi/MagicMirror/node_modules/electron/dist/resources/default_app.asar/main.js
- 
    at Module._resolveFilename (internal/modules/cjs/loader.js:627:15)
    at Function.Module._resolveFilename (/home/pi/MagicMirror/node_modules/electron/dist/resources/electron.asar/common/reset-search-paths.js:41:16)
    at Function.Module._resolveFilename (/home/pi/MagicMirror/node_modules/module-alias/index.js:49:29)
    at Function.Module._load (internal/modules/cjs/loader.js:531:27)
    at Module.require (internal/modules/cjs/loader.js:685:19)
    at require (internal/modules/cjs/helpers.js:16:16)
    at Object.<anonymous> (/home/pi/MagicMirror/modules/MMM-PrayerTime/node_helper.js:9:13)
    at Module._compile (internal/modules/cjs/loader.js:786:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:798:10)
    at Module.load (internal/modules/cjs/loader.js:645:32) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/home/pi/MagicMirror/modules/MMM-PrayerTime/node_helper.js',
    '/home/pi/MagicMirror/js/app.js',
    '/home/pi/MagicMirror/js/electron.js',
    '/home/pi/MagicMirror/node_modules/electron/dist/resources/default_app.asar/main.js',
    undefined
  ]
}
[2020-07-27 22:56:11.696] [ERROR]  MagicMirror will not quit, but it might be a good idea to check why this happened. Maybe no internet connection?
[2020-07-27 22:56:11.697] [ERROR]  If you think this really is an issue, please open an issue on GitHub: https://github.com/MichMich/MagicMirror/issues
[2020-07-27 22:56:11.814] [LOG]    Launching application.

@sdetweil - this is the log when I started MM just now…

0 info it worked if it ends with ok
1 verbose cli [ '/usr/bin/node', '/usr/local/bin/npm', 'start' ]
2 info using npm@6.14.7
3 info using node@v10.19.0
4 verbose stack Error: missing script: start
4 verbose stack     at run (/usr/local/lib/node_modules/npm/lib/run-script.js:155:19)
4 verbose stack     at /usr/local/lib/node_modules/npm/lib/run-script.js:63:5
4 verbose stack     at /usr/local/lib/node_modules/npm/node_modules/read-package-json/read-json.js:116:5
4 verbose stack     at /usr/local/lib/node_modules/npm/node_modules/read-package-json/read-json.js:436:5
4 verbose stack     at checkBinReferences_ (/usr/local/lib/node_modules/npm/node_modules/read-package-json/read-json.js:391:45)
4 verbose stack     at final (/usr/local/lib/node_modules/npm/node_modules/read-package-json/read-json.js:434:3)
4 verbose stack     at then (/usr/local/lib/node_modules/npm/node_modules/read-package-json/read-json.js:161:5)
4 verbose stack     at /usr/local/lib/node_modules/npm/node_modules/read-package-json/read-json.js:382:12
4 verbose stack     at /usr/local/lib/node_modules/npm/node_modules/graceful-fs/graceful-fs.js:123:16
4 verbose stack     at FSReqWrap.readFileAfterClose [as oncomplete] (internal/fs/read_file_context.js:53:3)
5 verbose cwd /home/pi/MagicMirror/modules/MMM-soccer
6 verbose Linux 4.19.118-v7l+
7 verbose argv "/usr/bin/node" "/usr/local/bin/npm" "start"
8 verbose node v10.19.0
9 verbose npm  v6.14.7
10 error missing script: start
11 verbose exit [ 1, true ]

@Mykle1 thanks to you and @sdetweil for helping me with this. It’s much appreciated. Deep down I’m reluctant to give up, because I don’t like quitting. I’ve literally just copied your config entry, and simply adding my own lat/lon figures. But now the MagicMirror shows up as a blank black screen and the window is named ‘Electron’, rather than ‘MagicMirror2’.

I’m checking, double-checking and triple-checking and I can’t see where the discrepancy is compared to your entry. Could having too many modules be an issue? Can I also check - both of you have commented that the ‘timezone’ is causing an error, but your config entry doesn’t show that it’s commented out…?

@sdetweil - thanks! Unfortunately, still no luck on adding // at the start of the line, or after ‘timezone:’. According to the module creator, the timezone is a required field. I went to the php website that the module creator refers to, but it just doesn’t make sense to me - the coding information on that website is vast and much too advanced for me. I may have to abandon my desire to add this particular module. :-(

@sdetweil. Thanks, Sam. That’s helpful to explain the general rules.

I’ve made a slight amendment - I figured that the timezone parameters was not correctly entered (see below - this time just showing the modules before and after). To answer your last point, I did remove the lat/lon values to hide my exact location (this time I’ve put in made-up numbers). With the slight amendment to the code, it’s still not working - do you think it’s the ‘timezone’ value that is causing the problem? I’ve not made any changes to the other modules.

{
			module: "weatherforecast",
			position: "top_right",
			header: "Weather Forecast",
			config: {
				location: "London",
				locationID: "2643743", //ID from http://bulk.openweathermap.org/sample/city.list.json.gz; unzip the gz file and find your city
				appid: "1ab234c567defgh89012ij34k56l78mn"
			}
		},
		{
			module: 'MMM-PrayerTime',
			position: 'top_left',	// This can be any of the regions. Best result is in the top_left/top_right.
			config: {
				apiVersion: '1.0', // please, leave unchanged. reserved for future use.
				lat: 12.3456789, // latitude of your position (city)
				lon: -0.1234567, // longitude of your position (city)
				timezone: date_default_timezone_set('Europe/London'), // please refer to http://php.net/manual/en/timezones.php
				timeFormat: 24,
				method: 5,
				playAdzan: ['fajr', 'dhuhr', 'asr', 'maghrib', 'isha'],
				notDisplayed: ['midnight', 'sunset'],
				useUpdateInterval: true,
				updateInterval: 86400 * 1000, // How often do you want to fetch new praying time? (milliseconds)
				animationSpeed: 2.5 * 1000, // Speed of the update animation. (milliseconds)
				language: config.language,
				showAdzanAlert: true,
				showTomorrow: true,
				vertical: true, // set false for horizontal view
				alertTimer: 15000
			}
		},
		{
			module: "newsfeed",
			position: "bottom_bar",
			config: {
				feeds: [
					{
						title: "New York Times",
						url: "https://rss.nytimes.com/services/xml/rss/nyt/HomePage.xml"
					},
					{
						title: "BBC World News",
						url: "http://feeds.bbci.co.uk/news/world/rss.xml"
					},
					{
						title: "Reddit",
						url: "https://www.reddit.com/r/worldnews/.rss"
					},
					{
						title: "Buzzfeed",
						url: "https://www.buzzfeed.com/world.xml"
					},
					{
						title: "Al Jazeera",
						url: "http://www.aljazeera.com/xml/rss/all.xml"
					}