[Default clock] Incorrect week number

[p1lspeda]

Hi,
I was just playing around with my MagicMirror config and edited my default clock config to include the current week.

                {
                        module: "clock",
                        position: "top_right",
                        config: {
                                showWeek: true,
                        },
                },

There seems to be a small bug, because according to the other calendar and my Outlook calendar, we are currently in week 42 and not in week 43.

Not a big issue, but still an issue

[sdetweil]

@p1lspeda where are you located

in the US the week number is calculated differently then the rest of the world.

[thgmirror]

@sdetweil That is a good answer:-)

I’m from Germany and my mirror shows 42, the answer to all questions.

[sdetweil]

@thgmirror where is your system timezone set?

u can also set language and timezone in the clock config. I don’t know which influences the moment() library more

[thgmirror]

@sdetweil it is set to Berlin = CEST

and my clock-config-entry is like this:

//#################################################################################
		{
			disabled: false,
			module: "clock",
			position: "top_right",
			config: {
				// The config property is optional.
				// See "Configuration options" for more information.
				showWeek      : true,
				showSunTimes  : true,
				showMoonTimes : true,
				lat           : 50.658821,
				lon           : 7.193084,
				}
		},
//#################################################################################

[sdetweil]

@thgmirror is your MM running in English or German? I see the code set moment from the language set in config.js

[thgmirror]

@sdetweil said in [Default clock] Incorrect week number:

I see the code set moment from the language set in config.js

DE

[sdetweil]

@p1lspeda let’s try this

edit clock.js

and change line 248

from ending like this

weekNumber: now.week() });

to this

weekNumber: now.isoWeek() });

[thgmirror]

@sdetweil Hey…I have no issue:-) it is @p1lspeda

[sdetweil]

@thgmirror sorry, didn’t see u sneak a post in there. fixed

[thgmirror]

@sdetweil I just wanted to help @p1lspeda and to give a working example.

[sdetweil]

@thgmirror very nice
I just didn’t look at the poster name. my fault.

[BKeyport]

Wait, Clock still uses Moment? Shame… Shame… 🤣🤣

[sdetweil]

@BKeyport ‘still’?! you think someone is ACTIVELY rewriting everything… ha ha ha