electron-rebuild problems with MagicMirror 2.22.0

[KristjanESPERANTO]

@wishmaster270 Okay, thanks for the explanation! I haven’t been able to read that anywhere in such clear words and I haven’t dealt with the past problems. Then I withdraw my recommendation because I lack the overview.

[sdetweil]

@KristjanESPERANTO ah I see

haven’t heard of @electron/rebuild

[karsten13]

@wishmaster270 said in electron-rebuild problems with MagicMirror 2.22.0:

So the right way is to install electron-rebuild in the same project as electron and call it from there.

installing module stuff in the node_modules folder of mm is a hack and will not work out of the box with a docker setup because this folder is only in the container (you have to map it on the host to get changes there persistent)

It might be worth to think about adding it as a dependency in the main project.

in this case may the best solution

[sdetweil]

@karsten13 yes, that’s what I think we come to but doesn’t help any existing broken modules

[sdetweil]

@karsten13 docker is a pita with this stuff. too much/not enough in the container. which is supposed to be immutable.

[KristjanESPERANTO]

@sdetweil As a soft step, the broken modules could switch to @electron/rebuild. This should also work for docker.

[wishmaster270]

@KristjanESPERANTO

I have a docker installation running for development here on my notebook.
Everytime a module needs “npm install” I exec to the container and run the command in the container cause there will be called the correct npm and node version in the container and not the ones I currently use on my notebook.
In this case the directory structure is the same as with a locally installed MagicMirror and the postinstall script will work as excepted.

[karsten13]

@wishmaster270 said in electron-rebuild problems with MagicMirror 2.22.0:

and the postinstall script will work as excepted.

yes, will work, but all the changes in the node_modules folder of mm are gone with the next restart of the container …

[wishmaster270]

@karsten13
In case of electron-rebuild this is no problem as it is only required during compile but not at runtime.

[karsten13]

@wishmaster270

o.k., but where are the compile results stored?

[wishmaster270]

@karsten13
They are stored in the node_modules folder of the module which should be persistent

Edit: Do not misunderstand me. In my opinion the best way to solve the electron-rebuild problems of a lot of modules would be to put “@electron/rebuild” as a dependency to “package.json” of MagicMirror.

[karsten13]

@wishmaster270 said in electron-rebuild problems with MagicMirror 2.22.0:

@karsten13
They are stored in the node_modules folder of the module which should be persistent

thats good, so the construction with installing electron-rebuild in mm folder has no side effects and works also in a docker setup.

[karsten13]

@wishmaster270 said in electron-rebuild problems with MagicMirror 2.22.0:

Edit: Do not misunderstand me. In my opinion the best way to solve the electron-rebuild problems of a lot of modules would be to put “@electron/rebuild” as a dependency to “package.json” of MagicMirror.

I don’t have a final opinion on that yet, but if so, we should put it under optionalDependencies as electron

[wishmaster270]

@karsten13

You are right. I think optionalDependencies would be a great solution. Module developers could then add a hint to run npm ci in the MagicMirror directory to their installations instructions.

As the container it self is untouched it should be no problem. It only causes @electron/rebuild to be installed the next time the script is called.

[sdetweil]

@KristjanESPERANTO but if u look at electron/rebuild after install u call electron-rebuild

still has to be installed in the base node_modules folder…

older unmaintained modules are broken either way. why I had to fork MMM-Buttons.

[sdetweil]

@wishmaster270 optional is there so that IF electron is NOT installed, the install does not fail (needed on pi0w at least)
have nothing to do w ci

my script ONLY installs prod, no dev. as 99.5% of users are users not mm developers. has nothing to do w module developers

[sdetweil]

@karsten13 and the postinstall checks for it being there, and if so skips the e-r install.

doesn’t know/care HOW it got installed before

[karsten13]

@sdetweil

you can use --omit=optional as param for npm install, I use this for my amd64 images because they are run to 99,9% with npm run server so electron is not needed

[thobach]

@karsten13 What are your thoughts on adding npm install @electron/rebuild --unsafe-perm; \ as part of the container image creation process to https://gitlab.com/khassel/magicmirror/-/blob/master/build/Dockerfile-debian?

[karsten13]

@thobach

I’m trying to keep image size small … but which image are you using? latest or fat?