MagicMirror Forum
    • Recent
    • Tags
    • Unsolved
    • Solved
    • MagicMirror² Repository
    • Documentation
    • 3rd-Party-Modules
    • Donate
    • Discord
    • Register
    • Login
    A New Chapter for MagicMirror: The Community Takes the Lead
    Read the statement by Michael Teeuw here.

    calendar - wrong repeating count when using sliceMultiDayEvents

    Scheduled Pinned Locked Moved Solved Troubleshooting
    17 Posts 2 Posters 1.6k Views 2 Watching
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • M Offline
      MarcLandis Module Developer @sdetweil
      last edited by MarcLandis

      @sdetweil this fixes it. The test calendar looks good and my real one with the birthdays (mostly affected one) is perfect. All other events are good too.

      Thx for your help.

      S 1 Reply Last reply Reply Quote 0
      • S Offline
        sdetweil @MarcLandis
        last edited by

        @MarcLandis i’ll submit an issue and a pr…

        and a testcase

        Sam

        How to add modules

        learning how to use browser developers window for css changes

        S 1 Reply Last reply Reply Quote 1
        • S Offline
          sdetweil @sdetweil
          last edited by

          @MarcLandis
          submitted PR https://github.com/MagicMirrorOrg/MagicMirror/pull/3543/
          with new testcase to validate

          hopefully we will get it into next release Oct 1.

          Sam

          How to add modules

          learning how to use browser developers window for css changes

          M 1 Reply Last reply Reply Quote 0
          • M Offline
            MarcLandis Module Developer @sdetweil
            last edited by

            @sdetweil Thank you - even it doesn’t make it into the next release I have a way to manually fix it now.

            S 1 Reply Last reply Reply Quote 0
            • M MarcLandis has marked this topic as solved on
            • S Offline
              sdetweil @MarcLandis
              last edited by

              @MarcLandis the fix was accepted and merged

              Sam

              How to add modules

              learning how to use browser developers window for css changes

              S 1 Reply Last reply Reply Quote 1
              • S Offline
                sdetweil @sdetweil
                last edited by

                @MarcLandis you could test it now by
                https://forum.magicmirror.builders/topic/14327/testing-new-fixes-or-solving-current

                remember to do (to get release level dependencies)

                npm run install-mm
                

                assuming the config in this MM is set correctly for sliceMultiDayEvents

                Sam

                How to add modules

                learning how to use browser developers window for css changes

                M 1 Reply Last reply Reply Quote 0
                • M Offline
                  MarcLandis Module Developer @sdetweil
                  last edited by MarcLandis

                  @sdetweil I was on a business trip the last days.

                  I noticed that multi fullday events will be shown one day in the past:

                  66765aea-2266-4ddd-9af1-a5d21fa8f36b-image.png

                  This is from today (20. Sep)

                  I don’t have the config to show past days enables.

                  S 1 Reply Last reply Reply Quote 0
                  • S Offline
                    sdetweil @MarcLandis
                    last edited by sdetweil

                    @MarcLandis hm, same calendar entries ?

                    is this on the edited calendar.js or the develop branch?

                    im on a trip til tuesday

                    Sam

                    How to add modules

                    learning how to use browser developers window for css changes

                    M 1 Reply Last reply Reply Quote 0
                    • M Offline
                      MarcLandis Module Developer @sdetweil
                      last edited by

                      @sdetweil I am going to debug this. The ics was slightly modified, when I noticed the bug.

                      M S 2 Replies Last reply Reply Quote 0
                      • M Offline
                        MarcLandis Module Developer @MarcLandis
                        last edited by MarcLandis

                        @sdetweil I found the reason and created a pull request

                        1 Reply Last reply Reply Quote 0
                        • 1
                        • 2
                        • 2 / 2
                        • First post
                          Last post
                        Enjoying MagicMirror? Please consider a donation!
                        MagicMirror created by Michael Teeuw.
                        Forum managed by Sam, technical setup by Karsten.
                        This forum is using NodeBB as its core | Contributors
                        Contact | Privacy Policy