MagicMirror Forum
    • Recent
    • Tags
    • Unsolved
    • Solved
    • MagicMirror² Repository
    • Documentation
    • 3rd-Party-Modules
    • Donate
    • Discord
    • Register
    • Login
    A New Chapter for MagicMirror: The Community Takes the Lead
    Read the statement by Michael Teeuw here.

    Contributing to a GitHub repository - a bit stuck

    Scheduled Pinned Locked Moved Solved Troubleshooting
    9 Posts 3 Posters 648 Views 3 Watching
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • evroomE Offline
      evroom @sdetweil
      last edited by

      @sdetweil

      Great!

      Then a final question:

      In short:

      I program using in VS Code and here is Source Control active.
      Can I use the GitHub CLI and the Visual Studio Code like together, or will they bite each other ?

      A bit longer, with an example:

      I have edited HoymilesWifi.sh in VS Code.
      On my machine, I see:

      % git status
      On branch evroom
      Your branch is up to date with 'origin/evroom'.
      
      Changes not staged for commit:
        (use "git add <file>..." to update what will be committed)
        (use "git restore <file>..." to discard changes in working directory)
      	modified:   HoymilesWifi.sh
      
      no changes added to commit (use "git add" and/or "git commit -a")
      

      On VS Code I see:

      V Commit
      
      Changes
      
      $ HoymilesWifi.sh
      

      Can I Commit it from within VS Code, or is it safer to use the GitHub CLI as I have done for the README.md file previously ?

      MagicMirror version: 2.33.0
      Raspberry Pi 4 Model B Rev 1.5 (8 GB RAM)
      Raspbian GNU/Linux 12 (bookworm)

      Test environment:
      MagicMirror version: v2.31.0
      Raspberry Pi 3 Model B Plus Rev 1.3 (1 GB RAM)
      Raspbian GNU/Linux 12 (bookworm)

      S mumblebajM 2 Replies Last reply Reply Quote 0
      • S Offline
        sdetweil @evroom
        last edited by

        @evroom you can use VSCode to do the commit and push…

        I have not moved myself to that part of VSCode… (or let any IDE handle my commits etc)

        Sam

        How to add modules

        learning how to use browser developers window for css changes

        1 Reply Last reply Reply Quote 0
        • mumblebajM Offline
          mumblebaj Module Developer @evroom
          last edited by

          @evroom Just launch a terminal in VsCode

          3fd31556-0ab9-43eb-926c-5eb33ee36d1c-image.png

          Make sure it is set to bash.
          62ee6f27-3f99-446c-b9fb-693c2f9285f6-image.png

          Then you can run the same commands git add and git commit -m "your commit text" and git push from the terminal.

          Check out my modules at: https://github.com/mumblebaj?tab=repositories
          Check my blog-post: https://mumblebaj.xyz/

          S evroomE 2 Replies Last reply Reply Quote 1
          • S Offline
            sdetweil @mumblebaj
            last edited by

            @mumblebaj yes, was trying not to add too much extra as there is already a terminal window open for running MM with the modified module

            Sam

            How to add modules

            learning how to use browser developers window for css changes

            1 Reply Last reply Reply Quote 1
            • evroomE Offline
              evroom @mumblebaj
              last edited by

              @mumblebaj said in Contributing to a GitHub repository - a bit stuck:

              Make sure it is set to bash.

              It is set to zsh.
              No issue to change it to bash, but is there a reasoning behind it ?

              Stupidly enough I had this Terminal open the whole time.

              I just did ‘Commit’ from within VS Code and then did ‘Sync Changes’.

              Result:

              % git status
              On branch evroom
              Your branch is up to date with 'origin/evroom'.
              
              nothing to commit, working tree clean
              

              So that works just fine.

              I also made a change using the Terminal and then did the add and commit from the Terminal.
              In the Source Control pane you can see what you do on the command line in real time.

              MagicMirror version: 2.33.0
              Raspberry Pi 4 Model B Rev 1.5 (8 GB RAM)
              Raspbian GNU/Linux 12 (bookworm)

              Test environment:
              MagicMirror version: v2.31.0
              Raspberry Pi 3 Model B Plus Rev 1.3 (1 GB RAM)
              Raspbian GNU/Linux 12 (bookworm)

              1 Reply Last reply Reply Quote 1
              • evroomE evroom has marked this topic as solved on
              • 1 / 1
              • First post
                Last post
              Enjoying MagicMirror? Please consider a donation!
              MagicMirror created by Michael Teeuw.
              Forum managed by Sam, technical setup by Karsten.
              This forum is using NodeBB as its core | Contributors
              Contact | Privacy Policy