MMM-EmbedURL with MMM-Pages - Website reload....

sdetweil

@BKeyport embedurl doesn’t support the show/hide functions so it COULD be loading at the time it is shown

It should pause while hidden, resume when shown

How long does the page take to load?

BKeyport

It shows, then resets, takes 2-3 seconds to show back up, then runs normally. The problem is that it’s just annoying to have it flash in and then blank, then come up and run.

sdetweil

@BKeyport not sure @wishmaster270 got any ideas?

Looks like you are creating new elements on each getDom(). the resume () will cause a getDom() which will cause the page reload in the new iframe object

wishmaster270

@sdetweil Hi, the module calls the updateDom function every time it gets resumed in the current implementation.

I am not sure if I can implemt a block option to skip the update dom but reset the timer for the regular updates.

sdetweil

@wishmaster270 you could make the content you return fixed …

getDom(){
    if(!this.already_created){
       build content
       this.already_created=new content
    }
    return this.already_created 
}

I do this in a few modules to reduce/eliminate the flash

nothing says you HAVE to CREATE the content on each getDom()
just have to return something

so minor change… no logic change

wishmaster270

@sdetweil
Hi Sam,

you are right. But i do not want the content to be fixed as some users want the content to be recreated after the configured interval.

I just released a new version 0.0.8 of the module which introduces a updateDomOnShow option. If the option is set to false the module uses the old html elements after a resume. Maybe this fixes the issue.

sdetweil

@wishmaster270 thanks… I didn’t know if the iframe would reload itself on show

@BKeyport give this a try

BKeyport

Tom, is it updateDomOnShow or updateDomOnResume ?

Documentation shows the latter.

BKeyport

I put them both in, and that fixed it - thanks, Tom.

wishmaster270

@BKeyport Sorry, to one I’m the documentation is the correct one.

Great to hear it is working.