Getting LED Strip on in conjunction with MMM-Pir

rkorell

Sounds plausible but doesn’t work :-(
I can reference this.config.ScreenStatus in the TriggerPayloadFilter.
But when I do this, the fire isn’t working (no notification broadcast appears).
In addition referencing of this.config.ScreenStatus in the fire block causes an error “Cannot read properties of undefined (reading ‘ScreenStatus’)”…
Any direct reference in the fire block in an IF statement creates an "unecpected ‘this’ " error message …

you can see my dumb trials commented in this snippet:

		{
		  module: 'MMM-NotificationTrigger',
		  disabled: false,
		  
		  config: {
		    ScreenStatus:"INIT",

		    useWebhook: false, // If you want to activate webhook as Notification emitter, set true. (eg. IFTTT)
		    triggers:[ // Array of triggers.
		      {
		        trigger: "MMM_PIR-SCREEN_POWERSTATUS", //REQUIRED
		        triggerPayloadFilter: (payload) => { //OPTIONAL should return true or false
		          if (payload.value == 'true' ) {
		            //this.config.ScreenStatus = "on"
		            return true
		          }
		          //this.config.ScreenStatus = "off"
		            return true
		        },
		        fires: [ // Array of fires. You can enable multi-firing with one trigger.
		          {
			         /* if (this.config.ScreenStatus == 'on') {
            		  	fire: "SCREEN_IS_ON",
          			  	} else {
            			fire: "SCREEN_IS_OFF",
          			  }*/
          			//fire: this.config.ScreenStatus,
          			fire: "BROADCAST",

		          },
		        ],
		      },
		    ]
		  },
		},

I’m SO sorry…
Ralf

sdetweil

@rkorell yeh, sorry, didn’t give this enough viewing/thinking time…

the fires section doesn’t support code, its all literals.
I don’t know if you can attach a function (which returns the literal) to it

     fires: ()=>{  if (this.config.ScreenStatus == 'on') 
                                     return "BROADCAST";
                               else return "?????"

rkorell

@sdetweil Yes, sounds like a brillant idea.
But if I assign a value to this.config.ScreenStatus within the trigerPayloadFilter section the fire section isn’t working - so your thought is great but I cannot try this …

Any idea why the fire section is skipped?

THANKS for your effort!!
Ralf

sdetweil

@rkorell well, skipped…

because the code it looking for a literal, and the function is not…
the NotificationsTrigger module will have to be changed

rkorell

@sdetweil O.K.,
if I have to change modules, I can do this at the “root” - which is the MMM-Pir …
I will at least have a closer look to the MMM-Notification module - maybe a good starting point to develop a completely new (forked) module…

Thanks for your engagement anyway!

Warm regards,
Ralf

sdetweil

@rkorell ok, its a tiny change to Trigger module…

rkorell

@sdetweil from your perspective :-)
Just had a deeper look into code and I didn’t understand that much…