Bugsounet and MMM-Pir

[sdetweil]

@lif module rules

module name (exact case) = folder name in modules folder
MUST contain at minimum a file name that matches(exact case) of the modulename.js

AND inside that file it MUST contain a module.register(name…)
where name MUST match (exact case) the module name

[rkorell]

@lif said in Bugsounet and MMM-Pir:

It’s correct, there isn’t a MMM-Pir.js file in the MMM-Pir directory

If you had cloned this repository from @coernel - the MMM-pir.js is missing.
This must be an error.

Nevertheless: I’ve played around with the original version from bugsounet and figured out that editing his “origin” MM-Pir.js was really hard because he has deleted all linefeeds.
Seeking around I found an editable clone of the *.js files (including node_helper) in the src folder of the repository.
This is true for the new clone from coernel …
give it a try :-)

Regards,
Ralf

[sdetweil]

@rkorell said in Bugsounet and MMM-Pir:

Nevertheless: I’ve played around with the original version from bugsounet and figured out that editing his “origin” MM-Pir.js was really hard because he has deleted all linefeeds.

called minified

[rkorell]

@sdetweil said in Bugsounet and MMM-Pir:

called minified

:-) never seen this before…
Called minified - for good reasons …

[sdetweil]

@rkorell said in Bugsounet and MMM-Pir:

Called minified - for good reasons …

On a production web site with 1000000’s of file loads, minified can reduce response times…

otherwise it is a hiding technique, which can(has) hidden hacker attacks on client systems…(loading files, sending credentials…)
hard to examine code

[rkorell]

@sdetweil said in Bugsounet and MMM-Pir:

hard to examine code

Yes, I guess this was bugsounet’s intention - irritating beginners :-)

The code has 247 lines so you avoid 247 CR’s - not THAT much more efficient, I think - but on 100eds of 1000nds of files - may be …

Ralf

[sdetweil]

@rkorell he did not do it for performance

[rkorell]

@sdetweil I agree :-)

[rkorell]

@rkorell said in Bugsounet and MMM-Pir:

in the src folder of the repository

@lif , @coernel :
there are several files missing in coernels upload.
I’ve just checked source code in MMM-Pir.js …

      "/modules/MMM-Pir/components/screenDisplayer.js",
      "/modules/MMM-Pir/components/screenTouch.js",
      "/modules/MMM-Pir/node_modules/long-press-event/dist/long-press-event.min.js",
      "/modules/MMM-Pir/node_modules/progressbar.js/dist/progressbar.min.js",
      "/modules/MMM-Pir/components/motion.js",
      "/modules/MMM-Pir/components/motionLib.js"

The complete folder MMM-Pir/node_modules is missing.
The folder MMM-Pir/components/ contains only the python script for PIR communication, none of the above *.js files.

At least the /components/*.js files are present in the components folder of MMM-Pir/src …

But this seems to be a frickling job to get this done.
I guess a complete upload of an original MMM-Pir installation would be the better way.

What do you think?

Regards,
Ralf

[sdetweil]

@rkorell because they are in node_modules they were dependencies , not part of the actual module…