Bugsounet and MMM-Pir

[sdetweil]

@rkorell said in Bugsounet and MMM-Pir:

Nevertheless: I’ve played around with the original version from bugsounet and figured out that editing his “origin” MM-Pir.js was really hard because he has deleted all linefeeds.

called minified

[rkorell]

@sdetweil said in Bugsounet and MMM-Pir:

called minified

:-) never seen this before…
Called minified - for good reasons …

[sdetweil]

@rkorell said in Bugsounet and MMM-Pir:

Called minified - for good reasons …

On a production web site with 1000000’s of file loads, minified can reduce response times…

otherwise it is a hiding technique, which can(has) hidden hacker attacks on client systems…(loading files, sending credentials…)
hard to examine code

[rkorell]

@sdetweil said in Bugsounet and MMM-Pir:

hard to examine code

Yes, I guess this was bugsounet’s intention - irritating beginners :-)

The code has 247 lines so you avoid 247 CR’s - not THAT much more efficient, I think - but on 100eds of 1000nds of files - may be …

Ralf

[sdetweil]

@rkorell he did not do it for performance

[rkorell]

@sdetweil I agree :-)

[rkorell]

@rkorell said in Bugsounet and MMM-Pir:

in the src folder of the repository

@lif , @coernel :
there are several files missing in coernels upload.
I’ve just checked source code in MMM-Pir.js …

      "/modules/MMM-Pir/components/screenDisplayer.js",
      "/modules/MMM-Pir/components/screenTouch.js",
      "/modules/MMM-Pir/node_modules/long-press-event/dist/long-press-event.min.js",
      "/modules/MMM-Pir/node_modules/progressbar.js/dist/progressbar.min.js",
      "/modules/MMM-Pir/components/motion.js",
      "/modules/MMM-Pir/components/motionLib.js"

The complete folder MMM-Pir/node_modules is missing.
The folder MMM-Pir/components/ contains only the python script for PIR communication, none of the above *.js files.

At least the /components/*.js files are present in the components folder of MMM-Pir/src …

But this seems to be a frickling job to get this done.
I guess a complete upload of an original MMM-Pir installation would be the better way.

What do you think?

Regards,
Ralf

[sdetweil]

@rkorell because they are in node_modules they were dependencies , not part of the actual module…

[rkorell]

@sdetweil said in Bugsounet and MMM-Pir:

not part of the actual module…

As far as I understood @coernel tried to re-upload bugsounet’s MMM-Pir.
And this modules uses all of these dependencies.
And the original MMM-Pir.js from bugsounet is missing as well in coernel’s re-upload, so it will never work - which is, what @lif has experienced …
So my above suggestion was - if it is intended to have a working copy of bugsounet’s module - to re-investigate the re-uploaded version because there is missing a lot - as mentioned even the core *.js file in the root of the module…

If useful for anybody I’ve created a complete copy of my own working module-directory and uploaded it here for your attention/action.
Please ignore some additional files which I have kept as copies of the original files I had modified.

Hope this is clearer now :-)

Regards,
Ralf

[sdetweil]

@rkorell yes, i posted a warning early after he left to save what you could, without knowing the details of such work effort