MMM-MealViewer

ewingfox

I love this (and more importantly, my WIFE and kiddos love this module - GREAT WORK!

My wife does meal planning, shopping and tasks me with meal prep for the upcoming week on the weekends, so she really wants to see the next week’s school lunches on Friday evening when she’s in the fridge and going through what we have, and what meals my kiddo wants to eat at school and which meals they want to pack a lunch for.

Currently, the getDateRange function (which is super robust, excellent work) is strictly ‘look back’. I did quite a bit of testing (thank you for baking in all the testing and logging logic!!!) and my testing shows that you can maintain all of the robustness and add the ‘look ahead’ my wife is looking for by updating the function just a bit like:

getDateRange: function (startDay, endDay, testMode = false, testDate = null) {
    let today;

    if (testMode && testDate) {
        const [year, month, day] = testDate.split('-').map(Number);
        today = new Date(year, month - 1, day);
        console.log(`Using test date (local timezone): ${today.toLocaleString()}`);
    } else {
        today = new Date();
    }

    const currentDay = today.getDay();
    console.log(`Current day of week: ${currentDay}`);

    // ------------------------------------------------------------
    // Calculate the date for the week's start (most recent startDay)
    // ------------------------------------------------------------
    const startDate = new Date(today);
    const daysToSubtract = ((currentDay - startDay + 7) % 7);
    startDate.setDate(today.getDate() - daysToSubtract);

    console.log(`Days to subtract: ${daysToSubtract}`);
    console.log(`Initial start date: ${startDate.toLocaleString()}`);

    // ------------------------------------------------------------
    // Calculate the end date (inclusive range)
    // ------------------------------------------------------------
    const endDate = new Date(startDate);
    const daysInRange = (endDay - startDay + 7) % 7 + 1;
    endDate.setDate(startDate.getDate() + daysInRange - 1);

    // ------------------------------------------------------------
    // LOOK-AHEAD LOGIC
    // If today is on or after the trigger day (Friday for Mon–Fri),
    // shift the entire range forward by one week
    // ------------------------------------------------------------
    const lookAheadTriggerDay = (startDay + 4) % 7;

    if (currentDay >= lookAheadTriggerDay) {
        console.log("Look-ahead condition met — shifting range to next week");
        startDate.setDate(startDate.getDate() + 7);
        endDate.setDate(endDate.getDate() + 7);
    }

    console.log(`Final start date: ${startDate.toLocaleString()}`);
    console.log(`Final end date: ${endDate.toLocaleString()}`);

    // ------------------------------------------------------------
    // Format output
    // ------------------------------------------------------------
    const formatDate = (date) => {
        const year = date.getFullYear();
        const month = String(date.getMonth() + 1).padStart(2, '0');
        const day = String(date.getDate()).padStart(2, '0');
        return `${month}-${day}-${year}`;
    };

    return {
        start: formatDate(startDate),
        end: formatDate(endDate)
    };
},

sdetweil

@ewingfox in this open source world the way to approach this is to submit your update as a pull request to the original module

Then the author doesn’t have to spend time inventing the changes, only reviewing your work

So, on GitHub
Fork the module, now you have a linked copy
git clone your copy, same as you did the original (only one in a place at a time)
Update your copy
git add your changes
git commit your changes to your local copy of the repo
git push. To upload your copy to GitHub, updating your fork
Use GitHub to submit/contribute your changes to the original module,

ewingfox

@sdetweil as usual - you are very correct lol - this was sheer laziness on my part!

ewingfox

@sdetweil - At work, all of my criteria and commentary lives in jira and my PR’s are pretty lean [read: RTSIDXCMT-11142, accept my d**n PR if you want that bug fix] .

I’d appreciate any feedback on manners/standards for submitting PR to open source projects so I can better align with norms!

https://github.com/ElliAndDad/MMM-MealViewer/pull/4

Thank you for being such an active mod/admin/mentor!

Take care,

E

sdetweil

@ewingfox one of the banes of open source is every author has their own style. So a PR here is different than a PR there.