Read the statement by Michael Teeuw here.
MMM-MealViewer
-
@ewingfox in this open source world the way to approach this is to submit your update as a pull request to the original module
Then the author doesn’t have to spend time inventing the changes, only reviewing your work
So, on GitHub
Fork the module, now you have a linked copy
git clone your copy, same as you did the original (only one in a place at a time)
Update your copy
git add your changes
git commit your changes to your local copy of the repo
git push. To upload your copy to GitHub, updating your fork
Use GitHub to submit/contribute your changes to the original module, -
@sdetweil as usual - you are very correct lol - this was sheer laziness on my part!
<instinctively ducks to see if my DevOps lead is hurling a pot in my direction, remembers that she’s 7,600 miles away, ducks again anyway>
-
@sdetweil - At work, all of my criteria and commentary lives in jira and my PR’s are pretty lean [read: RTSIDXCMT-11142, accept my d**n PR if you want that bug fix] .
I’d appreciate any feedback on manners/standards for submitting PR to open source projects so I can better align with norms!
https://github.com/ElliAndDad/MMM-MealViewer/pull/4
Thank you for being such an active mod/admin/mentor!
Take care,
E
-
@ewingfox one of the banes of open source is every author has their own style. So a PR here is different than a PR there.
-
Hey everyone! Just released v1.1.0 with some nice updates:
New Features:
- Responsive scaling - module automatically adapts to fit any region width
- Multi-column layout for full-width positions (top_bar, bottom_bar, upper_third, etc.)
- Position-aware styling - right-aligned headers when placed in right positions
Fixes:
- Fixed lookAhead logic to properly trigger on endDay after hideTodayAfter time
Improvements:
- Removed axios dependency - zero runtime dependencies now, just clone and go!
- Added ESLint config and dependabot for better code quality
Screenshots of the new layouts in the README:
https://github.com/ElliAndDad/MMM-MealViewerLet me know if you run into any issues!
