MagicMirror Forum
    • Recent
    • Tags
    • Unsolved
    • Solved
    • MagicMirror² Repository
    • Documentation
    • 3rd-Party-Modules
    • Donate
    • Discord
    • Register
    • Login
    A New Chapter for MagicMirror: The Community Takes the Lead
    Read the statement by Michael Teeuw here.

    MMM-MealViewer

    Scheduled Pinned Locked Moved Utilities
    11 Posts 5 Posters 1.1k Views 4 Watching
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • S Offline
      sdetweil @ewingfox
      last edited by

      @ewingfox in this open source world the way to approach this is to submit your update as a pull request to the original module

      Then the author doesn’t have to spend time inventing the changes, only reviewing your work

      So, on GitHub
      Fork the module, now you have a linked copy
      git clone your copy, same as you did the original (only one in a place at a time)
      Update your copy
      git add your changes
      git commit your changes to your local copy of the repo
      git push. To upload your copy to GitHub, updating your fork
      Use GitHub to submit/contribute your changes to the original module,

      Sam

      How to add modules

      learning how to use browser developers window for css changes

      E 1 Reply Last reply Reply Quote 2
      • E Offline
        ewingfox @sdetweil
        last edited by

        @sdetweil as usual - you are very correct lol - this was sheer laziness on my part!

        <instinctively ducks to see if my DevOps lead is hurling a pot in my direction, remembers that she’s 7,600 miles away, ducks again anyway>

        1 Reply Last reply Reply Quote 0
        • E Offline
          ewingfox @ewingfox
          last edited by

          @sdetweil - At work, all of my criteria and commentary lives in jira and my PR’s are pretty lean [read: RTSIDXCMT-11142, accept my d**n PR if you want that bug fix] .

          I’d appreciate any feedback on manners/standards for submitting PR to open source projects so I can better align with norms!

          https://github.com/ElliAndDad/MMM-MealViewer/pull/4

          Thank you for being such an active mod/admin/mentor!

          Take care,

          E

          S 1 Reply Last reply Reply Quote 1
          • S Offline
            sdetweil @ewingfox
            last edited by

            @ewingfox one of the banes of open source is every author has their own style. So a PR here is different than a PR there.

            Sam

            How to add modules

            learning how to use browser developers window for css changes

            1 Reply Last reply Reply Quote 0
            • D Offline
              dadAndEl
              last edited by

              Hey everyone! Just released v1.1.0 with some nice updates:

              New Features:

              • Responsive scaling - module automatically adapts to fit any region width
              • Multi-column layout for full-width positions (top_bar, bottom_bar, upper_third, etc.)
              • Position-aware styling - right-aligned headers when placed in right positions

              Fixes:

              • Fixed lookAhead logic to properly trigger on endDay after hideTodayAfter time

              Improvements:

              • Removed axios dependency - zero runtime dependencies now, just clone and go!
              • Added ESLint config and dependabot for better code quality

              Screenshots of the new layouts in the README:
              https://github.com/ElliAndDad/MMM-MealViewer

              Let me know if you run into any issues!

              1 Reply Last reply Reply Quote 2
              • 1
              • 2
              • 2 / 2
              • First post
                Last post
              Enjoying MagicMirror? Please consider a donation!
              MagicMirror created by Michael Teeuw.
              Forum managed by Sam, technical setup by Karsten.
              This forum is using NodeBB as its core | Contributors
              Contact | Privacy Policy