• Recent
  • Tags
  • Unsolved
  • Solved
  • MagicMirror² Repository
  • Documentation
  • 3rd-Party-Modules
  • Donate
  • Discord
  • Register
  • Login
MagicMirror Forum
  • Recent
  • Tags
  • Unsolved
  • Solved
  • MagicMirror² Repository
  • Documentation
  • 3rd-Party-Modules
  • Donate
  • Discord
  • Register
  • Login
A New Chapter for MagicMirror: The Community Takes the Lead
Read the statement by Michael Teeuw here.

Is node_helper really required?

Scheduled Pinned Locked Moved Troubleshooting
4 Posts 2 Posters 2.0k Views 2 Watching
Loading More Posts
  • Oldest to Newest
  • Newest to Oldest
  • Most Votes
Reply
  • Reply as topic
Log in to reply
This topic has been deleted. Only users with topic management privileges can see it.
  • E Offline
    E3V3A
    last edited by E3V3A Feb 24, 2018, 12:32 PM Feb 22, 2018, 10:04 AM

    I see a lot of people putting: const NodeHelper = require("node_helper"); in their node_helper.js file. Is this right or even necessary?

    It doesn’t make much sense to state that a file require itself! And if it is referring to MM’s internal node_helper, then shouldn’t the MM core be made to recognize this by itself?

    I’m asking, because doing that, make your npm-check always complain about node_helper not being installed or missing.

    "Everything I do (here) is for free – altruism is the way!"
    MMM-FlightsAbove, MMM-Tabulator, MMM-Assistant (co-maintainer)

    1 Reply Last reply Reply Quote 0
    • E Offline
      E3V3A
      last edited by E3V3A Feb 23, 2018, 9:31 AM Feb 22, 2018, 1:08 PM

      It is not, and should not, AFAICT.

      "Everything I do (here) is for free – altruism is the way!"
      MMM-FlightsAbove, MMM-Tabulator, MMM-Assistant (co-maintainer)

      S 1 Reply Last reply Feb 22, 2018, 10:04 PM Reply Quote 0
      • S Offline
        strawberry 3.141 Project Sponsor Module Developer @E3V3A
        last edited by Feb 22, 2018, 10:04 PM

        @E3V3A that is not true.

        A node helper is not required for a module, but if a module has a nodehelper this statement required, because it imports this file into your node helper https://github.com/MichMich/MagicMirror/blob/master/modules/node_modules/node_helper/index.js

        Please create a github issue if you need help, so I can keep track

        E 1 Reply Last reply Feb 23, 2018, 10:19 AM Reply Quote 1
        • E Offline
          E3V3A @strawberry 3.141
          last edited by Feb 23, 2018, 10:19 AM

          @strawberry-3.141 Oh!? That is funny, because I removed it, and there is no change in anything, module ran fine without it. Perhaps because I’m not using most of the content from that file, while the rest is already defined?

          "Everything I do (here) is for free – altruism is the way!"
          MMM-FlightsAbove, MMM-Tabulator, MMM-Assistant (co-maintainer)

          1 Reply Last reply Reply Quote 0
          • 1 / 1
          1 / 1
          • First post
            4/4
            Last post
          Enjoying MagicMirror? Please consider a donation!
          MagicMirror created by Michael Teeuw.
          Forum managed by Sam, technical setup by Karsten.
          This forum is using NodeBB as its core | Contributors
          Contact | Privacy Policy