MMM-NetworkScanner-loading...indefinitely

[sdetweil]

@jthirasilpa oh, i see I should have removed the comment… you do not need to change any code…

but the error does not match the code u are running now…

please do

pm2 stop 0
pm2 flush
pm2 start 0
pm2 logs

that error must have been from yesterday

[jthirasilpa]

Hmm

So with the password entered only in the config file, the error output still references line 42

 var arpHosts = this.config.network || '-l';

Error output:

0|mm       | [19:37:36.956] [ERROR]  TypeError: Cannot read property 'network' of undefined
0|mm       |     at Class.scanNetworkMAC (/home/jojo/MagicMirror/modules/MMM-NetworkScanner/node_helper.js:42:36)
0|mm       |     at Class.socketNotificationReceived (/home/jojo/MagicMirror/modules/MMM-NetworkScanner/node_helper.js:30:18)
0|mm       |     at Socket.<anonymous> (/home/jojo/MagicMirror/js/node_helper.js:113:11)
0|mm       |     at Socket.emit (events.js:198:13)
0|mm       |     at /home/jojo/MagicMirror/node_modules/socket.io/lib/socket.js:528:12
0|mm       |     at process._tickCallback (internal/process/next_tick.js:61:11)

0|mm  | [19:37:50.982] [LOG]    MMM-NetworkScanner received SCAN_NETWORK
0|mm  | [19:37:50.983] [LOG]    MMM-NetworkScanner is performing arp-scan
0|mm  | [19:37:50.984] [LOG]    Whoops! There was an uncaught exception...
0|mm  | [19:37:50.984] [ERROR]
0|mm  | TypeError: Cannot read property 'network' of undefined
0|mm  |     at Class.scanNetworkMAC (/home/jojo/MagicMirror/modules/MMM-NetworkScanner/node_helper.js:42:36)
0|mm  |     at Class.socketNotificationReceived (/home/jojo/MagicMirror/modules/MMM-NetworkScanner/node_helper.js:30:18)
0|mm  |     at Socket.<anonymous> (/home/jojo/MagicMirror/js/node_helper.js:113:11)
0|mm  |     at Socket.emit (events.js:198:13)
0|mm  |     at /home/jojo/MagicMirror/node_modules/socket.io/lib/socket.js:528:12
0|mm  |     at process._tickCallback (internal/process/next_tick.js:61:11)
0|mm  | [19:37:50.985] [LOG]
0|mm  | MagicMirror will not quit, but it might be a good idea to check why this happened. Maybe no internet connection?
0|mm  | [19:37:50.986] [LOG]    If you think this really is an issue, please open an issue on GitHub: https://github.com/MichMich/MagicMirror/issues
0|mm  | [19:38:21.046] [LOG]
0|mm  | MMM-NetworkScanner received SCAN_NETWORK
0|mm  | [19:38:21.047] [LOG]
0|mm  | MMM-NetworkScanner is performing arp-scan
0|mm  | [19:38:21.048] [LOG]    Whoops! There was an uncaught exception...
0|mm  | [19:38:21.048] [ERROR]
0|mm  | TypeError: Cannot read property 'network' of undefined
0|mm  |     at Class.scanNetworkMAC (/home/jojo/MagicMirror/modules/MMM-NetworkScanner/node_helper.js:42:36)
0|mm  |     at Class.socketNotificationReceived (/home/jojo/MagicMirror/modules/MMM-NetworkScanner/node_helper.js:30:18)
0|mm  |     at Socket.<anonymous> (/home/jojo/MagicMirror/js/node_helper.js:113:11)
0|mm  |     at Socket.emit (events.js:198:13)
0|mm  |     at /home/jojo/MagicMirror/node_modules/socket.io/lib/socket.js:528:12
0|mm  |     at process._tickCallback (internal/process/next_tick.js:61:11)

[sdetweil]

@jthirasilpa said in MMM-NetworkScanner-loading...indefinitely:

0|mm | [19:37:36.956] [ERROR] TypeError: Cannot read property ‘network’ of undefined
0|mm | at Class.scanNetworkMAC (/home/jojo/MagicMirror/modules/MMM-NetworkScanner/node_helper.js:42:36)

Ok, but not ‘options’…

now, to check, this system is case sensitive… so in config.js it MUST look like this, right?

            keepAlive: 300,
            updateInterval: 5,
	    Password: 'pi'                        // added password (note capital P)
        }

using your password of course

[jthirasilpa]

That is how the config looks.

Still getting the node_helper line 42 error. Will park this for now. Thank you for spending so much time on this Sam - much appreciated. Will come back to this later in the week.

[sdetweil]

@jthirasilpa update the current code

cd ~MagicMirror/modules/MMM-NetworkScanner
git pull

then you can shutdown and restart the MM app

there was a tiny timing gap where the config info is not yet set, when the helper is asked to scan the network…

let me know

[OldSunGuy]

Is it bad to have this?

pi@raspberrypi ~ % sudo -l|grep NOPASS
    (ALL) NOPASSWD: ALL
pi@raspberrypi ~ %

Edit: To expand further, I have MMM-NetworkScanner running. I do not need to supply a password when I run sudo and I don’t have a password stored in a config file.

[jthirasilpa]

@sdetweil
Hi Sam - thanks I tried the update. Still getting the same error - from the log:

[19:00:49.868] [ERROR]  TypeError: Cannot read property 'network' of undefined
    at Class.scanNetworkMAC (/home/jojo/MagicMirror/modules/MMM-NetworkScanner/node_helper.js:42:36)
    at Class.socketNotificationReceived (/home/jojo/MagicMirror/modules/MMM-NetworkScanner/node_helper.js:30:18)
    at Socket.<anonymous> (/home/jojo/MagicMirror/js/node_helper.js:113:11)
    at Socket.emit (events.js:198:13)
    at /home/jojo/MagicMirror/node_modules/socket.io/lib/socket.js:528:12
    at process._tickCallback (internal/process/next_tick.js:61:11)

[sdetweil]

@jthirasilpa do another git pull from my repo… and try again

[jthirasilpa]

@sdetweil
Thanks Sam

Tried update. Error log below:

[11:45:29.130] [ERROR]  TypeError: Cannot read property 'network' of undefined
    at Class.scanNetworkMAC (/home/jojo/MagicMirror/modules/MMM-NetworkScanner/node_helper.js:46:36)
    at Class.socketNotificationReceived (/home/jojo/MagicMirror/modules/MMM-NetworkScanner/node_helper.js:33:18)
    at Socket.<anonymous> (/home/jojo/MagicMirror/js/node_helper.js:113:11)
    at Socket.emit (events.js:198:13)
    at /home/jojo/MagicMirror/node_modules/socket.io/lib/socket.js:528:12
    at process._tickCallback (internal/process/next_tick.js:61:11)

Node_helper code:

        // Target hosts/network supplied in config or entire localnet
 46         var arpHosts = self.config.network || '-l';
 47                                 var options = {
 48                                                 cachePassword: true,
 49                                                 prompt: 'Password,' + self.config.Password     // put your password where ???? are (notice the quotes around)
 50                                 }
 51         var arp = sudo(['arp-scan', '-q', arpHosts]) //, options);

Module entry in config.js:

                {
139                         module:                 "MMM-NetworkScanner",
140                         position:               "bottom_center",
141                         header:                 "Devices Online",
142                         config: {
143                                 devices: [
144                                 { ipAddress: "192.168.1.11", name: "Champagne", icon: "server"},
145                                 { ipAddress: "192.168.1.15", name: "Millie", icon: "server"},
146                                 { ipAddress: "192.168.1.17", name:  "Marmite", icon:  "server"}
147                                 ],
148                                 showUnknown: false,
149                                 showOffline:  true,
150                                 keepAlive:  600,
151                                 showLastSeen:  true,
152                                 updateInterval:  30,
153                                 Password:  'xxxx'
154                                 }
155                 },

[sdetweil]

@jthirasilpa weird…

the trace shows, on a timer tick (in the modulename.js) the node+helper received a socket message (sendSocketNotification from modulename.js), and received in node_helper)
the notification is correct, and it starts to rescan the network…

but, it has lost the config pointer for some reason…

weird…

please do another git pull

also add debug:true,

to the module config section

let me know

thanks