• Recent
  • Tags
  • Unsolved
  • Solved
  • MagicMirror² Repository
  • Documentation
  • 3rd-Party-Modules
  • Donate
  • Discord
  • Register
  • Login
MagicMirror Forum
  • Recent
  • Tags
  • Unsolved
  • Solved
  • MagicMirror² Repository
  • Documentation
  • 3rd-Party-Modules
  • Donate
  • Discord
  • Register
  • Login
A New Chapter for MagicMirror: The Community Takes the Lead
Read the statement by Michael Teeuw here.

How to keep secrets out of config.js (server only)

Scheduled Pinned Locked Moved Tutorials
11 Posts 4 Posters 3.6k Views 4 Watching
Loading More Posts
  • Oldest to Newest
  • Newest to Oldest
  • Most Votes
Reply
  • Reply as topic
Log in to reply
This topic has been deleted. Only users with topic management privileges can see it.
  • O Offline
    oscarb @sdetweil
    last edited by Mar 3, 2020, 8:31 PM

    @sdetweil I’m running Magic Mirror in server mode and I’ve tried what @joshwilsonvu suggested but can’t get that to work neither in Chrome latest version on my MacBook Pro or in Fully Kiosk Browser on my Android tablet behind my mirror as Chrome then complains require is not defined.

    Do you have any ideas on how to get that working when not running Magic Mirror as an electron app?

    S 1 Reply Last reply Mar 3, 2020, 9:01 PM Reply Quote 0
    • S Away
      sdetweil @oscarb
      last edited by Mar 3, 2020, 9:01 PM

      @oscarbhm. no, not at the moment… i modified run-start.sh in 2.10 to support split mode (where electron isn’t available), but never tried this on mac. the chrome browser executable name is probably incorrect…

      set serverOnly: “local”, in config.js to try it

      Sam

      How to add modules

      learning how to use browser developers window for css changes

      1 Reply Last reply Reply Quote 0
      • J Offline
        joshwilsonvu
        last edited by Mar 4, 2020, 6:01 PM

        You’re right, I forgot about the if (typeof module !== undefined) check. It might work if you set electronOptions: { nodeIntegration: true } in the config, but I haven’t tested it.

        B 1 Reply Last reply Mar 4, 2020, 8:25 PM Reply Quote 0
        • B Offline
          BKeyport Module Developer @joshwilsonvu
          last edited by Mar 4, 2020, 8:25 PM

          what does that line below the modules actually do out of curiousity?

          The "E" in "Javascript" stands for "Easy"

          S J 2 Replies Last reply Mar 5, 2020, 4:34 AM Reply Quote 0
          • S Away
            sdetweil @BKeyport
            last edited by Mar 5, 2020, 4:34 AM

            @BKeyport if this file is loaded into a module based application, then the interfacing approach (module.export) is created for this file/module…

            Sam

            How to add modules

            learning how to use browser developers window for css changes

            1 Reply Last reply Reply Quote 0
            • J Offline
              joshwilsonvu @BKeyport
              last edited by Mar 5, 2020, 2:09 PM

              @BKeyport Here’s a more detailed explanation for you and anyone who is curious.

              The if (typeof module !== "undefined") {} line checks if there is a global variable named module. If there is, then we must be using a module system and we have to export config using module.exports = config;. If not, then we must be in the browser and config will already be available to any other modules.

              In the browser, there is no concept of separate modules (a.k.a. files); script files are loaded in and simply concatenated one after the other. So if you load config.js and then another-file.js, the config variable (var config = { ... } ) will be available as a global variable in another-file.js. The module and require variables are not defined.

              In more modern code with a module system, you have to export anything you want to use elsewhere, and import it in modules where you need it. Node.js uses module.exports = ... to export and ... = require("module-to-import") to import.

              1 Reply Last reply Reply Quote 1
              • 1
              • 2
              • 1 / 2
              1 / 2
              • First post
                10/11
                Last post
              Enjoying MagicMirror? Please consider a donation!
              MagicMirror created by Michael Teeuw.
              Forum managed by Sam, technical setup by Karsten.
              This forum is using NodeBB as its core | Contributors
              Contact | Privacy Policy