Annual Dates are off by one day in default Calendar module

ctkjedi

@sdetweil goddang daylight saving time! I really hope they follow through this time and get rid of it.

I’m not really sure where the start date was set though. I only added it to this particular calendar a few days ago and there isn’t a way, that I can see, to edit it.

sdetweil

@ctkjedi I submitted a fix for this issue, #2483
and the fix has been accepted for next release.

ctkjedi

@sdetweil Awesome. thanks for the follow up!

ctkjedi

@sdetweil This may or may not be related, so I’m happy to start a new thread.

I have a weekly D&D game, scheduled for every Saturday evening. The ICS reads as

BEGIN:VEVENT
DTSTART;TZID=America/Los_Angeles:20210319T200000
DTEND;TZID=America/Los_Angeles:20210319T230000
DTSTAMP:20210316T001016Z
UID:**REDACTED**
RECURRENCE-ID;TZID=America/Los_Angeles:20210320T200000
CREATED:20210213T021153Z
DESCRIPTION:**REDACTED**
LAST-MODIFIED:20210315T194037Z
LOCATION:**REDACTED**
SEQUENCE:1
STATUS:CONFIRMED
SUMMARY:D&D
TRANSP:OPAQUE
END:VEVENT

However, I rescheduled this week’s event for Friday, which reflects correctly on Google Calendar, but now all the entries on the mirror have been re-calculated as being on every Friday going forward.

sdetweil

@ctkjedi can u show the updated ics event with the rule (repeating rule)…

this one is not repeating

ctkjedi

@sdetweil

BEGIN:VEVENT
DTSTART;TZID=America/Los_Angeles:20210227T200000
DTEND;TZID=America/Los_Angeles:20210227T230000
RRULE:FREQ=WEEKLY;BYDAY=SA
DTSTAMP:20210316T001016Z
UID:**REDACTED**
CREATED:20210213T021153Z
DESCRIPTION:**REDACTED**
LAST-MODIFIED:20210227T015344Z
LOCATION:Roll20.net
SEQUENCE:0
STATUS:CONFIRMED
SUMMARY:D&D
TRANSP:OPAQUE
END:VEVENT

sdetweil

@ctkjedi thanks… I submitted fix #2488 for this… the library that does repeating rules ASSUMES the date is in local time, not utc time (from the ical parser library)

this fix has also been accepted for next release (April 1)

ctkjedi

@sdetweil Rockin!

Memphismark

@ctkjedi The module is fine. Well, kinda. I had a problem where weekly events were showing up 6 days late. My problem was I had Google Calendar repeat frequency set to “weekly.” It started working when I set it to “every 7 days.”

Adjust the frequency on Google and see what it does.

sdetweil

@memphismark thanks. there were a couple more bugs related to daylight savings, and full day events.

one more fix to go in