Annual Dates are off by one day in default Calendar module

sdetweil

@ctkjedi this is usually because the date in the ICS file isn’t right…

can u show me one entry from the ics file, its just text, each event is
begin vevent
to
end vevent

ctkjedi

BEGIN:VEVENT
DTSTART;TZID=America/Los_Angeles:19520402T000000
DTEND;TZID=America/Los_Angeles:19520403T000000
RRULE:FREQ=YEARLY;WKST=SU;UNTIL=20361231T000000Z
DTSTAMP:20210316T001016Z
UID:**REDACTED**
CREATED:20210314T202209Z
DESCRIPTION:
LAST-MODIFIED:20210314T202209Z
LOCATION:
SEQUENCE:0
STATUS:CONFIRMED
SUMMARY:Mom's birthday
TRANSP:OPAQUE
END:VEVENT

This SHOULD be on April 2nd, but it’s displaying on the mirror as the 3rd. On Google Calendar, it’s fine.

ctkjedi

@sdetweil I tried defaulting back to a standard config and I’m seeing the same off results. I’m noticing it’s not just annual dates, but any regular repeating dates.

sdetweil

@ctkjedi well, in this particular case the daylight savings adjustment calculation is wrong, so we get off a day

in 1952, DST starts on April 27th
in 1992. DST starts on April 5th
in 2007 DST starts on March 11

the date/time gave me the right offset but i ‘assumed’ it was same as now…

if u reset the start year of the entry to 2008, it comes out right…

next release is on april 1st… don’t know if I can get this change in by then

ctkjedi

@sdetweil goddang daylight saving time! I really hope they follow through this time and get rid of it.

I’m not really sure where the start date was set though. I only added it to this particular calendar a few days ago and there isn’t a way, that I can see, to edit it.

sdetweil

@ctkjedi I submitted a fix for this issue, #2483
and the fix has been accepted for next release.

ctkjedi

@sdetweil Awesome. thanks for the follow up!

ctkjedi

@sdetweil This may or may not be related, so I’m happy to start a new thread.

I have a weekly D&D game, scheduled for every Saturday evening. The ICS reads as

BEGIN:VEVENT
DTSTART;TZID=America/Los_Angeles:20210319T200000
DTEND;TZID=America/Los_Angeles:20210319T230000
DTSTAMP:20210316T001016Z
UID:**REDACTED**
RECURRENCE-ID;TZID=America/Los_Angeles:20210320T200000
CREATED:20210213T021153Z
DESCRIPTION:**REDACTED**
LAST-MODIFIED:20210315T194037Z
LOCATION:**REDACTED**
SEQUENCE:1
STATUS:CONFIRMED
SUMMARY:D&D
TRANSP:OPAQUE
END:VEVENT

However, I rescheduled this week’s event for Friday, which reflects correctly on Google Calendar, but now all the entries on the mirror have been re-calculated as being on every Friday going forward.

sdetweil

@ctkjedi can u show the updated ics event with the rule (repeating rule)…

this one is not repeating

ctkjedi

@sdetweil

BEGIN:VEVENT
DTSTART;TZID=America/Los_Angeles:20210227T200000
DTEND;TZID=America/Los_Angeles:20210227T230000
RRULE:FREQ=WEEKLY;BYDAY=SA
DTSTAMP:20210316T001016Z
UID:**REDACTED**
CREATED:20210213T021153Z
DESCRIPTION:**REDACTED**
LAST-MODIFIED:20210227T015344Z
LOCATION:Roll20.net
SEQUENCE:0
STATUS:CONFIRMED
SUMMARY:D&D
TRANSP:OPAQUE
END:VEVENT

sdetweil

@ctkjedi thanks… I submitted fix #2488 for this… the library that does repeating rules ASSUMES the date is in local time, not utc time (from the ical parser library)

this fix has also been accepted for next release (April 1)

ctkjedi

@sdetweil Rockin!

Memphismark

@ctkjedi The module is fine. Well, kinda. I had a problem where weekly events were showing up 6 days late. My problem was I had Google Calendar repeat frequency set to “weekly.” It started working when I set it to “every 7 days.”

Adjust the frequency on Google and see what it does.

sdetweil

@memphismark thanks. there were a couple more bugs related to daylight savings, and full day events.

one more fix to go in

Memphismark

@sdetweil said in Annual Dates are off by one day in default Calendar module:

@memphismark thanks. there were a couple more bugs related to daylight savings, and full day events.

one more fix to go in

Specifically, it was a weekly occurrence that started after 6pm on Saturdays. It worked fine any other time and DOW. It busted my brain until I solved it by doing the IDIC thing. :-)

sdetweil

@memphismark idic?