MMM-DumpsterDay

DeanoNoire

I also needed to change the date on each of the cans within the same MagicMirror/config/config.js file

basicStartDate: “11.13.2019”,
plasticStartDate: “11.13.2019”,
landscapeStartDate: “11.13.2019”,

Please note the date format in the config should be DD.MM.YYYY, the only format making sense :P

If you were testing this on 11.11.2019, the month and day commutable :D

BD0G

@DeanoNoire Thats not how the default dates in the MagicMirror/config/config.js were listed from what I recall. They were/are MM.DD.YYYY.

Here is the sample entry that is on the github repository and it lists 24.10.2019 which has to be MM:DD:YYYY. There is no 24th month. :)

enableBasic: true, 				// Enable basic trashcan 
	basicStartDate: "24.10.2019", 	// The first dumpster day (Always use 2 digit dates (01 instead of 1))
	basicDateDiff_1: 14,			// Trashday reoccurance - Default: 14 (every 14 days)
	basicNotifyDayBefore: true,		//Default: true - If you want the notification to appear also the day before the dumpster day
	
enablePlastic: true,			// Same values as basic but for Plastic
	plasticStartDate: "16.01.2019", 
	plasticDateDiff_1: 28,
	plasticNotifyDayBefore: true,	

	enableLandscape: false,			// Same values as basic but for Landscape
	landscapeStartDate: "29.10.2019",
	landscapeDateDiff_1: 28,		
	landscapeNotifyDayBefore: true,

DeanoNoire

@BD0G That would be playing with the width of the elements in the css file. I will check the options of making it a config key as well. But later today - just got to work :)
Thanks for all the ideas and work done! :)

DeanoNoire

@BD0G
0_1573539688283_433415f3-f6fa-4bc0-a71a-25f00520e2cd-image.png
added :)

BD0G

@DeanoNoire Just saw that! Thanks!
Error in spelling of the word clone in the instructions. Its spelled colne.

Just FYI.

DeanoNoire

@BD0G Exactly: 24 = DD, 10=MM, 2019=YYYY, so 24.10.2019 is DD.MM.YYYY, an European standard format :)
What I quoted from your post: 11.13.2019 is not applicable as there is no 13th month :)

var startDateYear = startDate.substring(6,10);
var startDateMonth = startDate.substring(3,5);
var startDateDay = startDate.substring(0,2);

That’s the exact code that cuts the date to year, month and day variables, so day is the first two numbers, month are another two numbers and year are last four numbers :)

BD0G

This post is deleted!

BD0G

@DeanoNoire Ahh , thats what is causing the issue.
US Format is Month:Day:Year and not
the European Standard Day:Month:Year.

mrdenmark

@BD0G
i thought i had it working but no,all the icons show up ok but i can’t get them showing on the correct days,either all or basic.
what did you change on the date?both entries look the same to me,also,did you leave the entry at false?does it still show on the expected day?

BD0G

I set up my config.js to todays date (for testing) so that I could see the trash can icons show up. The format that one needs to use is Day.Month.Year on the
basicStartDate:
plasticStartDate:
landscapeStartDate:
lines

Here is my config.js which does display the cans as it should.

		{
	module:"MMM-DumpsterDay",
	position:"bottom_bar",
	config: {
		refreshInterval: 18000000, // Default: 18000000 = 5 hours
		pulse: true, 			   // Default: true - Makes the module pulsating

		enableBasic: true, 				// Enable basic trashcan 
		basicStartDate: "11.11.2019", 	// The first dumpster day (Always use 2 digit dates (01 instead of 1))
		basicDateDiff_1: 7,			// Trashday reoccurance - Default: 14 (every 14 days)
		basicNotifyDayBefore: true,		//Default: true - If you want the notification to appear also the day before the dumpster day
		
		enablePlastic: false,			// Same values as basic but for Plastic
		plasticStartDate: "11.11.2019", 
		plasticDateDiff_1: 28,
		plasticNotifyDayBefore: true,	

		enableLandscape: true,			// Same values as basic but for Landscape
		landscapeStartDate: "11.11.2019",
		landscapeDateDiff_1: 14,		
		landscapeNotifyDayBefore: true,
		}		
		},

When I change the dates to the 13th of this month then the trash cans are not shown as they should not be shown until the day BEFORE trash day and the DAY of trash day. Which would be tomorrow and the day after.

mrdenmark

@BD0G
and you leave enableplastic set to false?and it still shows up on the weeks it should?

mrdenmark

if i use this config all bins show-

{
	module:"MMM-DumpsterDay",
	position:"top_left",
	config: {
		refreshInterval: 18000000, // Default: 18000000 = 5 hours
		pulse: false, 			   // Default: true - Makes the module pulsating

		enableBasic: true, 				// Enable basic trashcan 
		basicStartDate: "12.11.2019", 	// The first dumpster day (Always use 2 digit dates (01 instead of 1))
		basicDateDiff_2: 7,			// Trashday reoccurance - Default: 14 (every 14 days)
		basicNotifyDayBefore: true,		//Default: true - If you want the notification to appear also the day before the dumpster day
		
		enablePlastic: true,			// Same values as basic but for Plastic
		plasticStartDate: "12.11.2019", 
		plasticDateDiff_2: 14,
		plasticNotifyDayBefore: true,	

		enableLandscape: true,			// Same values as basic but for Landscape
		landscapeStartDate: "12.11.2019",
		landscapeDateDiff_2: 14,		
		landscapeNotifyDayBefore: true,
		}		
		},

if i use this then 2 bins show-

{
	module:"MMM-DumpsterDay",
	position:"top_left",
	config: {
		refreshInterval: 18000000, // Default: 18000000 = 5 hours
		pulse: false, 			   // Default: true - Makes the module pulsating

		enableBasic: true, 				// Enable basic trashcan 
		basicStartDate: "12.11.2019", 	// The first dumpster day (Always use 2 digit dates (01 instead of 1))
		basicDateDiff_2: 7,			// Trashday reoccurance - Default: 14 (every 14 days)
		basicNotifyDayBefore: true,		//Default: true - If you want the notification to appear also the day before the dumpster day
		
		enablePlastic: false,			// Same values as basic but for Plastic
		plasticStartDate: "12.11.2019", 
		plasticDateDiff_2: 14,
		plasticNotifyDayBefore: true,	

		enableLandscape: true,			// Same values as basic but for Landscape
		landscapeStartDate: "12.11.2019",
		landscapeDateDiff_2: 14,		
		landscapeNotifyDayBefore: true,
		}		
		},

but if i change it to either of these then only the basic shows up -

enablePlastic: true,			// Same values as basic but for Plastic
		plasticStartDate: "18.11.2019",

or

enablePlastic: false,			// Same values as basic but for Plastic
		plasticStartDate: "18.11.2019",code_text

maybe i’m misunderstanding but it seems the second last one is the one i require.

for reference my red get picked up every monday and the other 2 alternate every 2 weeks,again on monday

mrdenmark

@mrdenmark apologies foe formatting above!

DeanoNoire

@mrdenmark if you set the date to 18.11.2019 and the occurance is every 14 days then it’s correct :)
If the enable value is true - the image is not visible as it’s not a trashcan day.
If the enable value is false - the part of the module is disabled and is not evaluated at all. Also I recommend to use start dates from the past, not future :)

BD0G

Since the Red Can graphic was added to the github repository my MagicMirror update-notification module indicates an update is needed to the MMM-DumpsterDay module. This made me think that it would be good to add the update process to the github repository instructions.

I just did a
git fetch and then a
git pull

from within the MagicMirror/modules/MMM-DumpsterDay sub directory and that updated the module.

Doughboy99

Re: MMM-DumpsterDay

I am having problems getting the bins to show correctly. I have three different bin collections

Rubbish(basic) collected fortnightly on thursdays next collection due 21st November
Recycling(plastic) collected fortnightly on thursdays next collection due 14th November
Composting(landscape) collected fortnightly on Mondays next collection due 25th November

The icon for the plastic collection is displayed as expected but the landscaping icon is also showing today(14th) even though it is not due until the 25th. Any ideas what the issue is?

This is the config file I am using
{module:“MMM-DumpsterDay”,
position:“lower_third”,

		config: {
			refreshInterval: 18000000, // Default: 18000000 = 5 hours
			pulse: true, 			   // Default: true - Makes the module pulsating
		
		enableBasic: true, 				// Enable basic trashcan 
			basicStartDate: "24.10.2019", 	// The first dumpster day (Always use 2 digit dates (01 instead of 1))
			basicDateDiff_1: 14,			// Trashday reoccurance - Default: 14 (every 14 days)
			basicNotifyDayBefore: true,		//Default: true - If you want the notification to appear also the day before the dumpster day
			
		enablePlastic: true,			// Same values as basic but for Plastic
			plasticStartDate: "31.10.2019", 
			plasticDateDiff_1: 14,
			plasticNotifyDayBefore: true,	

		enableLandscape: true,			// Same values as basic but for Landscape
			landscapeStartDate: "14.10.2019",
			landscapeDateDiff_1: 14,		
			landscapeNotifyDayBefore: true,
		
		}
		},

sdetweil

@mrdenmark said in MMM-DumpsterDay:

apologies foe formatting above!

fixed…
the three tildes need to be on a separate line by themselves

Doughboy99

@Doughboy99
I think I have found the issue for me.
in MMM-DumpsterDay.js the if statement

	if (enableLandscape == true){
	landscapeTrashDayResult = this.isPlasticTrashDay();
	Log.info("landscapeTrashDayResult: "+landscapeTrashDayResult);
	var landscapeDiv = document.createElement("div");
	landscapeDiv.className = "landscapeDiv";
	wrapper.appendChild(landscapeDiv);
		if (landscapeTrashDayResult == 0){
		landscapeDiv.classList.add("non_today")
		}

line 83 should read

landscapeTrashDayResult = this.isLandscapeTrashDay();

This seems to fix my issue.

BD0G

@Doughboy99
Good catch. Seems logical that the statement should pertain to Landscape because of what precedes it.

I made the change to my MMM-DumpsterDay.js . You can report the issue via github and the author @DeanoNoire can add the changes.

Here is the link to report github MMM-DumpsterDay Issues

Doughboy99

@BD0G Thanks Ive posted an issue. Your link is to another reposirory for a similar module .
The correct link is here