MMM-SoccerLiveScore

[np27np27]

@0m4r
No problem, thanks for trying and keeping this module going 👍🏾👍🏾

[0m4r]

@np27np27 can you try check out and run this branch:
https://github.com/0m4r/MMM-SoccerLiveScore/tree/feature/node-fetch

> cd [YOUR_PATH_TO_MMM-SoccerLiveScore]
> git fetch -p
> git checkout feature/node-fetch 
> git pull -r
> npm ci
> [RESTART MM]

I did do some major changes (removed request for node-fetch, and some other code improvements amongst which I hope to have fixed the problem of the refresh you reported)

[np27np27]

@0m4r said in MMM-SoccerLiveScore:

@np27np27 can you try check out and run this branch:
https://github.com/0m4r/MMM-SoccerLiveScore/tree/feature/node-fetch

> cd [YOUR_PATH_TO_MMM-SoccerLiveScore]
> git fetch -p
> git checkout node-fetch
> git pull -r
> npm ci
> [RESTART MM]

I did do some major changes (removed request for node-fetch, and some other code improvements amongst which I hope to have fixed the problem of the refresh you reported)

Hi @0m4r ,

Ive tried the above but got an error at the checkout node-fetch line. Can’t find the file or something similar?
Still continued on and did the rest.
The mm restart has updated the module data. I will check when a game plays tonight to see if the live data changes.

[0m4r]

This post is deleted!

[0m4r]

@np27np27 said in MMM-SoccerLiveScore:

git checkout node-fetch

should be:

git checkout feature/node-fetch

[np27np27]

@0m4r
OK tried again, this time I received the following after npm ci

npm WARN prepare removing existing node_modules/ before installation
npm ERR! cipm can only install packages when your package.json and package-lock.json or npm-shrinkwrap.json are in sync. Please update your lock file with npm install before continuing.
npm ERR!
npm ERR!
npm ERR! Invalid: lock file’s node-fetch@2.6.6 does not satisfy node-fetch@v2.6.1
npm ERR!

npm ERR! A complete log of this run can be found in:
npm ERR! /home/pi/.npm/_logs/2021-12-06T22_20_06_917Z-debug
.log

[np27np27]

@np27np27 said in MMM-SoccerLiveScore:

@0m4r
OK tried again, this time I received the following after npm ci

npm WARN prepare removing existing node_modules/ before installation
npm ERR! cipm can only install packages when your package.json and package-lock.json or npm-shrinkwrap.json are in sync. Please update your lock file with npm install before continuing.
npm ERR!
npm ERR!
npm ERR! Invalid: lock file’s node-fetch@2.6.6 does not satisfy node-fetch@v2.6.1
npm ERR!

npm ERR! A complete log of this run can be found in:
npm ERR! /home/pi/.npm/_logs/2021-12-06T22_20_06_917Z-debug
.log

I did npm install then npm Ci and it seems no errors this time. Let’s see if it works now. I’ll let you know 👍🏾

[np27np27]

@0m4r,

Looks like it’s still not working. It’s gone past the api call date that is displayed at the bottom of the module and it’s not updated. Does it work for you?

[0m4r]

@np27np27 can you try pulling the code once more? I did mess up the logic to re-issue the API requests, but I hopefully fixed it now!

[np27np27]

@0m4r
Yes will try later today. Thanks for your continued effort 👍🏾

[0m4r]

@np27np27 there are probably still some issue, but it seems to me it now updates correctly :)

[np27np27]

@0m4r
No I don’t think it’s updating for me.
Maybe I need to delete the whole module and start again. I did get a few errors during the update to your new changes.
Can I reinstall from the main branch or do I reinstall and then update again how you mentioned above?

[0m4r]

@np27np27 I am sorry to hear that :(
you should try again from the feature/node-fetch .

if you see any errors, would you please cut&paste them in here so I can have a look at them?

would you also mind showing me your config for the module?

[np27np27]

@0m4r
Ok ive reinstalled and successfully updated to the feature/fetch-node branch. I think it all installed error free this time!!

Lets see how things look later today after during the premier league games. I’ll let you know how it goes.

My config for the module:

	{
		disabled: false,
		module: 'MMM-SoccerLiveScore',
		position: 'top_right',
		header: 'Live-Scores',
		config: {
			leagues: [17],
  			showNames: true,
 			showLogos: true,
 			displayTime: 20 * 1000,
  			showStandings: true,
  			showTables: true,
  			showScorers: false,
		}
	},

[0m4r]

@np27np27

and can you see something like this in the logs:
MMM-SoccerLiveScore next request for league "Premier League (17)" on Tue Dec 14 2021 14:34:37 GMT+0100 (Central European Standard Time) for Round 17

[np27np27]

@0m4r
Yes the next request date seems to be updating now. So I think its working. Brentford vs ManU is postponed today so it’s a little difficult to gauge if it’s truly working at the moment. Will confirm it later tonight when the rest of the games go live!

[np27np27]

@0m4r
It seems to be updating fine now and the api calls all look good and at the right times during live games. Thanks for fixing the module 👍🏾👍🏾

I do have a bug to report… The module does not handle postponed games well. It does not recognise postponed games, starts these matches as normal and they never end or complete. I see this with the Brentford-ManU game from last night. According to the module the game started and is still playing 😂.

[0m4r]

@np27np27 if you pull once again, I did a quick fix to mark them in orange.
I will look into the API requests side of the things… but better too many than too few! :D

[np27np27]

@0m4r
Hi, yes just updated and noticed the change to orange! Maybe a change to P-P would be better but I guess it all depends on how you have written the code and the api calls. 👍🏾
But it all seems to work now, thanks again 😊😊

[np27np27]

@0m4r looks like the module is still not updating on my system. It seemed to update for a day or two but now has stopped.
How does it seem on your mm2?