Calendar Module - Unable to load Facebook Birthdays

robbythedude

I ran my Facebook Birhtday ICS file through this site: http://severinghaus.org/projects/icv/
Got this response: http://imgur.com/YW07yKU

Is this normal?

squidsmarks

Both my Facebook calendar links are different. Birthdays contains a b.php and events is u.php. Tried birthdays by itself and still didn’t work.

KirAsh4

For those of you who are having issues with your Facebook Birthdays calendar … if any of you want to PRIVATELY send me your actual link, I will stick it in my config and see what happens. Presumably it will fail the same way it is for you guys, but at least I’ll have something to test against since mine are working just fine. I don’t have a failed test case … I promise not to sell your information.

squidsmarks

I think we sold our information the moment we signed up to Facebook. Happy to send you the link and see what happens.

KirAsh4

I have Robby’s at the moment, trying to recreate the problem.

KirAsh4

Or maybe it’s because I’m trying to debug from the command line … as always …

Looks like Facebook is returning an ‘unsupported browser’ page when we try to fetch the data. Well aren’t they clever. Time to do some code massaging …

KirAsh4

So here’s the fun part … mine was working. Because I hadn’t gone a 'git pull' in a while on my dev tree, so I never saw the change. Now that I am current, it’s not working. So, none of you are any more crazy than we all are, it really isn’t working. I’m running some debugging and trying to figure out where and why it’s failing.

robbythedude

@KirAsh4 said in Calendar Module - Unable to load Facebook Birthdays:

So here’s the fun part … mine was working. Because I hadn’t gone a 'git pull' in a while on my dev tree, so I never saw the change. Now that I am current, it’s not working. So, none of you are any more crazy than we all are, it really isn’t working. I’m running some debugging and trying to figure out where and why it’s failing.

We’ll have to recruit more QA peeps for future commits! :P haha

KirAsh4

Yeah, not as easy as it sounds. For those who enjoy seeing the nitty gritty, this is what happens with the various calendar payloads and you can clearly see the FB one failing:

Working on trying to figure out why since it does work from the command line, but not in browser.

robbythedude

@KirAsh4 said in Calendar Module - Unable to load Facebook Birthdays:

Yeah, not as easy as it sounds. For those who enjoy seeing the nitty gritty, this is what happens with the various calendar payloads and you can clearly see the FB one failing:

Working on trying to figure out why since it does work from the command line, but not in browser.

What is the tool you’re using in that screenshot to test this out?

KirAsh4

Firebug extension in Firefox. Though most browsers have a basic console output if you just hit F12. And the data that you see there is normally not visible. I added those output streams in my dev tree so I can see what’s going on.

KirAsh4

Ok, I need some testers … this is working for me with a small change in our fetcher code. So, for those willing to try, please following these steps:

Step 1
Navigate to the 'MagicMirror/modules/default/calendar/' folder

Step 2
Open the 'calendarfetcher.js' file in your favorite editor and look for the following line and delete it:

ical.fromURL(url, {}, function(err, data) {

Step 3
After deleting that line, in its place you’re going to paste in the following snippet of code:

    var opts = {
        headers: {
            'User-Agent': 'Mozilla/5.0 (Node.js 6.0.0) MagicMirror/2.0 (https://github.com/MichMich/MagicMirror)'
        }
    }
    ical.fromURL(url, opts, function(err, data) {

Please note that very last line, it’s almost identical to the one you deleted. Only one piece changed and you must put that line in as modified above!

Step 4
Save and close the file, and relaunch your MM process.

Step 5
Report back to me.

On my setup, it’s working. I’m getting this in my calendar now. (The names you see are birthdays, I simply have a filter to remove 's birthday' form the string that Facebook returns.)

KirAsh4

Got home, did a full reset on my dev tree, added the above code piece and this is what I get. Waiting on more confirmation from others before I push this up to the main repo.

robbythedude

@KirAsh4 said in Calendar Module - Unable to load Facebook Birthdays:

Ok, I need some testers … this is working for me with a small change in our fetcher code. So, for those willing to try, please following these steps:

Step 1
Navigate to the 'MagicMirror/modules/default/calendar/' folder

Step 2
Open the 'calendarfetcher.js' file in your favorite editor and look for the following line and delete it:
ical.fromURL(url, {}, function(err, data) {
Step 3
After deleting that line, in its place you’re going to paste in the following snippet of code:
    var opts = {
        headers: {
            'User-Agent': 'Mozilla/5.0 (Node.js 6.0.0) MagicMirror/2.0 (https://github.com/MichMich/MagicMirror)'
        }
    }
    ical.fromURL(url, opts, function(err, data) {
Please note that very last line, it’s almost identical to the one you deleted. Only one piece changed and you must put that line in as modified above!

Step 4
Save and close the file, and relaunch your MM process.

Step 5
Report back to me.

On my setup, it’s working. I’m getting this in my calendar now. (The names you see are birthdays, I simply have a filter to remove 's birthday' form the string that Facebook returns.)

Made these changes, we are good! Works now :dark_sunglasses: Thank you so much for all the help.

andy952

Doesn’t seem to fix it for me :/

KirAsh4

@andy952, can you send me your calendar link privately and I’ll test it out on my system, see if I find any errors.

pugsly

this fixes the problem for me as well.

squidsmarks

Awesome! Facebook birthdays and events are working again :)
Thanks for your help.

KirAsh4

With the majority of you saying it’s working with the above change, I went ahead and made a pull request against the branch. When @MichMich has time, he’ll review and merge. I’m still waiting to hear from @andy952 to see if there still is a problem.

MichMich

@KirAsh4 Just got back from my holiday. Almost ready to merge your PR. One small issue: see GitHub.