MMM-Calendar always shows 23:59 if showEndTime: True

[SwissChemist]

@sdetweil
Wow, that looks great! Thanks very much for your endurance!

There is only that persistent ‘3-weekly whole day’ problem. It’s still one day too late. Most probably that’s so difficult, as it is a user defined interval, something strange seems to bring the parser to a wrong date…
For testing, I have added a 3-daily event. This shows correct start/end…

But the rest is great! Thanks very much!!!

[sdetweil]

@SwissChemist check the end date in your cal entry it was set for the next day.

2 -day event

[SwissChemist]

@sdetweil
All whole day events start at the right day and end one day later. There is no difference in the calendar file, whether it is a weekly, 2-weekly or 3-weekly event.
That’s why I do not understand, why weeklies and 2-weeklies are shown correctly and the 3-weekly is shown one day too late…

[sdetweil]

@SwissChemist but, whole day events are defined as starting and ending on the SAME day.

[sdetweil]

@SwissChemist yeh, that 3-weekly whole day event seems to cause a problem in the rule handler…

for THAT rule, it returns the repeating day as the 1st of the 2, (the last of the 2 for the others)
but if u take off the ;BYDAY=TH
is works properly… (and gives the thrusday date)

so, some bug in the rrule module… (not our code)

that is also the only weekly whole day rule you have which has a ByDay set.

[SwissChemist]

@sdetweil
As I wondered if the format of an 3-weekly event in ical has an issue, I set up a 3-weekly event in Google calendar and compared the files:

BEGIN:VEVENT
DTSTART;VALUE=DATE:20201005
DTEND;VALUE=DATE:20201006
RRULE:FREQ=WEEKLY;INTERVAL=3;BYDAY=MO
DTSTAMP:20201005T195008Z
UID:835F136F-35A4-44C6-AA16-481F02E5A2D1
CREATED:20201005T120626Z
DESCRIPTION:
LAST-MODIFIED:20201005T120626Z
LOCATION:
SEQUENCE:0
STATUS:CONFIRMED
SUMMARY:3-weekly whole day test
TRANSP:OPAQUE
END:VEVENT

Event has been set to 5th of October and DTEND is also one day later than DTSTART for a whole-day-event and it also shows a BYDAY, that means it’s absolutely identical to the ical file…

[sdetweil]

@SwissChemist like I said, bug in the repeating rule processor, RRULE. not our code.

Remove the byday, or the second day

[SwissChemist]

@sdetweil
Sorry for asking:
If I would import a calendar file from a text file, it would be easy to do the correction (change DTEND or remove BYDAY) in any text editor.
But how to proceed if I directly import data from *.ics link? Is there any ‘hack’ I could apply?
Thanks very much for your patience… All other data are really great now! And somehow I rely on a 3-weekly whole day, as we use to have 3-week iterations in our SCRUM process…

[sdetweil]

@SwissChemist you could create a batch script, run off cron, or started w pm2 (and use sleep to wait)

curl to download the ics,
sed to fix the file,
and put it into the calendar module folder, and
config mm to use it from there

[SwissChemist]

@sdetweil
Thanks very much for your help! I highly appreciate it!

[sdetweil]

@SwissChemist my pleasure… here is how I config MM to use your file
(note my mm is on a different port)

calendars: [
	{
            url: "http://localhost:8090/modules/default/calendar/school-timetable.ics"
        }
]

[SwissChemist]

@sdetweil
Thanks for the example. Looks like a next project for me… :thumbs_up:

[sdetweil]

@SwissChemist

could look something like this

#!/bin/bash
fn=somecal.ics
while true
  do 
      # get the file from server
      curl -sL  url_of_remote_ics  >$fn
      # remove the trailing byday=??(end of line), file inline, so changed
      sed -i -e "s/;BYDAY=.*$//g" $fn
     # copy the modified file to the calendar folder
      cp $fn ~/MagicMirror/modules/default/calendar
     # sleep til next cycle
      sleep ??? (seconds til next curl)
   done

have to make this executable with chmod +x script_filename

then
pm2 start script_filename
pm2 save

if you use a json config file ui can give a pretty name of the script… see the installers/pm2_magicmirror.json
pm2 start jsonfile
pm2 save

[sdetweil]

@SwissChemist I submitted this issue to the RRULE repo
https://github.com/jakubroztocil/rrule/issues/426

[SwissChemist]

@sdetweil
Wow, thank you so much for your great support!

[SwissChemist]

@sdetweil This morning we switched from DST to STD time. No issue at all with the calendar, everything works fine!
Again, thanks very much for your support!

[sdetweil]

@SwissChemist nice, thanks for the update

[A Former User]

This post is deleted!

[A Former User]

@hango: yes that why i have planned to coding mine…

Calendar default module is really so bugy for me …
sample :

0|MagicMirror  | [2020-10-25 21:17:41.162] [LOG]    Use existing calendar fetcher for url: https://calendar.google.com/calendar/ical/XXXX.ics
0|MagicMirror  | [2020-10-25 21:17:41.164] [INFO]   Calendar-Fetcher: Broadcasting 5 events.
0|MagicMirror  | [2020-10-25 21:17:41.715] [INFO]   Calendar-Fetcher: Broadcasting 5 events.

and some timethere is 3 broadcasts … result 2 or 3 updates on mirror

I don’t know really what they do with this modules… and I will NOT correct it !
In all case, it’s horrible

[sdetweil]

@hango have fun. there are 3 libraries below the mm code. all broken or in disagreement over the format of the date and time. and windows is a whole nother mess

why I work my a… off for you … I begin to wonder.

2.11 might work for you but it doesn’t for others. and I didn’t start the changes.