MagicMirror Forum
    • Recent
    • Tags
    • Unsolved
    • Solved
    • MagicMirror² Repository
    • Documentation
    • 3rd-Party-Modules
    • Donate
    • Discord
    • Register
    • Login
    A New Chapter for MagicMirror: The Community Takes the Lead
    Read the statement by Michael Teeuw here.

    "absolute" does not mean absolute in default calendar module

    Scheduled Pinned Locked Moved Troubleshooting
    20 Posts 4 Posters 3.0k Views 4 Watching
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • S Offline
      sdetweil @Alvinger
      last edited by

      @Alvinger what branch did u use when u made your changes?

      Sam

      How to add modules

      learning how to use browser developers window for css changes

      AlvingerA 1 Reply Last reply Reply Quote 0
      • AlvingerA Offline
        Alvinger @Guest
        last edited by Alvinger

        @hango I just checked the development branch of MM and changed the following files. It now works perfectly on my Ipad2. Of course, if you use non-default modules you may have to edit them as well.

        • modified: js/electron.js
        • modified: js/translator.js
        • modified: modules/default/alert/alert.js
        • modified: modules/default/alert/notificationFx.js
        • modified: modules/default/calendar/calendar.js
        • modified: modules/default/compliments/compliments.js
        • modified: modules/default/newsfeed/newsfeed.js
        • modified: modules/default/updatenotification/updatenotification.js
        • modified: modules/default/weather/weather.js
        • modified: modules/default/weather/weatherobject.js
        • modified: modules/default/weatherforecast/weatherforecast.js

        The changes I made to the above files are:

        1. Changed all “let” to “var”.
        2. Changed all “() =>” to “function ()”. Also, you have to make sure that the expression following “function ()” is enclosed in curly braces “{}”, i.e. no one-liners!
        ? 1 Reply Last reply Reply Quote 0
        • BKeyportB Offline
          BKeyport Module Developer @Alvinger
          last edited by

          @Alvinger That’s the one relative time I can agree with, honestly. Give me a timer so I can kick people out of my office… 🤣🤣

          The "E" in "Javascript" stands for "Easy"

          1 Reply Last reply Reply Quote 0
          • AlvingerA Offline
            Alvinger @sdetweil
            last edited by

            @sdetweil I used develop-hidden-module-update-restriction as that was the one with relevant changes for me

            S 1 Reply Last reply Reply Quote 0
            • S Offline
              sdetweil @Alvinger
              last edited by

              @Alvinger then u can change back to master, and create another branch from there

              git checkout master
              git checkout -b new_name
              

              Sam

              How to add modules

              learning how to use browser developers window for css changes

              1 Reply Last reply Reply Quote 0
              • ? Offline
                A Former User @Alvinger
                last edited by A Former User

                This post is deleted!
                AlvingerA 1 Reply Last reply Reply Quote 0
                • AlvingerA Offline
                  Alvinger @Guest
                  last edited by

                  @hango Okay, I thought electron.js was executed in the browser. But that’s one less file to edit. Also, there were no references to this within the => constructs that I could find.

                  S 1 Reply Last reply Reply Quote 0
                  • S Offline
                    sdetweil @Alvinger
                    last edited by

                    @Alvinger the arrow function () =>{} , makes the use of ‘this’ not needed, because the context is not lost.

                    use of function(){} does change ‘this’

                    Sam

                    How to add modules

                    learning how to use browser developers window for css changes

                    1 Reply Last reply Reply Quote 0
                    • 1
                    • 2
                    • 2 / 2
                    • First post
                      Last post
                    Enjoying MagicMirror? Please consider a donation!
                    MagicMirror created by Michael Teeuw.
                    Forum managed by Sam, technical setup by Karsten.
                    This forum is using NodeBB as its core | Contributors
                    Contact | Privacy Policy