MagicMirror Forum
    • Recent
    • Tags
    • Unsolved
    • Solved
    • MagicMirror² Repository
    • Documentation
    • 3rd-Party-Modules
    • Donate
    • Discord
    • Register
    • Login
    A New Chapter for MagicMirror: The Community Takes the Lead
    Read the statement by Michael Teeuw here.

    "absolute" does not mean absolute in default calendar module

    Scheduled Pinned Locked Moved Troubleshooting
    20 Posts 4 Posters 3.0k Views 4 Watching
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • AlvingerA Offline
      Alvinger @BKeyport
      last edited by Alvinger

      @BKeyport well almost! I have this exact config but running events are still changed to “ends in xx min”! And all day events still shows as “today”

      I’ve done a rewrite of the relevant section of calendar.js but can’t use my github clone repo to make a PR.

      S BKeyportB 2 Replies Last reply Reply Quote 0
      • S Offline
        sdetweil @Alvinger
        last edited by

        @Alvinger u needed to.make a fork, and then clone that. fork button is upper right

        Sam

        How to add modules

        learning how to use browser developers window for css changes

        AlvingerA 1 Reply Last reply Reply Quote 0
        • AlvingerA Offline
          Alvinger @sdetweil
          last edited by Alvinger

          @sdetweil I know. But I have already forked the MM master and made changes to use my Ipad 2. How do I make a new branch containing the latest MM development files? My plan was to wait until the new version was merged into Master and then do my Ipad2-related changes. Github won’t allow me to have multiple repositories with the same name.

          S 1 Reply Last reply Reply Quote 0
          • AlvingerA Offline
            Alvinger
            last edited by

            @sdetweil I have created a PR for the proposed calendar changes.

            1 Reply Last reply Reply Quote 0
            • S Offline
              sdetweil @Alvinger
              last edited by

              @Alvinger what branch did u use when u made your changes?

              Sam

              How to add modules

              learning how to use browser developers window for css changes

              AlvingerA 1 Reply Last reply Reply Quote 0
              • AlvingerA Offline
                Alvinger @Guest
                last edited by Alvinger

                @hango I just checked the development branch of MM and changed the following files. It now works perfectly on my Ipad2. Of course, if you use non-default modules you may have to edit them as well.

                • modified: js/electron.js
                • modified: js/translator.js
                • modified: modules/default/alert/alert.js
                • modified: modules/default/alert/notificationFx.js
                • modified: modules/default/calendar/calendar.js
                • modified: modules/default/compliments/compliments.js
                • modified: modules/default/newsfeed/newsfeed.js
                • modified: modules/default/updatenotification/updatenotification.js
                • modified: modules/default/weather/weather.js
                • modified: modules/default/weather/weatherobject.js
                • modified: modules/default/weatherforecast/weatherforecast.js

                The changes I made to the above files are:

                1. Changed all “let” to “var”.
                2. Changed all “() =>” to “function ()”. Also, you have to make sure that the expression following “function ()” is enclosed in curly braces “{}”, i.e. no one-liners!
                ? 1 Reply Last reply Reply Quote 0
                • BKeyportB Offline
                  BKeyport Module Developer @Alvinger
                  last edited by

                  @Alvinger That’s the one relative time I can agree with, honestly. Give me a timer so I can kick people out of my office… 🤣🤣

                  The "E" in "Javascript" stands for "Easy"

                  1 Reply Last reply Reply Quote 0
                  • AlvingerA Offline
                    Alvinger @sdetweil
                    last edited by

                    @sdetweil I used develop-hidden-module-update-restriction as that was the one with relevant changes for me

                    S 1 Reply Last reply Reply Quote 0
                    • S Offline
                      sdetweil @Alvinger
                      last edited by

                      @Alvinger then u can change back to master, and create another branch from there

                      git checkout master
                      git checkout -b new_name
                      

                      Sam

                      How to add modules

                      learning how to use browser developers window for css changes

                      1 Reply Last reply Reply Quote 0
                      • ? Offline
                        A Former User @Alvinger
                        last edited by A Former User

                        This post is deleted!
                        AlvingerA 1 Reply Last reply Reply Quote 0
                        • 1
                        • 2
                        • 2 / 2
                        • First post
                          Last post
                        Enjoying MagicMirror? Please consider a donation!
                        MagicMirror created by Michael Teeuw.
                        Forum managed by Sam, technical setup by Karsten.
                        This forum is using NodeBB as its core | Contributors
                        Contact | Privacy Policy