"absolute" does not mean absolute in default calendar module

Alvinger

@sdetweil I know. But I have already forked the MM master and made changes to use my Ipad 2. How do I make a new branch containing the latest MM development files? My plan was to wait until the new version was merged into Master and then do my Ipad2-related changes. Github won’t allow me to have multiple repositories with the same name.

Alvinger

@sdetweil I have created a PR for the proposed calendar changes.

sdetweil

@Alvinger what branch did u use when u made your changes?

Alvinger

@hango I just checked the development branch of MM and changed the following files. It now works perfectly on my Ipad2. Of course, if you use non-default modules you may have to edit them as well.

modified: js/electron.js
modified: js/translator.js
modified: modules/default/alert/alert.js
modified: modules/default/alert/notificationFx.js
modified: modules/default/calendar/calendar.js
modified: modules/default/compliments/compliments.js
modified: modules/default/newsfeed/newsfeed.js
modified: modules/default/updatenotification/updatenotification.js
modified: modules/default/weather/weather.js
modified: modules/default/weather/weatherobject.js
modified: modules/default/weatherforecast/weatherforecast.js

The changes I made to the above files are:

Changed all “let” to “var”.
Changed all “() =>” to “function ()”. Also, you have to make sure that the expression following “function ()” is enclosed in curly braces “{}”, i.e. no one-liners!

BKeyport

@Alvinger That’s the one relative time I can agree with, honestly. Give me a timer so I can kick people out of my office… 🤣🤣

Alvinger

@sdetweil I used develop-hidden-module-update-restriction as that was the one with relevant changes for me

sdetweil

@Alvinger then u can change back to master, and create another branch from there

git checkout master
git checkout -b new_name

A Former User

This post is deleted!

Alvinger

@hango Okay, I thought electron.js was executed in the browser. But that’s one less file to edit. Also, there were no references to this within the => constructs that I could find.

sdetweil

@Alvinger the arrow function () =>{} , makes the use of ‘this’ not needed, because the context is not lost.

use of function(){} does change ‘this’